Skip to content

test(codegen): switch to new AstBuilder#23836

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/06-26-test_codegen_switch_to_new_astbuilder_
Jun 26, 2026
Merged

test(codegen): switch to new AstBuilder#23836
graphite-app[bot] merged 1 commit into
mainfrom
om/06-26-test_codegen_switch_to_new_astbuilder_

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #23043. Migrate oxc_codegen over to new AstBuilder.

It only uses AstBuilder in one test, not in the main code.

This was referenced Jun 26, 2026
Merged
Merged
Merged
@overlookmotel Graphite App

overlookmotel commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 26, 2026
Merged
Merged
Merged
@github-actions github-actions Bot added the A-codegen Area - Code Generation label Jun 26, 2026
@overlookmotel overlookmotel mentioned this pull request Jun 26, 2026
Merged
@codspeed-hq

codspeed-hq Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing om/06-26-test_codegen_switch_to_new_astbuilder_ (15a4778) with om/06-26-test_ast_visit_switch_to_new_astbuilder_ (f65bdc1)

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@overlookmotel overlookmotel force-pushed the om/06-26-test_codegen_switch_to_new_astbuilder_ branch from 5369758 to c1d9bcd Compare June 26, 2026 18:02
@overlookmotel overlookmotel mentioned this pull request Jun 26, 2026
Merged
@overlookmotel overlookmotel marked this pull request as ready for review June 26, 2026 18:12
@overlookmotel overlookmotel requested a review from Dunqing as a code owner June 26, 2026 18:12
Copilot AI review requested due to automatic review settings June 26, 2026 18:12
Copilot AI reviewed Jun 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@overlookmotel overlookmotel self-assigned this Jun 26, 2026
@graphite-app

graphite-app Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@overlookmotel
test(codegen): switch to new AstBuilder (#23836)
15a4778 
Part of #23043. Migrate `oxc_codegen` over to new `AstBuilder`.

It only uses `AstBuilder` in one test, not in the main code.
@graphite-app graphite-app Bot force-pushed the om/06-26-test_ast_visit_switch_to_new_astbuilder_ branch from 21599f7 to f65bdc1 Compare June 26, 2026 18:20
@graphite-app graphite-app Bot force-pushed the om/06-26-test_codegen_switch_to_new_astbuilder_ branch from c1d9bcd to 15a4778 Compare June 26, 2026 18:21
Base automatically changed from om/06-26-test_ast_visit_switch_to_new_astbuilder_ to main June 26, 2026 18:42
@graphite-app graphite-app Bot merged commit 15a4778 into main Jun 26, 2026
41 checks passed
@graphite-app graphite-app Bot deleted the om/06-26-test_codegen_switch_to_new_astbuilder_ branch June 26, 2026 18:43
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@overlookmotel @camc314
test(codegen): switch to new AstBuilder (#23836)
ee6858b 
Part of #23043. Migrate `oxc_codegen` over to new `AstBuilder`.

It only uses `AstBuilder` in one test, not in the main code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-codegen Area - Code Generation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel