perf(estree): remove pointless `mem::take` by overlookmotel · Pull Request #23572 · oxc-project/oxc

overlookmotel · 2026-06-17T21:46:11Z

Use CodeBuffer::as_str (added in #23571) to remove an unnecessary mem::take operation when appending fixes to output when serializing AST to ESTree JSON.

overlookmotel · 2026-06-17T21:46:22Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-06-17T21:54:53Z

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks¹

_{Comparing om/06-17-perf_estree_remove_pointless_mem_take_ (053b0c1) with main (4a5063c)²}

9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (053b0c1) during the generation of this report, so 4a5063c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull request overview

This PR simplifies ESTree JSON serialization with fixes by switching from mem::take(...).into_string() to CodeBuffer::as_str(), avoiding an unnecessary buffer move/allocation and keeping the logic purely borrowing-based.

Changes:

Removed the now-unneeded std::mem import.
Updated serialize_with_fixes to borrow fixes_buffer via CodeBuffer::as_str() and print its contents without consuming it.
Added an inline comment clarifying that the leading , is intentionally omitted.

graphite-app · 2026-06-17T22:39:40Z

Merge activity

Jun 17, 10:39 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Jun 17, 10:48 PM UTC: Merged by the Graphite merge queue.

Use `CodeBuffer::as_str` (added in #23571) to remove an unnecessary `mem::take` operation when appending fixes to output when serializing AST to ESTree JSON.

### 💥 BREAKING CHANGES - 7a76cd3 estree: [**BREAKING**] Make whether to include TS fields a runtime option (#23574) (overlookmotel) - e7b6b68 estree: [**BREAKING**] `ESTree` config use methods not consts (#23573) (overlookmotel) ### 🚀 Features - 556cc6d data_structures: Add `CodeBuffer::as_str` method (#23571) (overlookmotel) - 38c4b06 parser: Add friendly error for adjacent JSX elements (#23378) (sapphi-red) - 53509a8 minifier: Treeshake pure typed arrays and Set/Map array literals (#23469) (Dunqing) - 09762d9 minifier: Inline const value for read-only vars (#22593) (Dunqing) ### 🐛 Bug Fixes - 20375f9 react_compiler: Keep imports referenced only by a computed key (#23586) (Boshen) - 31bfd9b minifier: Keep Object introspection calls on a possible Proxy (#23483) (Dunqing) - 837a395 parser: Treat a line comment after ':' as leading, not trailing (#23515) (Dunqing) - e409fe0 minifier: Keep `new Map`/`WeakSet`/`WeakMap` with a string argument (#23470) (Dunqing) - ae02b4e ci/parser: Use `minimal` for vitest reporter (#23457) (camc314) ### ⚡ Performance - cf24329 mangler: Compile slot sort once instead of per CAPACITY (#23577) (Boshen) - 4058a6a parser: Reduce code bloat from verify_modifiers monomorphization (#23576) (Boshen) - 053b0c1 estree: Remove pointless `mem::take` (#23572) (overlookmotel) - dfb52b6 transformer: Pre-size statement vecs in TS enum & namespace lowering (#23516) (Yunfei He) - 970e09a minifier: Compute template-literal inline checks in a single pass (#23467) (Yunfei He) - 3170c0e semantic,mangler,minifier: Fix `Semantic::stats` node count and reuse stats in mangler builds (#23352) (Boshen) - d1fa6e0 minifier: Evaluate ternary branches once in minimize_conditional_expression (#23479) (Yunfei He) - 3fa8051 transformer: Pre-size JSX props vec to attribute count (#23466) (Yunfei He) - 488b382 react_compiler: Borrow binding names in prefilter instead of allocating (#23471) (Yunfei He) - bcb3894 minifier: Incremental scoping refresh, delete LiveUsageCollector (#23197) (Dunqing) ### 📚 Documentation - f68641e data_structures: Improve docs on safety contract (#23575) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

Use `CodeBuffer::as_str` (added in #23571) to remove an unnecessary `mem::take` operation when appending fixes to output when serializing AST to ESTree JSON.

### 💥 BREAKING CHANGES - 7a76cd3 estree: [**BREAKING**] Make whether to include TS fields a runtime option (#23574) (overlookmotel) - e7b6b68 estree: [**BREAKING**] `ESTree` config use methods not consts (#23573) (overlookmotel) ### 🚀 Features - 556cc6d data_structures: Add `CodeBuffer::as_str` method (#23571) (overlookmotel) - 38c4b06 parser: Add friendly error for adjacent JSX elements (#23378) (sapphi-red) - 53509a8 minifier: Treeshake pure typed arrays and Set/Map array literals (#23469) (Dunqing) - 09762d9 minifier: Inline const value for read-only vars (#22593) (Dunqing) ### 🐛 Bug Fixes - 20375f9 react_compiler: Keep imports referenced only by a computed key (#23586) (Boshen) - 31bfd9b minifier: Keep Object introspection calls on a possible Proxy (#23483) (Dunqing) - 837a395 parser: Treat a line comment after ':' as leading, not trailing (#23515) (Dunqing) - e409fe0 minifier: Keep `new Map`/`WeakSet`/`WeakMap` with a string argument (#23470) (Dunqing) - ae02b4e ci/parser: Use `minimal` for vitest reporter (#23457) (camc314) ### ⚡ Performance - cf24329 mangler: Compile slot sort once instead of per CAPACITY (#23577) (Boshen) - 4058a6a parser: Reduce code bloat from verify_modifiers monomorphization (#23576) (Boshen) - 053b0c1 estree: Remove pointless `mem::take` (#23572) (overlookmotel) - dfb52b6 transformer: Pre-size statement vecs in TS enum & namespace lowering (#23516) (Yunfei He) - 970e09a minifier: Compute template-literal inline checks in a single pass (#23467) (Yunfei He) - 3170c0e semantic,mangler,minifier: Fix `Semantic::stats` node count and reuse stats in mangler builds (#23352) (Boshen) - d1fa6e0 minifier: Evaluate ternary branches once in minimize_conditional_expression (#23479) (Yunfei He) - 3fa8051 transformer: Pre-size JSX props vec to attribute count (#23466) (Yunfei He) - 488b382 react_compiler: Borrow binding names in prefilter instead of allocating (#23471) (Yunfei He) - bcb3894 minifier: Incremental scoping refresh, delete LiveUsageCollector (#23197) (Dunqing) ### 📚 Documentation - f68641e data_structures: Improve docs on safety contract (#23575) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

overlookmotel marked this pull request as ready for review June 17, 2026 22:02

Copilot AI review requested due to automatic review settings June 17, 2026 22:02

Copilot started reviewing on behalf of overlookmotel June 17, 2026 22:02 View session

Copilot AI reviewed Jun 17, 2026

View reviewed changes

overlookmotel self-assigned this Jun 17, 2026

perf(estree): remove pointless mem::take (#23572)

053b0c1

Use `CodeBuffer::as_str` (added in #23571) to remove an unnecessary `mem::take` operation when appending fixes to output when serializing AST to ESTree JSON.

graphite-app Bot force-pushed the om/06-17-feat_data_structures_add_codebuffer_as_str_method branch from 3a324c1 to 556cc6d Compare June 17, 2026 22:40

graphite-app Bot force-pushed the om/06-17-perf_estree_remove_pointless_mem_take_ branch from c53d98c to 053b0c1 Compare June 17, 2026 22:41

Base automatically changed from om/06-17-feat_data_structures_add_codebuffer_as_str_method to main June 17, 2026 22:47

graphite-app Bot merged commit 053b0c1 into main Jun 17, 2026
40 checks passed

graphite-app Bot deleted the om/06-17-perf_estree_remove_pointless_mem_take_ branch June 17, 2026 22:48

oxc-guard Bot mentioned this pull request Jun 18, 2026

release(crates): oxc v0.137.0 #23591

Merged

camc314 pushed a commit that referenced this pull request Jul 3, 2026

perf(estree): remove pointless mem::take (#23572)

aba9d41

Use `CodeBuffer::as_str` (added in #23571) to remove an unnecessary `mem::take` operation when appending fixes to output when serializing AST to ESTree JSON.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

perf(estree): remove pointless `mem::take`#23572

perf(estree): remove pointless `mem::take`#23572
graphite-app[bot] merged 1 commit into
mainfrom
om/06-17-perf_estree_remove_pointless_mem_take_

overlookmotel commented Jun 17, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Jun 17, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jun 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app Bot commented Jun 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

overlookmotel commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

graphite-app Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

overlookmotel commented Jun 17, 2026 •

edited

Loading

overlookmotel commented Jun 17, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 17, 2026 •

edited

Loading

graphite-app Bot commented Jun 17, 2026 •

edited

Loading