feat(minifier): treeshake pure typed arrays and Set/Map array literals#23469
Merged
graphite-app[bot] merged 1 commit intoJun 16, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will not alter performance
Comparing Footnotes
|
48bb82e to
bee3c28
Compare
sapphi-red
approved these changes
Jun 16, 2026
Contributor
Merge activity
|
#23469) ## Summary Mark side-effect-free `new` constructions pure so they are dropped when unused (and annotated for downstream tree-shaking): - **TypedArrays** with a non-negative numeric-literal length (`new Int8Array(8)`, `new Uint8Array(1024)`). The buffer allocation runs no user code; a valid length is pure and a too-large length only throws a maximum-length `RangeError`, which the minifier is allowed to drop (see `docs/ASSUMPTIONS.md`). `new Int8Array(-1)` (negative-length `RangeError`), `new Int8Array(0n)` (BigInt `TypeError`), object, and non-literal arguments are kept. - **`new Set([...])` / `new Map([[..], ..])`** with array-literal arguments; element side effects are preserved when the construction is dropped. `WeakSet`/`WeakMap` are excluded (their keys must be objects, so `new WeakSet([1])` throws), and `Map` entries must be array literals (`new Map([1])` throws). This matches esbuild's per-constructor handling — the only other minifier that keeps every throwing form; Rollup, Terser (`unsafe`), and SWC drop some of these incorrectly. Cross-verified against the ES spec, esbuild, Terser, Rollup, and SWC. Minified-size impact: react.development.js −0.04 kB; size-neutral elsewhere (real code uses dynamic buffer lengths, not numeric literals).
bee3c28 to
53509a8
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 16, 2026
…ent (#23470) ## Summary `new Map("ab")` / `new WeakSet("ab")` / `new WeakMap("ab")` throw at runtime (`"a"` is not a `[k, v]` entry, and is not an object), but the shared collection purity table treated `Set`, `Map`, `WeakSet`, and `WeakMap` identically and marked any string argument pure — so these throwing constructions were dropped when unused, silently removing an observable `TypeError`. Split `Set` (which accepts any iterable of values, so a string argument is pure) from `Map` / `WeakSet` / `WeakMap` (which require `[k, v]` entries / object keys). A degenerate empty-string argument (`new Map("")` — pure, but never written in practice) is conservatively kept rather than special-cased. This aligns with esbuild, which requires array-literal entries for these constructors. Pre-existing bug, surfaced while reviewing the parent PR (#23469).
camc314
approved these changes
Jun 16, 2026
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 16, 2026
…ent (#23470) ## Summary `new Map("ab")` / `new WeakSet("ab")` / `new WeakMap("ab")` throw at runtime (`"a"` is not a `[k, v]` entry, and is not an object), but the shared collection purity table treated `Set`, `Map`, `WeakSet`, and `WeakMap` identically and marked any string argument pure — so these throwing constructions were dropped when unused, silently removing an observable `TypeError`. Split `Set` (which accepts any iterable of values, so a string argument is pure) from `Map` / `WeakSet` / `WeakMap` (which require `[k, v]` entries / object keys). A degenerate empty-string argument (`new Map("")` — pure, but never written in practice) is conservatively kept rather than special-cased. This aligns with esbuild, which requires array-literal entries for these constructors. Pre-existing bug, surfaced while reviewing the parent PR (#23469).
Boshen
added a commit
that referenced
this pull request
Jun 18, 2026
### 💥 BREAKING CHANGES - 7a76cd3 estree: [**BREAKING**] Make whether to include TS fields a runtime option (#23574) (overlookmotel) - e7b6b68 estree: [**BREAKING**] `ESTree` config use methods not consts (#23573) (overlookmotel) ### 🚀 Features - 556cc6d data_structures: Add `CodeBuffer::as_str` method (#23571) (overlookmotel) - 38c4b06 parser: Add friendly error for adjacent JSX elements (#23378) (sapphi-red) - 53509a8 minifier: Treeshake pure typed arrays and Set/Map array literals (#23469) (Dunqing) - 09762d9 minifier: Inline const value for read-only vars (#22593) (Dunqing) ### 🐛 Bug Fixes - 20375f9 react_compiler: Keep imports referenced only by a computed key (#23586) (Boshen) - 31bfd9b minifier: Keep Object introspection calls on a possible Proxy (#23483) (Dunqing) - 837a395 parser: Treat a line comment after ':' as leading, not trailing (#23515) (Dunqing) - e409fe0 minifier: Keep `new Map`/`WeakSet`/`WeakMap` with a string argument (#23470) (Dunqing) - ae02b4e ci/parser: Use `minimal` for vitest reporter (#23457) (camc314) ### ⚡ Performance - cf24329 mangler: Compile slot sort once instead of per CAPACITY (#23577) (Boshen) - 4058a6a parser: Reduce code bloat from verify_modifiers monomorphization (#23576) (Boshen) - 053b0c1 estree: Remove pointless `mem::take` (#23572) (overlookmotel) - dfb52b6 transformer: Pre-size statement vecs in TS enum & namespace lowering (#23516) (Yunfei He) - 970e09a minifier: Compute template-literal inline checks in a single pass (#23467) (Yunfei He) - 3170c0e semantic,mangler,minifier: Fix `Semantic::stats` node count and reuse stats in mangler builds (#23352) (Boshen) - d1fa6e0 minifier: Evaluate ternary branches once in minimize_conditional_expression (#23479) (Yunfei He) - 3fa8051 transformer: Pre-size JSX props vec to attribute count (#23466) (Yunfei He) - 488b382 react_compiler: Borrow binding names in prefilter instead of allocating (#23471) (Yunfei He) - bcb3894 minifier: Incremental scoping refresh, delete LiveUsageCollector (#23197) (Dunqing) ### 📚 Documentation - f68641e data_structures: Improve docs on safety contract (#23575) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Boshen
added a commit
that referenced
this pull request
Jun 22, 2026
# Oxlint ### 💥 BREAKING CHANGES - 36009dd allocator: [**BREAKING**] `GetAllocator::allocator` take `&self` (#23676) (overlookmotel) ### 🚀 Features - ff65285 linter: `no-restricted-globals` add missing upstream options (#23663) (Sysix) - 7b8bd89 linter/typescript: Implement suggestion for `no-unnecessary-type-constraint` rule (#23646) (Mikhail Baev) - 0dc2405 linter: Add schema for `eslint/no-restricted-properties` (#23619) (Sysix) - b638d0e linter: Add schema for `node/callback-return` (#23615) (Sysix) - eb8bedc linter: Add schema for `import/extensions` (#23557) (WaterWhisperer) - 46f3625 linter: Implement node/no-sync rule (#23589) (fujitani sora) - b01739a linter: Add schema for `unicorn/numeric-separators-style` (#23554) (Mikhail Baev) - 68afd2a linter/node: Implement `no-mixed-requires` rule (#23539) (fujitani sora) - 59d8893 linter: `unicorn/numeric-separators-style` support missing options (#23524) (Sysix) - a421215 linter: Add schema for `eslint/prefer-destructuring` (#23410) (WaterWhisperer) - 84438be linter/jsdoc: Added missing options to `require-param-description` (#23416) (kapobajza) - c145b72 linter/jsdoc/require-param-type: Implement fixer (#23513) (camc314) - 51910df linter/jsdoc: Add missing options to `require-param-type` rule (#23418) (kapobajza) - e90925f linter/unicorn: Implement prefer-number-coercion rule (#23497) (Shekhu☺️ ) - dd1c866 linter/vue: Implement no-async-in-computed-properties rule (#23493) (bab) - b02444e linter: Add schema for `react/jsx-no-script-url` (#23475) (WaterWhisperer) - 53509a8 minifier: Treeshake pure typed arrays and Set/Map array literals (#23469) (Dunqing) - a8dce46 linter/unicorn: Implement `max-nested-calls` rule (#23461) (arieleli01212) ### 🐛 Bug Fixes - b1948a1 linter/radix: Avoid panic on `parseInt` with a spread radix argument (#23623) (Jerry Zhao) - f28ccfd linter/prefer-query-selector: Use a compound selector for multiple classes (#23628) (Jerry Zhao) - 13f2970 linter/prefer-numeric-literals: Avoid panic on `parseInt` with a spread radix argument (#23624) (Jerry Zhao) - 57612b3 linter: Report invalid capitalized-comments ignore patterns (#23608) (camc314) - 800ee2a linter/consistent-vitest-vi: Preserve import aliases when rewriting the import (#23568) (Yunfei He) - f78b5e1 linter/consistent-indexed-object-style: Don't leak a stray comma into the value type (#23566) (Yunfei He) - 6b104e8 linter/radix: Detect a trailing comma only after the argument (#23569) (Yunfei He) - 2de20cb linter/unicorn/prefer-at: Correct two-argument `slice().pop()` index (#23565) (Yunfei He) - de778ec linter: `unicorn/numeric-separators-style` preserve dot for floats without decial part (#23553) (Sysix) - 651027c linter/curly: Remove only the block's own braces (#23580) (Yunfei He) - 687e835 linter/array-type: Parenthesize a conditional-type element (#23579) (Yunfei He) - 9c80dff linter/unicorn/no-unnecessary-await: Don't paste operators into invalid syntax (#23556) (Yunfei He) - 46e1463 linter/no-compare-neg-zero: Delete the `-` of a parenthesized `-0` (#23578) (Yunfei He) - d172a97 linter/unicorn/prefer-math-trunk: Skip fixer for LHS with side effects (#23548) (camc314) - 1c3a9bd linter/unicorn/prefer-negative-index: Don't report `Array#with` (#23518) (Yunfei He) - c17db5d linter/unicorn/prefer-spread: Don't report `.slice()` on non-array receivers (#23520) (Yunfei He) - 9cd0c2f linter/unicorn/prefer-date-now: Keep `BigInt` wrapper when fixing `BigInt(new Date())` (#23523) (Yunfei He) - 16bb890 linter/unicorn/prefer-array-flat: Skip non-array `flatMap` receivers (#23527) (Yunfei He) - 3e6f90f linter/unicorn/no-zero-fractions: Insert a space after any preceding keyword (#23529) (Yunfei He) - 79a7d69 linter/eslint/no-useless-assignment: Handle exceptional control-flow paths (#23544) (camc314) - e8e2741 linter/unicorn/prefer-math-min-max: Preserve operand source text in the fix (#23533) (Yunfei He) - f592154 linter/react/display-name: Ignore lowercase jsx helpers (#23510) (camc314) - df7612f linter/jsx-a11y/no-noninteractive-element-to-interactive-role: Allow custom roles config (#23507) (camc314) - 924b931 linter/unicorn/prefer-at: Handle checking all indexes correctly (#23504) (camc314) - ca9686b linter/unicorn/prefer-at: Report zero indexes (#23503) (camc314) - e96a4e3 linter/unicorn/explicit-length-check: Ignore optional chains (#23487) (camc314) - a303c23 linter/jsx-a11y: Align `anchor-is-valid` config with upstream (#23446) (camc314) - f27a6d1 linter: False positives with non `*.setTimeout` call in `no-confusing-set-timeout` (#23444) (camc314) ### ⚡ Performance - 8e0dd65 linter: Emit RuleEnum dispatch match once instead of per timing branch (#23499) (Boshen) - d5c7d99 linter/expect-expect: Avoid recompiling matches on every traversal (#23593) (camc314) - f191520 linter/no-useless-spread: Avoid collecting `Vec` before iterating (#23546) (camc314) - 79340d1 linter: Stream React lifecycle ancestors (#23545) (camc314) - 1923169 linter/eslint/max-classes: Gate rule by rule config threshold (#23509) (camc314) - 3f60de3 linter: Use bucketed dispatch for all files (#23452) (camc314) - 3699971 linter/typescript/no-unnecessary-parameter-property-assignment: Avoid temporary vec allocations (#23492) (camc314) - 4ef0ceb linter/eslint/no-useless-switch-case: Avoid temporary vec allocations (#23489) (camc314) - 2e09dd3 linter: Avoid JSX fragment child collections (#23486) (camc314) - f30a64c linter/oxc/branches-sharing-code: Borrow shared branch suggestion text (#23484) (camc314) - 097a317 linter/eslint/no-control-regex: Retain control regex candidates in place (#23482) (camc314) - b3a093d linter: Reuse rule dispatch buckets (#23450) (camc314) - 9f1a985 oxlint: Start Tokio only for LSP (#23447) (camc314) ### 📚 Documentation - 9e219de linter/plugins: Update usage instruction (#23495) (Tony) - b50bf4d linter: Remove manually written options doc for `eslint/arrow-body-style` (#23490) (Mikhail Baev) # Oxfmt ### 💥 BREAKING CHANGES - 36009dd allocator: [**BREAKING**] `GetAllocator::allocator` take `&self` (#23676) (overlookmotel) ### 🐛 Bug Fixes - f21ed2c formatter_json: Normalize CRLF for suppressed text (#23702) (leaysgur) - 7cd1737 formatter: Normalize CRLF for suppressed text (#23701) (leaysgur) - a36e444 formatter: Member chain panic when tail is merged with comment in dev build (#23698) (leaysgur) - 600d306 formatter: Preserve parens with default export and type cast (#23697) (leaysgur) - 61290f2 formatter: Single-member intersection/union type with comment formatting (#21915) (Leonabcd123) - 5a1b0b4 formatter: Parenthesize a type assertion used as the base of `**` (#23633) (Jerry Zhao) - 91827e2 formatter: Use `Ordering::reverse()` with `order: desc` for idempotency (#23543) (leaysgur) - 8fa7394 formatter_json: Handle wrapped error span (#23472) (leaysgur) - 37a34a1 oxfmt/lsp: Avoid newlines line ending changes (#23463) (Sysix) ### ⚡ Performance - 80f1697 formatter: Avoid arena copy for already-lowercase bigint literals (#23534) (Yunfei He) - 1a40b71 formatter: Avoid arena copy for borrowed numeric-literal text (#23512) (Yunfei He) - 12e4451 formatter: Avoid arena copy for borrowed string-literal text (#23465) (Yunfei He) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
#23469) ## Summary Mark side-effect-free `new` constructions pure so they are dropped when unused (and annotated for downstream tree-shaking): - **TypedArrays** with a non-negative numeric-literal length (`new Int8Array(8)`, `new Uint8Array(1024)`). The buffer allocation runs no user code; a valid length is pure and a too-large length only throws a maximum-length `RangeError`, which the minifier is allowed to drop (see `docs/ASSUMPTIONS.md`). `new Int8Array(-1)` (negative-length `RangeError`), `new Int8Array(0n)` (BigInt `TypeError`), object, and non-literal arguments are kept. - **`new Set([...])` / `new Map([[..], ..])`** with array-literal arguments; element side effects are preserved when the construction is dropped. `WeakSet`/`WeakMap` are excluded (their keys must be objects, so `new WeakSet([1])` throws), and `Map` entries must be array literals (`new Map([1])` throws). This matches esbuild's per-constructor handling — the only other minifier that keeps every throwing form; Rollup, Terser (`unsafe`), and SWC drop some of these incorrectly. Cross-verified against the ES spec, esbuild, Terser, Rollup, and SWC. Minified-size impact: react.development.js −0.04 kB; size-neutral elsewhere (real code uses dynamic buffer lengths, not numeric literals).
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
…ent (#23470) ## Summary `new Map("ab")` / `new WeakSet("ab")` / `new WeakMap("ab")` throw at runtime (`"a"` is not a `[k, v]` entry, and is not an object), but the shared collection purity table treated `Set`, `Map`, `WeakSet`, and `WeakMap` identically and marked any string argument pure — so these throwing constructions were dropped when unused, silently removing an observable `TypeError`. Split `Set` (which accepts any iterable of values, so a string argument is pure) from `Map` / `WeakSet` / `WeakMap` (which require `[k, v]` entries / object keys). A degenerate empty-string argument (`new Map("")` — pure, but never written in practice) is conservatively kept rather than special-cased. This aligns with esbuild, which requires array-literal entries for these constructors. Pre-existing bug, surfaced while reviewing the parent PR (#23469).
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
### 💥 BREAKING CHANGES - 7a76cd3 estree: [**BREAKING**] Make whether to include TS fields a runtime option (#23574) (overlookmotel) - e7b6b68 estree: [**BREAKING**] `ESTree` config use methods not consts (#23573) (overlookmotel) ### 🚀 Features - 556cc6d data_structures: Add `CodeBuffer::as_str` method (#23571) (overlookmotel) - 38c4b06 parser: Add friendly error for adjacent JSX elements (#23378) (sapphi-red) - 53509a8 minifier: Treeshake pure typed arrays and Set/Map array literals (#23469) (Dunqing) - 09762d9 minifier: Inline const value for read-only vars (#22593) (Dunqing) ### 🐛 Bug Fixes - 20375f9 react_compiler: Keep imports referenced only by a computed key (#23586) (Boshen) - 31bfd9b minifier: Keep Object introspection calls on a possible Proxy (#23483) (Dunqing) - 837a395 parser: Treat a line comment after ':' as leading, not trailing (#23515) (Dunqing) - e409fe0 minifier: Keep `new Map`/`WeakSet`/`WeakMap` with a string argument (#23470) (Dunqing) - ae02b4e ci/parser: Use `minimal` for vitest reporter (#23457) (camc314) ### ⚡ Performance - cf24329 mangler: Compile slot sort once instead of per CAPACITY (#23577) (Boshen) - 4058a6a parser: Reduce code bloat from verify_modifiers monomorphization (#23576) (Boshen) - 053b0c1 estree: Remove pointless `mem::take` (#23572) (overlookmotel) - dfb52b6 transformer: Pre-size statement vecs in TS enum & namespace lowering (#23516) (Yunfei He) - 970e09a minifier: Compute template-literal inline checks in a single pass (#23467) (Yunfei He) - 3170c0e semantic,mangler,minifier: Fix `Semantic::stats` node count and reuse stats in mangler builds (#23352) (Boshen) - d1fa6e0 minifier: Evaluate ternary branches once in minimize_conditional_expression (#23479) (Yunfei He) - 3fa8051 transformer: Pre-size JSX props vec to attribute count (#23466) (Yunfei He) - 488b382 react_compiler: Borrow binding names in prefilter instead of allocating (#23471) (Yunfei He) - bcb3894 minifier: Incremental scoping refresh, delete LiveUsageCollector (#23197) (Dunqing) ### 📚 Documentation - f68641e data_structures: Improve docs on safety contract (#23575) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
# Oxlint ### 💥 BREAKING CHANGES - 36009dd allocator: [**BREAKING**] `GetAllocator::allocator` take `&self` (#23676) (overlookmotel) ### 🚀 Features - ff65285 linter: `no-restricted-globals` add missing upstream options (#23663) (Sysix) - 7b8bd89 linter/typescript: Implement suggestion for `no-unnecessary-type-constraint` rule (#23646) (Mikhail Baev) - 0dc2405 linter: Add schema for `eslint/no-restricted-properties` (#23619) (Sysix) - b638d0e linter: Add schema for `node/callback-return` (#23615) (Sysix) - eb8bedc linter: Add schema for `import/extensions` (#23557) (WaterWhisperer) - 46f3625 linter: Implement node/no-sync rule (#23589) (fujitani sora) - b01739a linter: Add schema for `unicorn/numeric-separators-style` (#23554) (Mikhail Baev) - 68afd2a linter/node: Implement `no-mixed-requires` rule (#23539) (fujitani sora) - 59d8893 linter: `unicorn/numeric-separators-style` support missing options (#23524) (Sysix) - a421215 linter: Add schema for `eslint/prefer-destructuring` (#23410) (WaterWhisperer) - 84438be linter/jsdoc: Added missing options to `require-param-description` (#23416) (kapobajza) - c145b72 linter/jsdoc/require-param-type: Implement fixer (#23513) (camc314) - 51910df linter/jsdoc: Add missing options to `require-param-type` rule (#23418) (kapobajza) - e90925f linter/unicorn: Implement prefer-number-coercion rule (#23497) (Shekhu☺️ ) - dd1c866 linter/vue: Implement no-async-in-computed-properties rule (#23493) (bab) - b02444e linter: Add schema for `react/jsx-no-script-url` (#23475) (WaterWhisperer) - 53509a8 minifier: Treeshake pure typed arrays and Set/Map array literals (#23469) (Dunqing) - a8dce46 linter/unicorn: Implement `max-nested-calls` rule (#23461) (arieleli01212) ### 🐛 Bug Fixes - b1948a1 linter/radix: Avoid panic on `parseInt` with a spread radix argument (#23623) (Jerry Zhao) - f28ccfd linter/prefer-query-selector: Use a compound selector for multiple classes (#23628) (Jerry Zhao) - 13f2970 linter/prefer-numeric-literals: Avoid panic on `parseInt` with a spread radix argument (#23624) (Jerry Zhao) - 57612b3 linter: Report invalid capitalized-comments ignore patterns (#23608) (camc314) - 800ee2a linter/consistent-vitest-vi: Preserve import aliases when rewriting the import (#23568) (Yunfei He) - f78b5e1 linter/consistent-indexed-object-style: Don't leak a stray comma into the value type (#23566) (Yunfei He) - 6b104e8 linter/radix: Detect a trailing comma only after the argument (#23569) (Yunfei He) - 2de20cb linter/unicorn/prefer-at: Correct two-argument `slice().pop()` index (#23565) (Yunfei He) - de778ec linter: `unicorn/numeric-separators-style` preserve dot for floats without decial part (#23553) (Sysix) - 651027c linter/curly: Remove only the block's own braces (#23580) (Yunfei He) - 687e835 linter/array-type: Parenthesize a conditional-type element (#23579) (Yunfei He) - 9c80dff linter/unicorn/no-unnecessary-await: Don't paste operators into invalid syntax (#23556) (Yunfei He) - 46e1463 linter/no-compare-neg-zero: Delete the `-` of a parenthesized `-0` (#23578) (Yunfei He) - d172a97 linter/unicorn/prefer-math-trunk: Skip fixer for LHS with side effects (#23548) (camc314) - 1c3a9bd linter/unicorn/prefer-negative-index: Don't report `Array#with` (#23518) (Yunfei He) - c17db5d linter/unicorn/prefer-spread: Don't report `.slice()` on non-array receivers (#23520) (Yunfei He) - 9cd0c2f linter/unicorn/prefer-date-now: Keep `BigInt` wrapper when fixing `BigInt(new Date())` (#23523) (Yunfei He) - 16bb890 linter/unicorn/prefer-array-flat: Skip non-array `flatMap` receivers (#23527) (Yunfei He) - 3e6f90f linter/unicorn/no-zero-fractions: Insert a space after any preceding keyword (#23529) (Yunfei He) - 79a7d69 linter/eslint/no-useless-assignment: Handle exceptional control-flow paths (#23544) (camc314) - e8e2741 linter/unicorn/prefer-math-min-max: Preserve operand source text in the fix (#23533) (Yunfei He) - f592154 linter/react/display-name: Ignore lowercase jsx helpers (#23510) (camc314) - df7612f linter/jsx-a11y/no-noninteractive-element-to-interactive-role: Allow custom roles config (#23507) (camc314) - 924b931 linter/unicorn/prefer-at: Handle checking all indexes correctly (#23504) (camc314) - ca9686b linter/unicorn/prefer-at: Report zero indexes (#23503) (camc314) - e96a4e3 linter/unicorn/explicit-length-check: Ignore optional chains (#23487) (camc314) - a303c23 linter/jsx-a11y: Align `anchor-is-valid` config with upstream (#23446) (camc314) - f27a6d1 linter: False positives with non `*.setTimeout` call in `no-confusing-set-timeout` (#23444) (camc314) ### ⚡ Performance - 8e0dd65 linter: Emit RuleEnum dispatch match once instead of per timing branch (#23499) (Boshen) - d5c7d99 linter/expect-expect: Avoid recompiling matches on every traversal (#23593) (camc314) - f191520 linter/no-useless-spread: Avoid collecting `Vec` before iterating (#23546) (camc314) - 79340d1 linter: Stream React lifecycle ancestors (#23545) (camc314) - 1923169 linter/eslint/max-classes: Gate rule by rule config threshold (#23509) (camc314) - 3f60de3 linter: Use bucketed dispatch for all files (#23452) (camc314) - 3699971 linter/typescript/no-unnecessary-parameter-property-assignment: Avoid temporary vec allocations (#23492) (camc314) - 4ef0ceb linter/eslint/no-useless-switch-case: Avoid temporary vec allocations (#23489) (camc314) - 2e09dd3 linter: Avoid JSX fragment child collections (#23486) (camc314) - f30a64c linter/oxc/branches-sharing-code: Borrow shared branch suggestion text (#23484) (camc314) - 097a317 linter/eslint/no-control-regex: Retain control regex candidates in place (#23482) (camc314) - b3a093d linter: Reuse rule dispatch buckets (#23450) (camc314) - 9f1a985 oxlint: Start Tokio only for LSP (#23447) (camc314) ### 📚 Documentation - 9e219de linter/plugins: Update usage instruction (#23495) (Tony) - b50bf4d linter: Remove manually written options doc for `eslint/arrow-body-style` (#23490) (Mikhail Baev) # Oxfmt ### 💥 BREAKING CHANGES - 36009dd allocator: [**BREAKING**] `GetAllocator::allocator` take `&self` (#23676) (overlookmotel) ### 🐛 Bug Fixes - f21ed2c formatter_json: Normalize CRLF for suppressed text (#23702) (leaysgur) - 7cd1737 formatter: Normalize CRLF for suppressed text (#23701) (leaysgur) - a36e444 formatter: Member chain panic when tail is merged with comment in dev build (#23698) (leaysgur) - 600d306 formatter: Preserve parens with default export and type cast (#23697) (leaysgur) - 61290f2 formatter: Single-member intersection/union type with comment formatting (#21915) (Leonabcd123) - 5a1b0b4 formatter: Parenthesize a type assertion used as the base of `**` (#23633) (Jerry Zhao) - 91827e2 formatter: Use `Ordering::reverse()` with `order: desc` for idempotency (#23543) (leaysgur) - 8fa7394 formatter_json: Handle wrapped error span (#23472) (leaysgur) - 37a34a1 oxfmt/lsp: Avoid newlines line ending changes (#23463) (Sysix) ### ⚡ Performance - 80f1697 formatter: Avoid arena copy for already-lowercase bigint literals (#23534) (Yunfei He) - 1a40b71 formatter: Avoid arena copy for borrowed numeric-literal text (#23512) (Yunfei He) - 12e4451 formatter: Avoid arena copy for borrowed string-literal text (#23465) (Yunfei He) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Mark side-effect-free
newconstructions pure so they are dropped when unused (and annotated for downstream tree-shaking):new Int8Array(8),new Uint8Array(1024)). The buffer allocation runs no user code; a valid length is pure and a too-large length only throws a maximum-lengthRangeError, which the minifier is allowed to drop (seedocs/ASSUMPTIONS.md).new Int8Array(-1)(negative-lengthRangeError),new Int8Array(0n)(BigIntTypeError), object, and non-literal arguments are kept.new Set([...])/new Map([[..], ..])with array-literal arguments; element side effects are preserved when the construction is dropped.WeakSet/WeakMapare excluded (their keys must be objects, sonew WeakSet([1])throws), andMapentries must be array literals (new Map([1])throws).This matches esbuild's per-constructor handling — the only other minifier that keeps every throwing form; Rollup, Terser (
unsafe), and SWC drop some of these incorrectly. Cross-verified against the ES spec, esbuild, Terser, Rollup, and SWC.Minified-size impact: react.development.js −0.04 kB; size-neutral elsewhere (real code uses dynamic buffer lengths, not numeric literals).