Skip to content

test(data_structures): remove duplicate test#23570

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/06-17-test_data_structures_remove_duplicate_test
Jun 17, 2026
Merged

test(data_structures): remove duplicate test#23570
graphite-app[bot] merged 1 commit into
mainfrom
om/06-17-test_data_structures_remove_duplicate_test

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This test does the same as into_string test just below. Remove it.

@overlookmotel Graphite App

overlookmotel commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 17, 2026
Merged
Merged
Merged
Merged
@codspeed-hq

codspeed-hq Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing om/06-17-test_data_structures_remove_duplicate_test (851891b) with main (4a5063c)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (851891b) during the generation of this report, so 4a5063c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel marked this pull request as ready for review June 17, 2026 22:01
Copilot AI review requested due to automatic review settings June 17, 2026 22:01
Copilot AI reviewed Jun 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a redundant unit test in oxc_data_structures’s CodeBuffer tests to reduce duplication while preserving existing behavior verification.

Changes:

  • Deleted string_isomorphism test (overlaps with the nearby into_string test).
Comments suppressed due to low confidence (1)

crates/oxc_data_structures/src/code_buffer.rs:754

  • Removing string_isomorphism drops coverage for From<CodeBuffer> for String on a non-empty buffer (the remaining empty test only covers the empty case). To keep coverage while avoiding duplication, fold that assertion into the existing into_string test by converting a cloned buffer via String::from (or Into<String>).
        let s = "Hello, world!";
        let mut code = CodeBuffer::with_capacity(s.len());
        code.print_str(s);

        let source = code.into_string();

@overlookmotel overlookmotel self-assigned this Jun 17, 2026
@graphite-app

graphite-app Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@overlookmotel
test(data_structures): remove duplicate test (#23570)
851891b 
This test does the same as `into_string` test just below. Remove it.
@graphite-app graphite-app Bot force-pushed the om/06-17-test_data_structures_remove_duplicate_test branch from 9883f77 to 851891b Compare June 17, 2026 22:40
@graphite-app graphite-app Bot merged commit 851891b into main Jun 17, 2026
39 checks passed
@graphite-app graphite-app Bot deleted the om/06-17-test_data_structures_remove_duplicate_test branch June 17, 2026 22:46
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@overlookmotel @camc314
test(data_structures): remove duplicate test (#23570)
36fbdd9 
This test does the same as `into_string` test just below. Remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel