fix(parser): correct the method's FormalParameterKind to UniqueFormalParameters#10162
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 1, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
CodSpeed Instrumentation Performance ReportMerging #10162 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
c88513a to
ffa12ec
Compare
da0e352 to
799fea9
Compare
Member
Merge activity
|
…eFormalParameters` (#10162) https://tc39.es/ecma262/#sec-method-definitions-static-semantics-early-errors 15.4.1 Static Semantics: Early Errors [MethodDefinition](https://tc39.es/ecma262/#prod-MethodDefinition) : [ClassElementName](https://tc39.es/ecma262/#prod-ClassElementName) ( [UniqueFormalParameters](https://tc39.es/ecma262/#prod-UniqueFormalParameters) ) { [FunctionBody](https://tc39.es/ecma262/#prod-FunctionBody) } It is a Syntax Error if [FunctionBodyContainsUseStrict](https://tc39.es/ecma262/#sec-static-semantics-functionbodycontainsusestrict) of [FunctionBody](https://tc39.es/ecma262/#prod-FunctionBody) is true and [IsSimpleParameterList](https://tc39.es/ecma262/#sec-static-semantics-issimpleparameterlist) of [UniqueFormalParameters](https://tc39.es/ecma262/#prod-UniqueFormalParameters) is false. It is a Syntax Error if any element of the [BoundNames](https://tc39.es/ecma262/#sec-static-semantics-boundnames) of [UniqueFormalParameters](https://tc39.es/ecma262/#prod-UniqueFormalParameters) also occurs in the [LexicallyDeclaredNames](https://tc39.es/ecma262/#sec-static-semantics-lexicallydeclarednames) of [FunctionBody](https://tc39.es/ecma262/#prod-FunctionBody). As you can see, the parameters of the method definition should be `UniqueFormalParameters`.
799fea9 to
10cc886
Compare
ffa12ec to
41a985e
Compare
Base automatically changed from
04-01-fix_semantic_reserved_words_cannot_be_used_as_class_binding_in_script_code
to
main
April 1, 2025 13:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tc39.es/ecma262/#sec-method-definitions-static-semantics-early-errors
15.4.1 Static Semantics: Early Errors
MethodDefinition : ClassElementName ( UniqueFormalParameters ) { FunctionBody }
It is a Syntax Error if FunctionBodyContainsUseStrict of FunctionBody is true and IsSimpleParameterList of UniqueFormalParameters is false.
It is a Syntax Error if any element of the BoundNames of UniqueFormalParameters also occurs in the LexicallyDeclaredNames of FunctionBody.
As you can see, the parameters of the method definition should be
UniqueFormalParameters.