Skip to content

fix(semantic): redeclare variable with function declaration inside the function should not throw error#10160

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-01-fix_semantic_redeclare_variable_with_function_declaration_inside_the_function_should_not_throw_error
Apr 1, 2025
Merged

fix(semantic): redeclare variable with function declaration inside the function should not throw error#10160
graphite-app[bot] merged 1 commit intomainfrom
04-01-fix_semantic_redeclare_variable_with_function_declaration_inside_the_function_should_not_throw_error

Conversation

@Dunqing
Copy link
Copy Markdown
Member

@Dunqing Dunqing commented Apr 1, 2025 •
edited
Loading

close: #10159

@Dunqing Dunqing requested a review from Boshen as a code owner April 1, 2025 08:15
@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Apr 1, 2025
@Dunqing Graphite App
Copy link
Copy Markdown
Member Author

Dunqing commented Apr 1, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Apr 1, 2025
Merged
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 1, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10160 will not alter performance

Comparing 04-01-fix_semantic_redeclare_variable_with_function_declaration_inside_the_function_should_not_throw_error (bc54d1f) with main (de45c5e)

Summary

✅ 36 untouched benchmarks

@Dunqing Dunqing force-pushed the 04-01-fix_semantic_redeclare_variable_with_function_declaration_inside_the_function_should_not_throw_error branch from 4c53519 to 69ab098 Compare April 1, 2025 09:01
@Dunqing Dunqing mentioned this pull request Apr 1, 2025
Merged
@Dunqing Dunqing force-pushed the 04-01-fix_semantic_redeclare_variable_with_function_declaration_inside_the_function_should_not_throw_error branch from 69ab098 to 7e5f9cc Compare April 1, 2025 09:32
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 1, 2025
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Apr 1, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 04-01-fix_semantic_redeclare_variable_with_function_declaration_inside_the_function_should_not_throw_error branch from 7e5f9cc to bc54d1f Compare April 1, 2025 13:05
@graphite-app graphite-app bot merged commit bc54d1f into main Apr 1, 2025
28 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 1, 2025
@graphite-app graphite-app bot deleted the 04-01-fix_semantic_redeclare_variable_with_function_declaration_inside_the_function_should_not_throw_error branch April 1, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees

No one assigned

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parser: redeclare variable with function declaration inside the function should not throw error

1 participant

@Dunqing