Skip to content

fix(semantic): reserved words cannot be used as class binding in script code#10161

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-01-fix_semantic_reserved_words_cannot_be_used_as_class_binding_in_script_code
Apr 1, 2025
Merged

fix(semantic): reserved words cannot be used as class binding in script code#10161
graphite-app[bot] merged 1 commit intomainfrom
04-01-fix_semantic_reserved_words_cannot_be_used_as_class_binding_in_script_code

Conversation

@Dunqing
Copy link
Copy Markdown
Member

@Dunqing Dunqing commented Apr 1, 2025 •
edited
Loading

close: #10053

@Dunqing Dunqing requested a review from Boshen as a code owner April 1, 2025 08:15
@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Apr 1, 2025
@Dunqing Graphite App
Copy link
Copy Markdown
Member Author

Dunqing commented Apr 1, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Apr 1, 2025
Merged
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 1, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10161 will create unknown performance changes

Comparing 04-01-fix_semantic_reserved_words_cannot_be_used_as_class_binding_in_script_code (10cc886) with main (bc54d1f)

Summary

🆕 25 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.6 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.6 ms N/A
🆕 formatter[antd.js] N/A 7.6 ms N/A
🆕 formatter[react.development.js] N/A 42.3 µs N/A
🆕 formatter[typescript.js] N/A 7.4 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.1 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 estree[checker.ts] N/A 96.9 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 92.4 µs N/A
🆕 parser[antd.js] N/A 113.2 ms N/A
🆕 parser[cal.com.tsx] N/A 30.1 ms N/A
🆕 parser[checker.ts] N/A 56.7 ms N/A
🆕 parser[pdf.mjs] N/A 18.3 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Dunqing Dunqing force-pushed the 04-01-fix_semantic_reserved_words_cannot_be_used_as_class_binding_in_script_code branch from 5503e4e to da0e352 Compare April 1, 2025 09:01
@Dunqing Dunqing force-pushed the 04-01-fix_semantic_redeclare_variable_with_function_declaration_inside_the_function_should_not_throw_error branch from 4c53519 to 69ab098 Compare April 1, 2025 09:01
@Dunqing Dunqing mentioned this pull request Apr 1, 2025
Merged
@Dunqing Dunqing force-pushed the 04-01-fix_semantic_reserved_words_cannot_be_used_as_class_binding_in_script_code branch from da0e352 to 799fea9 Compare April 1, 2025 09:32
@Dunqing Dunqing force-pushed the 04-01-fix_semantic_redeclare_variable_with_function_declaration_inside_the_function_should_not_throw_error branch from 69ab098 to 7e5f9cc Compare April 1, 2025 09:32
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 1, 2025
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Apr 1, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 04-01-fix_semantic_redeclare_variable_with_function_declaration_inside_the_function_should_not_throw_error branch from 7e5f9cc to bc54d1f Compare April 1, 2025 13:05
@graphite-app graphite-app bot force-pushed the 04-01-fix_semantic_reserved_words_cannot_be_used_as_class_binding_in_script_code branch from 799fea9 to 10cc886 Compare April 1, 2025 13:06
Base automatically changed from 04-01-fix_semantic_redeclare_variable_with_function_declaration_inside_the_function_should_not_throw_error to main April 1, 2025 13:11
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 1, 2025
@graphite-app graphite-app bot merged commit 10cc886 into main Apr 1, 2025
22 of 27 checks passed
@graphite-app graphite-app bot deleted the 04-01-fix_semantic_reserved_words_cannot_be_used_as_class_binding_in_script_code branch April 1, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees

No one assigned

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parser: class name is a reserved keyword in non-strict mode should throw a SyntaxError

1 participant

@Dunqing