Conversation
2150127 to
663c7f2
Compare
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
663c7f2 to
2374c75
Compare
ruffsl
left a comment
There was a problem hiding this comment.
Looks like the devel can be pruned a bit, and just some formatting nitpicks.
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
|
Note: for this to work, we will need to push to the osrf dockerhub the |
I think it may be worthwhile to include |
Sounds good to me 👍
@nuclearsandwich is this something that you'd be ok with? (assuming you're the person to ask :) ) |
|
@nuclearsandwich very gentle ping, just to make sure the previous notification didnt get lost :) |
Yep I just need someone to send me the webhook url to hit. The current trigger only fires when the nightly packaging job comes back okay. Is there any guard criteria for the devel image or is that just an unconditional curl every 24h? As of now this cron job is just running on my workstation since we don't have an auxiliary server running anywhere. |
Cool, I'm going to merge and test the docker hub build of |
Creates a
ros2:develimage as discussed in osrf/docker_templates#49Depends on osrf/docker_templates#54, osrf/docker_templates#51 and osrf/docker_templates#52