Skip to content

Ros2 devel#246

Merged
ruffsl merged 7 commits intomasterfrom
ros2_devel
Mar 29, 2019
Merged

Ros2 devel#246
ruffsl merged 7 commits intomasterfrom
ros2_devel

Conversation

@mikaelarguedas
Copy link
Copy Markdown
Contributor

Creates a ros2:devel image as discussed in osrf/docker_templates#49

Depends on osrf/docker_templates#54, osrf/docker_templates#51 and osrf/docker_templates#52

@mikaelarguedas mikaelarguedas requested a review from ruffsl March 22, 2019 00:07
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Copy link
Copy Markdown
Member

@ruffsl ruffsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the devel can be pruned a bit, and just some formatting nitpicks.

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas
Copy link
Copy Markdown
Contributor Author

Note: for this to work, we will need to push to the osrf dockerhub the ros2:devel image.
nightly seems to be built by a cron job and source is never pushed to dockerhub.
I dont think devel would change often, is there a preferred strategy for pushing devel to dockerhub ?

@ruffsl
Copy link
Copy Markdown
Member

ruffsl commented Mar 25, 2019

I dont think devel would change often, is there a preferred strategy for pushing devel to dockerhub ?

I think it may be worthwhile to include devel into the cron job OSRF has that calls our Docker Hub webhook, currently only triggering the nightly tag. Having the devel rebuilt every day to keep fresh may be helpful to catch upstream package changes in ubuntu, etc. I think we could leave out source tag from osrf/ros2 repo given it make more sense for users to build locally, and may be more likely to fail in building.

@mikaelarguedas
Copy link
Copy Markdown
Contributor Author

Having the devel rebuilt every day to keep fresh may be helpful to catch upstream package changes in ubuntu, etc. I think we could leave out source tag from osrf/ros2 repo given it make more sense for users to build locally, and may be more likely to fail in building.

Sounds good to me 👍

worthwhile to include devel into the cron job OSRF has that calls our Docker Hub webhook

@nuclearsandwich is this something that you'd be ok with? (assuming you're the person to ask :) )

@mikaelarguedas
Copy link
Copy Markdown
Contributor Author

@nuclearsandwich very gentle ping, just to make sure the previous notification didnt get lost :)
Feel free to ping me offline if there are details you'd like to iron out

@nuclearsandwich
Copy link
Copy Markdown

nuclearsandwich commented Mar 29, 2019

@nuclearsandwich is this something that you'd be ok with? (assuming you're the person to ask :) )

Yep I just need someone to send me the webhook url to hit.

The current trigger only fires when the nightly packaging job comes back okay. Is there any guard criteria for the devel image or is that just an unconditional curl every 24h?

As of now this cron job is just running on my workstation since we don't have an auxiliary server running anywhere.

@ruffsl
Copy link
Copy Markdown
Member

ruffsl commented Mar 29, 2019

Yep. As of now this cron job is just running on my workstation.

Cool, I'm going to merge and test the docker hub build of devel via the admin console.

@ruffsl ruffsl merged commit 83a035d into master Mar 29, 2019
@mikaelarguedas mikaelarguedas deleted the ros2_devel branch March 29, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants