Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
| && rosdep update | ||
| @[end if]@ | ||
| @[if 'vcs' in locals()]@ | ||
| @[ if vcs]@ |
There was a problem hiding this comment.
arguably we could also move this conditional lower if we consider that the creation of the workspace directory should be done regardless.
This PR justs restore the scope to what it was prior to https://github.com/osrf/docker_templates/pull/44/files
There was a problem hiding this comment.
If that where the case, then perhaps a devel and source image for ros2 could share more of the same template?
There was a problem hiding this comment.
It could, I guess it depends what we would call a "devel" image (discussed here).
Do you mean to always create a workspace (empty in the case of the devel image), and consumers will clone their own code in it ?
There was a problem hiding this comment.
Do you mean to always create a workspace (empty in the case of the devel image), and consumers will clone their own code in it ?
I like that. #49 (comment)
There was a problem hiding this comment.
Sounds good, I restricted the scope more in cea3e56. I'll make the other changes necessary for the ros2:devel image in a separate PR
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
As the initialization of rosdep should not be impacted by skip in the absence of
vcsin the template parametersThe generated ros2 source Dockerfile will be identical as we specify both rosdep and vcs for that image