use template for ROS bootstrap tools installation#52
Merged
mikaelarguedas merged 3 commits intomasterfrom Mar 22, 2019
Merged
Conversation
This was referenced Mar 20, 2019
Contributor
Author
|
Note: this means that |
Member
|
We should remember to apply this to #49 as well when the nightly template is ready. |
This was referenced Mar 21, 2019
Merged
Merged
ruffsl
reviewed
Mar 22, 2019
docker_templates/templates/docker_images/create_ros_core_image.Dockerfile.em
Outdated
Show resolved
Hide resolved
732a269 to
5422644
Compare
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
…umber Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
5422644 to
9bedd77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allow install only the bootstrap tools relevant for the distro (e.g. not installing rosinstall and vcstools in ROS 1).
Adding rosdep and colcon here also allows to not have to specify it in the config of each image using it (e.g. https://github.com/osrf/docker_images/blob/086440f267921cf4ff39e90bb8e07c81e243dddc/ros2/source/images.yaml.em#L20)