Skip to content

manifest,osbuild: support bootc install to-filesystem --target-imgref#605

Merged
ondrejbudai merged 2 commits intoosbuild:mainfrom
mvo5:add-target-imgref
Apr 17, 2024
Merged

manifest,osbuild: support bootc install to-filesystem --target-imgref#605
ondrejbudai merged 2 commits intoosbuild:mainfrom
mvo5:add-target-imgref

Conversation

@mvo5
Copy link
Contributor

@mvo5 mvo5 commented Apr 16, 2024 •
edited
Loading

We currently do not set the --target-imgref when using bootc install to-filesystem. This commit fixes this.

(this may be too naive?)

[edit: manual test shows that it seems to work:

metadata:
  name: host
spec:
  image:
    image: quay.io/centos-bootc/centos-bootc-dev:stream9
    transport: registry
  bootOrder: default
status:
  staged: null
  booted:
    image:
      image:
        image: quay.io/centos-bootc/centos-bootc-dev:stream9
        transport: registry
      version: stream9.20240411.0
      timestamp: null
      imageDigest: sha256:1b19a29cb3c93d68f2f8581af94bafc0e58ad57bc941fc2915006823866d7fbc
    cachedUpdate: null
    incompatible: false
    pinned: false
    ostree:
      checksum: 30ade360312603e3a18d4d43fdbeeaddbc37851b130a8d9c29129da7302fdced
      deploySerial: 0
  rollback: null
  rollbackQueued: false

The test in bib is added in osbuild/bootc-image-builder#357

mvo5 added 2 commits April 17, 2024 13:23
@mvo5
osbuild: add support for the TargetImgref option
e5d426f 
This is the coresponding option for
osbuild/osbuild#1740
@mvo5
manifest,osbuild: support bootc install to-filesystem --target-imgref
268af81 
We currently do not set the `--target-imgref` when using bootc
install to-filesystem. This commit fixes this.
@mvo5 mvo5 force-pushed the add-target-imgref branch from 864cc57 to 268af81 Compare April 17, 2024 11:25
@mvo5 mvo5 marked this pull request as ready for review April 17, 2024 11:25
@mvo5 mvo5 requested a review from ondrejbudai April 17, 2024 11:25
@mvo5 mvo5 mentioned this pull request Apr 17, 2024
Merged
ondrejbudai
ondrejbudai approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@ondrejbudai ondrejbudai added this pull request to the merge queue Apr 17, 2024
Merged via the queue into osbuild:main with commit 729129e Apr 17, 2024
@mvo5 mvo5 deleted the add-target-imgref branch April 17, 2024 15:38
mvo5 added a commit to mvo5/bootc-image-builder that referenced this pull request Apr 17, 2024
@mvo5
go.mod: move to latest ref of images to pickup --target-imgref fixes
85eb737 
This includes osbuild/images#605 which
will ensure that bib sets the right `--target-imgref` on boot.
github-merge-queue bot pushed a commit to osbuild/bootc-image-builder that referenced this pull request Apr 17, 2024
@mvo5
go.mod: move to latest ref of images to pickup --target-imgref fixes
05b63e0 
This includes osbuild/images#605 which
will ensure that bib sets the right `--target-imgref` on boot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejbudai ondrejbudai ondrejbudai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mvo5 @ondrejbudai