Skip to content

test: check that bootc status contains the right container_ref#357

Closed
mvo5 wants to merge 2 commits intoosbuild:mainfrom
mvo5:test-target-imgref
Closed

test: check that bootc status contains the right container_ref#357
mvo5 wants to merge 2 commits intoosbuild:mainfrom
mvo5:test-target-imgref

Conversation

@mvo5
Copy link
Contributor

@mvo5 mvo5 commented Apr 16, 2024

We are currently not testing that when the build image has a valid bootc status that container the original container reference.

This will be important to ensure we do not regress when switching to bootc install to-filesystem where we had a bug that did not set this correctly.

With ssh a root login is only possible via a sshkey. So let's
support this so that we can run `bootc status` which requires
root privs.
With the switch to bootc we need to adjust the testing. We inject
a root ssh key now and just use that for login.
@mvo5 mvo5 force-pushed the test-target-imgref branch 2 times, most recently from 36fa2af to 2c1234c Compare April 17, 2024 13:57
ondrejbudai
ondrejbudai previously approved these changes Apr 17, 2024
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ondrejbudai ondrejbudai enabled auto-merge April 17, 2024 14:05
We are currently not testing that when the build image has a valid
`bootc status` that container the original container reference.
@mvo5
Copy link
Contributor Author

mvo5 commented Apr 17, 2024

I close this one for now but will reopen the ssh root parts most likely to figure out what is going on there, I suspect that there is a real bug/mismatch in how we setup the root user config.

@mvo5 mvo5 closed this Apr 17, 2024
auto-merge was automatically disabled April 17, 2024 14:56

Pull request was closed

@mvo5 mvo5 mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants