stages: add support for --target-imgref to bootc install to-filesystem#1740
Merged
mvo5 merged 1 commit intoosbuild:mainfrom Apr 17, 2024
Merged
stages: add support for --target-imgref to bootc install to-filesystem#1740mvo5 merged 1 commit intoosbuild:mainfrom
--target-imgref to bootc install to-filesystem#1740mvo5 merged 1 commit intoosbuild:mainfrom
Conversation
We currently do not set the `--target-imgref` and do not allow to override it. This means that on a fresh deploy it is set to an incorrect value. This commit allows to set it via the org.osbuild.bootc.install-to-filesystem stage.
d2936bb to
22ee658
Compare
Member
Missed this one... I think that's a sane idea, go for it! :) |
Contributor
Author
It is, it's stricter with the inputs but AFAICT bootc is happy with just the image ref as is done here but I'm still not trusting my ostree knowledge to be fully confident. |
Member
|
It doesn't look like bootc has the same requirements for the ref so let's not restrict it more than is necessary. |
achilleas-k
approved these changes
Apr 17, 2024
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Apr 17, 2024
This is the coresponding option for osbuild/osbuild#1740
github-merge-queue bot
pushed a commit
to osbuild/images
that referenced
this pull request
Apr 17, 2024
This is the coresponding option for osbuild/osbuild#1740
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently do not set the
--target-imgrefand do not allow to override it. This means that on a fresh deploy it is set to an incorrect value. This commit allows to set it via the org.osbuild.bootc.install-to-filesystem stage.We may need to make this as strict as in https://github.com/osbuild/osbuild/blob/main/stages/org.osbuild.ostree.deploy.container.meta.json#L37 ?