Standardize syntax of sizeof(foo) #4876
Conversation
apps/vms_term_sock.c
Outdated
There was a problem hiding this comment.
While you're at it, why not remove space prior &sin?
There was a problem hiding this comment.
There's more space cleanup to do in that particular file. Might almost be worth a PR of its own...
There was a problem hiding this comment.
Right, that's what I already suggested in #4875 :-)
apps/vms_term_sock.c
Outdated
crypto/ec/ec_mult.c
Outdated
There was a problem hiding this comment.
I fixed this the same way I did in master (put it on previous line) and pushed and updated commit. I tend to do "feature-creep" PR's and @levitte tends to call me out on them, so this is just fixing sizeof syntax.
There was a problem hiding this comment.
You killing me, man. You know I don't have no magic coin, so with no separate fixup commit I have to start over...
There was a problem hiding this comment.
I'll try to do better in the future.
There was a problem hiding this comment.
I actually didn't catch that in master, sorry.
I agree that the indentation should be corrected... and maybe you and I should talk, 'cause it seems we have different ideas of what constitutes "feature creep"
There was a problem hiding this comment.
I think I generally agree with levitte about feature creep, with the justification that for this sort of sweeping change, it may actually be easier to review by having an independent implementation of the change and comparing the implementations -- the human eye tires too easily looking at a long stream of "the same" change.
There was a problem hiding this comment.
The indentation in master is fixed, the same way fixed here, by putting the entire comment on the line above.
There was a problem hiding this comment.
As for the "feature creep" comment, I was trying more for lighthearted self-deprecation.
There was a problem hiding this comment.
Ah, ok... sorry, tired day today, didn't catch the lightheartedness (obviously)
test/exptest.c
Outdated
| RAND_seed(rnd_seed, sizeof rnd_seed); /* or BN_rand may fail, and we | ||
| RAND_seed(rnd_seed, sizeof(rnd_seed)); /* or BN_rand may fail, and we | ||
| * don't even check its return | ||
| * value (which we should) */ |
|
additional commit pushed, to be squashed, that fixes the comment that i missed. |
dot-asm
left a comment
There was a problem hiding this comment.
There is no reason to believe that CI would fail, hence approved.
Reviewed-by: Andy Polyakov <appro@openssl.org> (Merged from #4876)
|
Thanks! |
This is #4872 for 1.1.0