Consistent formatting for sizeof(foo) #4872
Conversation
levitte
left a comment
There was a problem hiding this comment.
I've said it before, please avoid "sliding in" spurious changes of this sort.
test/ssltest_old.c
Outdated
There was a problem hiding this comment.
That cast should not be part of this PR. They are also a subject of discussion, and should not be added spuriously.
test/ssltest_old.c
Outdated
test/ssltest_old.c
Outdated
test/ssltest_old.c
Outdated
|
Actually, in all four of those cases the cast is safe and correct because it is the size of an on-stack 8K buffer. But I removed them because it's not relevant to the main point of this PR. Thanks for the nudge. updating commit pushed. |
levitte
left a comment
There was a problem hiding this comment.
I think this should be backported, at least to 1.1.0. Otherwise, we risk paying hell (i.e. merge conflicts) later on with other changes in the same general areas.
Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #4872)
|
This is apparently committed already, so it should be closed... Right? |
Spurred by the recent bug that had the "-1" inside the sizeof argument, this PR fixes all uses of sizeof to be conformant with our style guide. Not going to cherry-pick back; I could do separate PR's for the other branches if someone feels strongly about wanting it.