Standardize syntax around sizeof(foo) #4875
Conversation
apps/vms_term_sock.c
Outdated
There was a problem hiding this comment.
Same comment as in #4876, but three occurrences here...
There was a problem hiding this comment.
If cross-compared to master, it might be more appropriate to dismiss this comment, even in #4876. I mean it's probably more appropriate to address it separately [if at all].
crypto/ec/ec_mult.c
Outdated
test/igetest.c
Outdated
There was a problem hiding this comment.
This aint right. It's sizeof(v->key), not sizeof(v)->key.
test/igetest.c
Outdated
|
I don't want to fix anything other than the sizeof uses here. |
|
Also fixed the "jagged comment" in crypto/ec/ec_mult.c |
crypto/bn/exptest.c
Outdated
| RAND_seed(rnd_seed, sizeof rnd_seed); /* or BN_rand may fail, and we | ||
| RAND_seed(rnd_seed, sizeof(rnd_seed)); /* or BN_rand may fail, and we | ||
| * don't even check its return | ||
| * value (which we should) */ |
|
|
||
| if (setsockopt | ||
| (nSocket, SOL_SOCKET, SO_REUSEADDR, (char *)&one, sizeof one) < 0) { | ||
| (nSocket, SOL_SOCKET, SO_REUSEADDR, (char *)&one, sizeof(one)) < 0) { |
There was a problem hiding this comment.
That's an incompliant formatting! Side note!
Reformat comment.
|
Added commit to fix the exptest comment-wrapping issue. |
Reviewed-by: Andy Polyakov <appro@openssl.org> (Merged from #4875)
|
Thanks for the feedback; merged to 1.0.2 |
This is the #4872 done for 1.0.2