OCPCLOUD-2220: Merge https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud:v0.6.0 (02aa85f) into main by damdo · Pull Request #59 · openshift/cluster-api-provider-ibmcloud

damdo · 2023-10-04T15:01:34Z

No description provided.

Bumps [github.com/IBM/go-sdk-core/v5](https://github.com/IBM/go-sdk-core) from 5.13.1 to 5.13.2. - [Release notes](https://github.com/IBM/go-sdk-core/releases) - [Changelog](https://github.com/IBM/go-sdk-core/blob/main/CHANGELOG.md) - [Commits](IBM/go-sdk-core@v5.13.1...v5.13.2) --- updated-dependencies: - dependency-name: github.com/IBM/go-sdk-core/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…1213) Bumps [github.com/IBM/platform-services-go-sdk](https://github.com/IBM/platform-services-go-sdk) from 0.37.3 to 0.37.4. - [Release notes](https://github.com/IBM/platform-services-go-sdk/releases) - [Changelog](https://github.com/IBM/platform-services-go-sdk/blob/main/CHANGELOG.md) - [Commits](IBM/platform-services-go-sdk@v0.37.3...v0.37.4) --- updated-dependencies: - dependency-name: github.com/IBM/platform-services-go-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

Bumps golang from 1.20.3 to 1.20.4. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…39d (#1219) Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

Bumps [github.com/IBM/vpc-go-sdk](https://github.com/IBM/vpc-go-sdk) from 0.36.0 to 0.37.0. - [Release notes](https://github.com/IBM/vpc-go-sdk/releases) - [Changelog](https://github.com/IBM/vpc-go-sdk/blob/master/CHANGELOG.md) - [Commits](IBM/vpc-go-sdk@v0.36.0...v0.37.0) --- updated-dependencies: - dependency-name: github.com/IBM/vpc-go-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.8.0 to 0.9.0. - [Commits](golang/crypto@v0.8.0...v0.9.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

Bumps [github.com/IBM/go-sdk-core/v5](https://github.com/IBM/go-sdk-core) from 5.13.2 to 5.13.3. - [Release notes](https://github.com/IBM/go-sdk-core/releases) - [Changelog](https://github.com/IBM/go-sdk-core/blob/main/CHANGELOG.md) - [Commits](IBM/go-sdk-core@v5.13.2...v5.13.3) --- updated-dependencies: - dependency-name: github.com/IBM/go-sdk-core/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.3. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.2...v1.8.3) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/IBM/go-sdk-core/v5](https://github.com/IBM/go-sdk-core) from 5.13.3 to 5.13.4. - [Release notes](https://github.com/IBM/go-sdk-core/releases) - [Changelog](https://github.com/IBM/go-sdk-core/blob/main/CHANGELOG.md) - [Commits](IBM/go-sdk-core@v5.13.3...v5.13.4) --- updated-dependencies: - dependency-name: github.com/IBM/go-sdk-core/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…1242) Bumps [github.com/IBM/platform-services-go-sdk](https://github.com/IBM/platform-services-go-sdk) from 0.37.4 to 0.38.1. - [Release notes](https://github.com/IBM/platform-services-go-sdk/releases) - [Changelog](https://github.com/IBM/platform-services-go-sdk/blob/main/CHANGELOG.md) - [Commits](IBM/platform-services-go-sdk@v0.37.4...v0.38.1) --- updated-dependencies: - dependency-name: github.com/IBM/platform-services-go-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.3 to 1.8.4. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.3...v1.8.4) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/IBM/vpc-go-sdk](https://github.com/IBM/vpc-go-sdk) from 0.37.0 to 0.38.0. - [Release notes](https://github.com/IBM/vpc-go-sdk/releases) - [Changelog](https://github.com/IBM/vpc-go-sdk/blob/master/CHANGELOG.md) - [Commits](IBM/vpc-go-sdk@v0.37.0...v0.38.0) --- updated-dependencies: - dependency-name: github.com/IBM/vpc-go-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…1246) Bumps [github.com/IBM/platform-services-go-sdk](https://github.com/IBM/platform-services-go-sdk) from 0.38.1 to 0.39.0. - [Release notes](https://github.com/IBM/platform-services-go-sdk/releases) - [Changelog](https://github.com/IBM/platform-services-go-sdk/blob/main/CHANGELOG.md) - [Commits](IBM/platform-services-go-sdk@v0.38.1...v0.39.0) --- updated-dependencies: - dependency-name: github.com/IBM/platform-services-go-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…(#1250) Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

…1253) Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.12.9 to 0.12.13. - [Release notes](https://github.com/itchyny/gojq/releases) - [Changelog](https://github.com/itchyny/gojq/blob/main/CHANGELOG.md) - [Commits](itchyny/gojq@v0.12.9...v0.12.13) --- updated-dependencies: - dependency-name: github.com/itchyny/gojq dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

openshift-ci-robot · 2023-10-04T15:03:35Z

@damdo: This pull request references OCPCLOUD-2220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

damdo · 2023-10-04T18:32:18Z

/retest

damdo · 2023-10-05T06:17:43Z

/retest

Karthik-K-N · 2023-10-05T08:59:51Z

/retest

Karthik-K-N · 2023-10-05T09:01:56Z

@damdo, Currently we support only Power VS and the test e2e-ibmcloud-techpreview is not related to Power VS platform and its for ibmcloud platform. Can we consider removing this test .

damdo · 2023-10-05T10:08:58Z

Yes I also realised this is IBMCloud and not Power VS.
We can ignore the failing test result as that doesn't apply.
I can see if I can remove this test from the presubmits for this repo.

openshift-ci · 2023-10-05T10:13:55Z

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

damdo · 2023-10-05T10:39:18Z

@Karthik-K-N here is the PR to remove the job:
cluster-api-provider-ibmcloud: remove e2e techpreview job openshift/release#44007

Karthik-K-N · 2023-10-05T10:41:12Z

@Karthik-K-N here is the PR to remove the job: cluster-api-provider-ibmcloud: remove e2e techpreview job openshift/release#44007

Thank you.

damdo · 2023-10-09T10:33:43Z

/hold
For manual testing

openshift-ci-robot · 2023-10-09T10:34:05Z

@damdo: This pull request references OCPCLOUD-2220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Karthik-K-N · 2023-10-09T13:28:30Z

/hold For manual testing

Will test and update.

Karthik-K-N · 2023-10-12T05:30:24Z

Verified the update and it works perfectly fine.

% oc get infrastructureprovider -A
NAMESPACE               NAME       INSTALLEDVERSION   READY
openshift-cluster-api   ibmcloud   v0.6.0             True

%  oc get coreprovider -A
NAMESPACE               NAME          INSTALLEDVERSION   READY
openshift-cluster-api   cluster-api   v1.5.2             True

 % oc get nodes
NAME                              STATUS   ROLES                  AGE   VERSION
powervs-machine-template-wktm7    Ready    worker                 81s   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-master-0       Ready    control-plane,master   14h   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-master-1       Ready    control-plane,master   14h   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-master-2       Ready    control-plane,master   14h   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-worker-mx78x   Ready    worker                 12h   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-worker-wdrmw   Ready    worker                 13h   v1.27.3+4aaeaec
rdr-kn111008-qg2hq-worker-zhhj2   Ready    worker                 13h   v1.27.3+4aaeaec

/Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:62
  [SKIPPED] in [BeforeAll] - /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:43 @ 10/12/23 10:56:56.617
  [SKIPPED] in [AfterEach] - /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:55 @ 10/12/23 10:56:56.618
S [SKIPPED] [0.001 seconds]
Cluster API AWS MachineSet [BeforeAll] should be able to run a machine with a default provider spec
  [BeforeAll] /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:41
  [It] /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:62

  [SKIPPED] Skipping AWS E2E tests
  In [BeforeAll] at: /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:43 @ 10/12/23 10:56:56.617

  Full Stack Trace
    github.com/openshift/cluster-capi-operator/e2e.glob..func1.1()
        /Users/karthikkn/capi-update/cluster-capi-operator/e2e/aws_test.go:43 +0x10c
------------------------------

Ran 1 of 3 Specs in 1004.833 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 2 Skipped
PASS

Ginkgo ran 1 suite in 17m7.734669418s
Test Suite Passed

Karthik-K-N · 2023-10-12T05:32:52Z

May be lets wait till hypershift PR to remove the deprecated flag merges, IPI change ref: openshift/cluster-capi-operator#128.

@dharaneeshvrd Please let us know once we are good.

/hold

dharaneeshvrd · 2023-10-12T05:37:55Z

@Karthik-K-N
Hypershift PR is merged here openshift/hypershift#3028
You can unhold the PR.

Karthik-K-N · 2023-10-12T05:42:56Z

@Karthik-K-N Hypershift PR is merged here openshift/hypershift#3028 You can unhold the PR.

Thanks for the update. @damdo we are good to merge this.

JoelSpeed · 2023-10-12T11:24:15Z

/lgtm
/approve

openshift-ci · 2023-10-12T11:25:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

damdo · 2023-10-16T09:46:44Z

/unhold

damdo · 2023-10-16T09:47:39Z

/tide refresh

Amulyam24 and others added 30 commits May 5, 2023 03:37

Update release version 0.5 (#1211)

1f507b2

Fix docker buildx usage (#1210)

89543ac

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

Bump gcb-docker-gcloud from v20221214-1b4dd4d69a to v20230424-910a2a4…

ce9f482

…39d (#1219) Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

Add init-buildx script for better log description (#1222)

c8f7c1a

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

Added image import cmd (#1216)

0bbe9ec

Dump docker related data for buildx debug (#1228)

163ff46

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

Fix docker buildx cloudbuild failure (#1229)

fc8fa51

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

Fix gcloud auth required for image push (#1230)

43540a5

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

Update enhancement (#1232)

f3c8615

Bump gcb image and improve buildx flow (#1231)

e1560d4

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

update machineType in cloudbuild (#1233)

d50bb4f

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

Update metadata version to v0.6.0 (#1239)

6b35dda

Switch to capibmdam in e2e test (#1240)

65bb7da

Modify capibmadm to not use GetAPIKeyDetails to fetch the account ID …

4279f6b

…(#1250) Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>

Support custom port for powervs cluster apiserver (#1251)

2a765be

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>

Build and use capibmadm from main for E2E (#1256)

8816aba

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 4, 2023

openshift-ci Bot requested review from Karthik-K-N and mkumatag October 4, 2023 15:05

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2023

damdo mentioned this pull request Oct 11, 2023

OCPCLOUD-2214,OCPBUGS-17287,OCPBUGS-21642: Bump capi/capi providers/k8s 1.27 openshift/cluster-capi-operator#132

Merged

6 tasks

openshift-ci Bot assigned JoelSpeed Oct 12, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023

openshift-ci Bot merged commit 52f54e9 into openshift:main Oct 16, 2023

Conversation

damdo commented Oct 4, 2023

Uh oh!

openshift-ci-robot commented Oct 4, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

damdo commented Oct 4, 2023

Uh oh!

damdo commented Oct 5, 2023

Uh oh!

Karthik-K-N commented Oct 5, 2023

Uh oh!

Karthik-K-N commented Oct 5, 2023

Uh oh!

damdo commented Oct 5, 2023

Uh oh!

openshift-ci Bot commented Oct 5, 2023

Uh oh!

damdo commented Oct 5, 2023

Uh oh!

Karthik-K-N commented Oct 5, 2023

Uh oh!

damdo commented Oct 9, 2023

Uh oh!

openshift-ci-robot commented Oct 9, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Karthik-K-N commented Oct 9, 2023

Uh oh!

Karthik-K-N commented Oct 12, 2023

Uh oh!

Karthik-K-N commented Oct 12, 2023

Uh oh!

dharaneeshvrd commented Oct 12, 2023

Uh oh!

Karthik-K-N commented Oct 12, 2023

Uh oh!

JoelSpeed commented Oct 12, 2023

Uh oh!

openshift-ci Bot commented Oct 12, 2023

Uh oh!

damdo commented Oct 16, 2023

Uh oh!

damdo commented Oct 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

openshift-ci-robot commented Oct 4, 2023 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Oct 9, 2023 •

edited by openshift-ci Bot

Loading