Skip to content

MULTIARCH-3760: Rename depricated flag for PowerVS capi deployment#3028

Merged
openshift-ci[bot] merged 1 commit into
openshift:mainfrom
dharaneeshvrd:powervs-capi-rename-provider-id-flag
Oct 11, 2023
Merged

MULTIARCH-3760: Rename depricated flag for PowerVS capi deployment#3028
openshift-ci[bot] merged 1 commit into
openshift:mainfrom
dharaneeshvrd:powervs-capi-rename-provider-id-flag

Conversation

@dharaneeshvrd

@dharaneeshvrd dharaneeshvrd commented Sep 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 20, 2023
@openshift-ci-robot

openshift-ci-robot commented Sep 20, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@dharaneeshvrd: This pull request references MULTIARCH-3760 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Sep 20, 2023
@csrwng

csrwng commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
bryan-cox
bryan-cox approved these changes Sep 22, 2023
View reviewed changes

@bryan-cox bryan-cox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2023
@openshift-ci-robot

openshift-ci-robot commented Sep 22, 2023

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 7fb0f42 and 2 for PR HEAD 35654b7 in total

@bryan-cox

bryan-cox commented Sep 23, 2023

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 23, 2023
@bryan-cox

bryan-cox commented Oct 5, 2023

Copy link
Copy Markdown
Member

/ok-to-test

@dharaneeshvrd dharaneeshvrd force-pushed the powervs-capi-rename-provider-id-flag branch from 35654b7 to d7b624c Compare October 5, 2023 12:41
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@openshift-ci-robot

openshift-ci-robot commented Oct 5, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@dharaneeshvrd: This pull request references MULTIARCH-3760 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify

netlify Bot commented Oct 5, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 03e4af6
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/652670ee72a1b20008b03757
😎 Deploy Preview https://deploy-preview-3028--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dharaneeshvrd dharaneeshvrd force-pushed the powervs-capi-rename-provider-id-flag branch from d7b624c to 03e4af6 Compare October 11, 2023 09:54
bryan-cox
bryan-cox approved these changes Oct 11, 2023
View reviewed changes

@bryan-cox bryan-cox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@openshift-ci

openshift-ci Bot commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, csrwng, dharaneeshvrd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

@dharaneeshvrd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot merged commit 7f7a6a5 into openshift:main Oct 11, 2023
@dharaneeshvrd dharaneeshvrd mentioned this pull request Oct 12, 2023
Merged
@dharaneeshvrd

dharaneeshvrd commented Oct 16, 2023

Copy link
Copy Markdown
Member Author

/cherry-pick release-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 16, 2023
Closed
@openshift-cherrypick-robot

openshift-cherrypick-robot commented Oct 16, 2023

Copy link
Copy Markdown

@dharaneeshvrd: new pull request created: #3100

Details

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

1 more reviewer

@bryan-cox bryan-cox bryan-cox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bryan-cox bryan-cox

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dharaneeshvrd @openshift-ci-robot @csrwng @bryan-cox @openshift-cherrypick-robot