MULTIARCH-3761: Power VS CAPI Remove deprecated flag#128
Conversation
|
Thanks for the PR @Karthik-K-N |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sure, Thanks will watch and update accordingly |
|
/test assets |
ac91d43 to
f83f7fa
Compare
| - --metrics-bind-addr=127.0.0.1:8080 | ||
| - --powervs-provider-id-fmt=v2 | ||
| - --provider-id-fmt=${PROVIDER_ID_FORMAT:=v1} | ||
| - --powervs-provider-id-fmt=${POWERVS_PROVIDER_ID_FORMAT:=v1} |
There was a problem hiding this comment.
This flag will be automatically removed while generating asset during next capi version update.
As it is already removed in upstream
|
/retest |
|
@Karthik-K-N: This pull request references MULTIARCH-3761 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
@Karthik-K-N: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
powervs-provider-id-fmtflag is deprecated and we are supposed to useprovider-id-fmtflag. Reference