OCPBUGS-18504: e2e: set ControlPlaneEndpoint in AWSCluster#126
Conversation
|
Skipping CI for Draft Pull Request. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1749b25 to
79a9f81
Compare
manifest config for CAPZ changed but we didn't update the corresponding asset here, this commit updates it in this repo.
|
@damdo: This pull request references Jira Issue OCPBUGS-18504, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@damdo: This pull request references Jira Issue OCPBUGS-18504, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
@damdo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@damdo when can we expect this PR to get merged. |
|
Hey @Karthik-K-N as soon as the critical fixes only label is lifted by the TRT team |
Ok, Thank you. |
|
/tide refresh |
|
/lgtm |
|
@damdo: Jira Issue OCPBUGS-18504: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18504 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This sets the ControlPlaneEndpoint before Cluster object creation. To make the Cluster go into
Provisionedstate.This is a temporary workaround, as we expect the Cluster & InfrastructureCluster objects creation and the population of the ControlPlaneEndpoint is going to happen in a dedicated controller within the operator.