Skip to content

Added Arithmetic functions to V2 engine#1416

Merged
Yury-Fridlyand merged 6 commits intoopensearch-project:mainfrom
Bit-Quill:integ-arithmetic
Mar 16, 2023
Merged

Added Arithmetic functions to V2 engine#1416
Yury-Fridlyand merged 6 commits intoopensearch-project:mainfrom
Bit-Quill:integ-arithmetic

Conversation

@matthewryanwells
Copy link
Copy Markdown
Contributor

@matthewryanwells matthewryanwells commented Mar 9, 2023 •
edited
Loading

Description

Added ADD, SUBTRACT, MULTIPLY, DIVIDE, and MODULUS to the new engine, as well as moved MOD from mathematical functions to arithmetics

Issues Resolved

#1190

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@matthewryanwells matthewryanwells requested a review from a team as a code owner March 9, 2023 19:23
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 9, 2023 •
edited
Loading

Codecov Report

Merging #1416 (462a4ee) into main (ef38389) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1416   +/-   ##
=========================================
  Coverage     98.38%   98.38%           
- Complexity     3698     3701    +3     
=========================================
  Files           343      343           
  Lines          9121     9124    +3     
  Branches        586      586           
=========================================
+ Hits           8974     8977    +3     
  Misses          142      142           
  Partials          5        5
Flag Coverage Δ
sql-engine 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ssion/operator/arthmetic/MathematicalFunction.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...ression/operator/arthmetic/ArithmeticFunction.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matthewryanwells
Updated Arithmetic functions from old engine to new engine (#235)
18b0e8b 
* Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
@matthewryanwells matthewryanwells changed the title Updated Arithmetic functions to V2 engine Added Arithmetic functions to V2 engine Mar 9, 2023
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Mar 10, 2023
View reviewed changes
MaxKsyunz
MaxKsyunz previously approved these changes Mar 11, 2023
View reviewed changes
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 14, 2023
Closed
10 tasks
@matthewryanwells
Fixed merging error
6c27f5c 
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Mar 15, 2023
View reviewed changes
@dai-chen
Copy link
Copy Markdown
Collaborator

dai-chen commented Mar 15, 2023

Please resolve the conflicts.

@matthewryanwells
fixed merge errors
2975cb8 
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
@dai-chen dai-chen requested a review from Yury-Fridlyand March 16, 2023 20:45
@Yury-Fridlyand Yury-Fridlyand merged commit bc39346 into opensearch-project:main Mar 16, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the integ-arithmetic branch March 16, 2023 21:00
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 16, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 16, 2023
@matthewryanwells @github-actions
Added Arithmetic functions to V2 engine (#1416)
20800d7 
* Updated Arithmetic functions from old engine to new engine (#235)

* Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit bc39346)
Yury-Fridlyand pushed a commit that referenced this pull request Mar 17, 2023
@opensearch-trigger-bot @matthewryanwells
Added Arithmetic functions to V2 engine (#1416) (#1448)
c286846 
* Updated Arithmetic functions from old engine to new engine (#235)

* Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit bc39346)

Co-authored-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dai-chen dai-chen dai-chen approved these changes

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

+2 more reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@MaxKsyunz MaxKsyunz MaxKsyunz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x enhancement New feature or request new-engine-gap SQL v2.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matthewryanwells @codecov-commenter @dai-chen @Yury-Fridlyand @MaxKsyunz