Updated Arithmetic functions from old engine to new engine#235
Merged
matthewryanwells merged 45 commits intointeg-arithmeticfrom Mar 9, 2023
Merged
Updated Arithmetic functions from old engine to new engine#235matthewryanwells merged 45 commits intointeg-arithmeticfrom
matthewryanwells merged 45 commits intointeg-arithmeticfrom
Conversation
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
… function description to mention relation to * symbol Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
* Add release notes for 2.6.0 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Remove incorrect links Signed-off-by: Rupal Mahajan <maharup@amazon.com> --------- Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/ArithmeticFunction.java
Show resolved
Hide resolved
…, fixed multiply being in mathematical function, updated documentation Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Codecov Report
@@ Coverage Diff @@
## integ-arithmetic #235 +/- ##
======================================================
- Coverage 99.96% 98.38% -1.58%
- Complexity 2467 3696 +1229
======================================================
Files 220 343 +123
Lines 5833 9110 +3277
Branches 359 585 +226
======================================================
+ Hits 5831 8963 +3132
- Misses 2 142 +140
- Partials 0 5 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 123 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
GumpacG
approved these changes
Feb 27, 2023
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…on to account for that change Signed-off-by: Matthew Wells <matthew.wells@improving.com>
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/ArithmeticFunction.java
Outdated
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/sql/MathematicalFunctionIT.java
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/sql/MathematicalFunctionIT.java
Show resolved
Hide resolved
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…, fixed multiply being in mathematical function, updated documentation Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…ypes Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…cfunctions Signed-off-by: Matthew Wells <matthew.wells@improving.com>
|
Can you add a test where the function has more than two arguments. For example, |
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Author
I have added a test to confirm that all functions fail when working with more than two parameters |
acarbonetto
reviewed
Mar 3, 2023
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/ArithmeticFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/ArithmeticFunction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
…rformance hit was too large Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
acarbonetto
approved these changes
Mar 8, 2023
Yury-Fridlyand
approved these changes
Mar 8, 2023
core/src/main/java/org/opensearch/sql/expression/operator/arthmetic/ArithmeticFunction.java
Show resolved
Hide resolved
…d mod in parser Signed-off-by: Matthew Wells <matthew.wells@improving.com>
matthewryanwells
added a commit
that referenced
this pull request
Mar 9, 2023
* Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine Signed-off-by: Matthew Wells <matthew.wells@improving.com>
GabeFernandez310
pushed a commit
that referenced
this pull request
Mar 16, 2023
* Updated Arithmetic functions from old engine to new engine (#235) * Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine Signed-off-by: Matthew Wells <matthew.wells@improving.com>
MaxKsyunz
pushed a commit
that referenced
this pull request
Mar 29, 2023
…ensearch-project#1448) * Updated Arithmetic functions from old engine to new engine (#235) * Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit bc39346) Co-authored-by: Matthew Wells <matthew.wells@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added ADD, SUBTRACT, MULTIPLY, DIVIDE, and MODULUS to the new engine, as well as moved MOD from mathematical functions to arithmetics
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.