Skip to content

[Backport 2.x] Added Arithmetic functions to V2 engine#1448

Merged
Yury-Fridlyand merged 1 commit into2.xfrom
backport/backport-1416-to-2.x
Mar 17, 2023
Merged

[Backport 2.x] Added Arithmetic functions to V2 engine#1448
Yury-Fridlyand merged 1 commit into2.xfrom
backport/backport-1416-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

Backport bc39346 from #1416

* Updated Arithmetic functions from old engine to new engine (#235)

* Updated ADD, SUBTRACT, MULTIPLY, DIVIDE, MODULUS to V2 engine

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit bc39346)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 16, 2023 21:00
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 16, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.42%. Comparing base (5f1747d) to head (20800d7).
⚠️ Report is 381 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #1448   +/-   ##
=========================================
  Coverage     98.42%   98.42%           
- Complexity     3754     3757    +3     
=========================================
  Files           343      343           
  Lines          9312     9315    +3     
  Branches        597      597           
=========================================
+ Hits           9165     9168    +3     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dai-chen dai-chen added the enhancement New feature or request label Mar 17, 2023
@Yury-Fridlyand Yury-Fridlyand merged commit c286846 into 2.x Mar 17, 2023
@github-actions github-actions bot deleted the backport/backport-1416-to-2.x branch March 17, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants