RestIntegTestTask fails because of missed log4j-core dependency#1815
Merged
dblock merged 1 commit intoopensearch-project:mainfrom Dec 28, 2021
Merged
RestIntegTestTask fails because of missed log4j-core dependency#1815dblock merged 1 commit intoopensearch-project:mainfrom
dblock merged 1 commit intoopensearch-project:mainfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
Contributor
Author
|
@saratvemulapalli @dblock the root cause is clear now: the |
Collaborator
|
❌ Gradle Check failure def1710508c0f56511ab2d6bda20f4b85e7dcd66 |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dblock
approved these changes
Dec 28, 2021
Member
dblock
left a comment
There was a problem hiding this comment.
There's got to be a better fix than this, but YOLO.
Merged
5 tasks
Merged
5 tasks
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
Dec 28, 2021
…search-project#1815) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Contributor
Author
I think with the way the plugin is implemented right now, the fix is fine - single place where the dependencies are set up. But surely, there are other ways to fix that. |
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
Dec 28, 2021
…search-project#1815) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dblock
pushed a commit
that referenced
this pull request
Dec 28, 2021
… (#1818) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dblock
pushed a commit
that referenced
this pull request
Dec 28, 2021
… (#1819) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
Using opensearch.yaml-rest-test Gradle plugin outside of the OpenSearch core (fe, in plugins), for example yamlRestTest, fails with the following exception:
Since the log4j-core is declared as optional, it is not being picked up. Adding it as an explicit dependency does not solve the problem either (see please opensearch-project/opensearch-plugin-template-java#16 for more details) because the task uses dedicated configuration
yamlRestTestImplementationand only its dependencies.Issues Resolved
Closes #1814
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.