Upgraded to OpenSearch 1.2.3. by dblock · Pull Request #16 · opensearch-project/opensearch-plugin-template-java

dblock · 2021-12-14T18:06:32Z

Description

Upgraded to OpenSearch 1.2.3
Expanded build matrix to MacOS
Added bin to .gitignore

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>

dblock · 2021-12-14T18:36:46Z

I don't get how I'm supposed to fix this or why this happens. Adding import de.thetaphi.forbiddenapis.gradle.ForbiddenApisPlugin doesn't seem to do anything?

* What went wrong:
A problem occurred evaluating root project 'plugin-template'.
> Failed to apply plugin class 'de.thetaphi.forbiddenapis.gradle.ForbiddenApisPlugin'.
   > Could not create plugin of type 'ForbiddenApisPlugin'.
      > Could not initialize class de.thetaphi.forbiddenapis.gradle.ForbiddenApisPlugin

saratvemulapalli · 2021-12-15T19:54:17Z

I don't get how I'm supposed to fix this or why this happens. Adding import de.thetaphi.forbiddenapis.gradle.ForbiddenApisPlugin doesn't seem to do anything?
* What went wrong:
A problem occurred evaluating root project 'plugin-template'.
> Failed to apply plugin class 'de.thetaphi.forbiddenapis.gradle.ForbiddenApisPlugin'.
   > Could not create plugin of type 'ForbiddenApisPlugin'.
      > Could not initialize class de.thetaphi.forbiddenapis.gradle.ForbiddenApisPlugin

Interesting..do you who is pulling ForbiddenApisPlugin?
From build.gradle I dont see anything.

saratvemulapalli · 2021-12-15T19:55:46Z

Looks like OpenSearch is doing it via gradle.
https://github.com/opensearch-project/OpenSearch/search?q=ForbiddenApisPlugin

Signed-off-by: dblock <dblock@dblock.org>

dblock · 2021-12-23T21:04:26Z

With 1.2.3 the new error is

> Task :yamlRestTest

org.opensearch.path.to.plugin.RenameClientYamlTestSuiteIT > initializationError FAILED
    java.lang.NoClassDefFoundError: org/apache/logging/log4j/core/Layout

I don't get why this is happening.

@reta maybe you will have some ideas?

dblock · 2021-12-23T21:05:11Z

@AmiStrn any ideas how to fix this?

reta · 2021-12-23T21:23:06Z

@dblock oh I know what this is about, gimme please 10 mins

AmiStrn · 2021-12-23T21:28:16Z

Its gotta be something in the build.gradle file. It is pretty late on this side of the globe. I can take a look later on friday unless @reta has it pin pointed already:)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta · 2021-12-23T21:42:26Z

@dblock I created this pull request to fix the issue dblock#1

reta · 2021-12-23T21:47:35Z

Its gotta be something in the build.gradle file. It is pretty late on this side of the globe. I can take a look later on friday unless @reta has it pin pointed already:)

It is a bit more tricker, it is optional dependencies, which seems to be treated differently when api "org.opensearch:opensearch:${opensearch_version}" vs api project(':server') :(

Fixing RestIntegTestTask runtime configuration

dblock · 2021-12-23T22:28:07Z

🤯 @reta I don't know why or how you knew how to fix this one but hat tip

reta · 2021-12-23T22:29:26Z

exploding_head @reta I don't know why or how you knew how to fix this one but hat tip

It happens I run into that a few days ago while working on POC to move out the repository plugins 😄

AmiStrn

Thank you @reta for your valuable insight on this issue!

dblock · 2021-12-25T16:16:32Z

@CEHENKLE Can you please help with permissions here? We have a 2 people approvals required by the org, and there's not 2 people maintaining this repo.

dblock · 2021-12-27T16:41:45Z

@AmiStrn cool if I add @saratvemulapalli to PR reviewers to this project?

Maybe @reta is also interested?

saratvemulapalli · 2021-12-27T17:12:52Z

build.gradle

+tasks.withType(RestIntegTestTask)*.configure {
+  classpath += files(project.configurations.runtimeClasspath.findAll { it.name.contains("log4j-core") })
+}


Why is log4j-core special?

@saratvemulapalli see please #16 (comment), it is need but is optional

Thanks @reta , I did read through the comments on dblock#1.
I still dont understand why :)

There is something coming from the plugin apparently, I will create an issue shortly to figure out exactly what is going on, will ping you there, thanks!

reta · 2021-12-27T17:23:52Z

@AmiStrn cool if I add @saratvemulapalli to PR reviewers to this project?

Maybe @reta is also interested?

@dblock I am certainly in, thank you

dblock · 2021-12-27T17:51:41Z

@AmiStrn cool if I add @saratvemulapalli to PR reviewers to this project?
Maybe @reta is also interested?

@dblock I am certainly in, thank you

Thanks. @AmiStrn LMK if it's ok to add these two with write permissions?

AmiStrn · 2021-12-27T19:12:39Z

Thanks. @AmiStrn LMK if it's ok to add these two with write permissions?

@saratvemulapalli and @reta are more than welcome:)

AmiStrn · 2021-12-27T20:42:23Z

@dblock I added @saratvemulapalli because he is in the org it seemed to work fine. However, im gonna need help with @reta 🙏

dblock · 2021-12-27T21:41:29Z

@dblock I added @saratvemulapalli because he is in the org it seemed to work fine. However, im gonna need help with @reta 🙏

Exactly. I think org owners need to do something to bring in an external user for the first time. I’ll go find out how (I’m not an org owner).

dblock · 2022-01-03T20:26:20Z

@reta you should have received an invite to this repo, please let me know if you haven't

https://github.com/opensearch-project/opensearch-plugin-template-java/invitations

reta · 2022-01-03T20:33:51Z

@dblock all good, got it and accepted it, thank you! ❤️

dblock · 2022-01-03T20:35:47Z

@dblock all good, got it and accepted it, thank you! ❤️

Thank you for contributing!

dblock force-pushed the upgrade-1.2.1 branch 2 times, most recently from cc2c01f to 7a4374c Compare December 14, 2021 18:10

Upgraded to OpenSearch 1.2.1.

94fbbd9

Signed-off-by: dblock <dblock@amazon.com>

dblock force-pushed the upgrade-1.2.1 branch from 7a4374c to 94fbbd9 Compare December 14, 2021 18:11

Use 1.2.3-SNAPSHOT.

a2227cd

Signed-off-by: dblock <dblock@dblock.org>

dblock changed the title ~~Upgraded to OpenSearch 1.2.1.~~ Upgraded to OpenSearch 1.2.3. Dec 23, 2021

Remove JDK11 build.

d7352d7

Signed-off-by: dblock <dblock@dblock.org>

Fixing RestIntegTestTask runtime configuration

55efba4

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Merge pull request #1 from reta/upgrade-1.2.1

94a5316

Fixing RestIntegTestTask runtime configuration

dblock requested a review from AmiStrn December 23, 2021 22:28

reta approved these changes Dec 23, 2021

View reviewed changes

VijayanB mentioned this pull request Dec 24, 2021

Use latest snapshot for upstream opensearch-project/geospatial#12

Merged

1 task

AmiStrn approved these changes Dec 25, 2021

View reviewed changes

saratvemulapalli reviewed Dec 27, 2021

View reviewed changes

saratvemulapalli approved these changes Dec 27, 2021

View reviewed changes

AmiStrn mentioned this pull request Dec 27, 2021

[DOCUMENTATION] update documentation to reflect newer version and changes since the beta version #17

Closed

dblock merged commit 0224ae0 into opensearch-project:main Dec 27, 2021

dblock deleted the upgrade-1.2.1 branch December 27, 2021 21:42

Conversation

dblock commented Dec 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Check List

Uh oh!

dblock commented Dec 14, 2021

Uh oh!

saratvemulapalli commented Dec 15, 2021

Uh oh!

saratvemulapalli commented Dec 15, 2021

Uh oh!

dblock commented Dec 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dblock commented Dec 23, 2021

Uh oh!

reta commented Dec 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AmiStrn commented Dec 23, 2021

Uh oh!

reta commented Dec 23, 2021

Uh oh!

reta commented Dec 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dblock commented Dec 23, 2021

Uh oh!

reta commented Dec 23, 2021

Uh oh!

AmiStrn left a comment

Choose a reason for hiding this comment

Uh oh!

dblock commented Dec 25, 2021

Uh oh!

dblock commented Dec 27, 2021

Uh oh!

saratvemulapalli Dec 27, 2021

Choose a reason for hiding this comment

Uh oh!

reta Dec 27, 2021

Choose a reason for hiding this comment

Uh oh!

saratvemulapalli Dec 27, 2021

Choose a reason for hiding this comment

Uh oh!

reta Dec 27, 2021

Choose a reason for hiding this comment

Uh oh!

reta commented Dec 27, 2021

Uh oh!

dblock commented Dec 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AmiStrn commented Dec 27, 2021

Uh oh!

AmiStrn commented Dec 27, 2021

Uh oh!

dblock commented Dec 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dblock commented Jan 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reta commented Jan 3, 2022

Uh oh!

dblock commented Jan 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dblock commented Dec 14, 2021 •

edited

Loading

dblock commented Dec 23, 2021 •

edited

Loading

reta commented Dec 23, 2021 •

edited

Loading

reta commented Dec 23, 2021 •

edited

Loading

dblock commented Dec 27, 2021 •

edited

Loading

dblock commented Dec 27, 2021 •

edited

Loading

dblock commented Jan 3, 2022 •

edited

Loading