Skip to content

[Backport] [1.x] RestIntegTestTask fails because of missed log4j-core dependency (#1815)#1818

Merged
dblock merged 1 commit intoopensearch-project:1.xfrom
reta:issue-1814.1.x
Dec 28, 2021
Merged

[Backport] [1.x] RestIntegTestTask fails because of missed log4j-core dependency (#1815)#1818
dblock merged 1 commit intoopensearch-project:1.xfrom
reta:issue-1814.1.x

Conversation

@reta
Copy link
Copy Markdown
Contributor

@reta reta commented Dec 28, 2021

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Backport of #1815 to 1.x

Using opensearch.yaml-rest-test Gradle plugin outside of the OpenSearch core (fe, in plugins), for example yamlRestTest, fails with the following exception:

> Task :yamlRestTest

org.opensearch.path.to.plugin.RenameClientYamlTestSuiteIT > initializationError FAILED
    java.lang.NoClassDefFoundError: org/apache/logging/log4j/core/Layout

Since the log4j-core is declared as optional, it is not being picked up. Adding it as an explicit dependency does not solve the problem either (see please opensearch-project/opensearch-plugin-template-java#16 for more details) because the task uses dedicated configuration yamlRestTestImplementation and only its dependencies.

Issues Resolved

Closes #1814

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

❌   Gradle Check failure 97f3256ef7bc66365753b2cbd0a135236a52a026
Log 1702

Reports 1702

@dblock
Copy link
Copy Markdown
Member

dblock commented Dec 28, 2021

start gradle check

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   Gradle Check success e01c3c6
Log 1706

Reports 1706

@opensearch-ci-bot
Copy link
Copy Markdown
Collaborator

✅   Gradle Check success e01c3c6
Log 1709

Reports 1709

@dblock dblock merged commit dc63dcc into opensearch-project:1.x Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants