Skip to content

Replaced caffe model with onnx for colorization sample#25433

Merged
asmorkalov merged 5 commits intoopencv:5.xfrom
gursimarsingh:colorization_onnx_sample
Apr 18, 2024
Merged

Replaced caffe model with onnx for colorization sample#25433
asmorkalov merged 5 commits intoopencv:5.xfrom
gursimarsingh:colorization_onnx_sample

Conversation

@gursimarsingh
Copy link
Copy Markdown
Contributor

@gursimarsingh gursimarsingh commented Apr 17, 2024 •
edited
Loading

#25006

Improved sample for colorization with onnx model in cpp and python. Added a demo image in data folder for testing

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@gursimarsingh gursimarsingh self-assigned this Apr 17, 2024
@gursimarsingh gursimarsingh added category: samples cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) OpenCV5 labels Apr 17, 2024
@gursimarsingh gursimarsingh added this to the 5.0 milestone Apr 17, 2024
asmorkalov
asmorkalov reviewed Apr 18, 2024
View reviewed changes
asmorkalov
asmorkalov reviewed Apr 18, 2024
View reviewed changes
@WanliZhong WanliZhong mentioned this pull request Apr 18, 2024
Open
18 tasks
asmorkalov
asmorkalov approved these changes Apr 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 448375d into opencv:5.x Apr 18, 2024
@LaurentBerger
Copy link
Copy Markdown
Contributor

LaurentBerger commented Apr 18, 2024

opencv/samples/dnn/action_recognition.py

Line 48 in 448375d

net = cv.dnn.readNet(net_path)

opencv/samples/dnn/classification.cpp

Line 105 in 448375d

Net net = readNet(model, config, framework);

opencv/samples/dnn/edge_detection.py

Line 46 in 448375d

net = cv.dnn.readNet(cv.samples.findFile(args.prototxt), cv.samples.findFile(args.caffemodel))

opencv/samples/dnn/fast_neural_style.py

Line 16 in 448375d

net = cv.dnn.readNet(cv.samples.findFile(args.model))

opencv/samples/dnn/object_detection.cpp

Line 161 in 448375d

Net net = readNet(modelPath, configPath, parser.get<String>("framework"));

@gursimarsingh gursimarsingh mentioned this pull request May 1, 2024
Merged
asmorkalov pushed a commit that referenced this pull request Sep 9, 2024
@gursimarsingh
Merge pull request #25520 from gursimarsingh:add-bigvision-copyright
99bc88c 
Add bigvision copyright #25520

This pull request adds Bigvision LLC to the copyright list to recognize our contributions to the project [#25433, #25415, #25304]. This update reflects our ongoing commitment to supporting and maintaining this project. Please let me know if there are any adjustments you would like me to make. Thank you for considering this addition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@vpisarev vpisarev Awaiting requested review from vpisarev

+1 more reviewer

@LaurentBerger LaurentBerger LaurentBerger left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@asmorkalov asmorkalov

Labels

category: samples cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) OpenCV5

Projects

OpenCV 5.0
Status: Done

Milestone

5.0-alpha

Development

Successfully merging this pull request may close these issues.

3 participants

@gursimarsingh @LaurentBerger @asmorkalov