Skip to content

Improving the drawing cpp sample to draw shapes based on user input#25415

Merged
asmorkalov merged 2 commits intoopencv:5.xfrom
gursimarsingh:improved_drawing_cpp_sample
Apr 16, 2024
Merged

Improving the drawing cpp sample to draw shapes based on user input#25415
asmorkalov merged 2 commits intoopencv:5.xfrom
gursimarsingh:improved_drawing_cpp_sample

Conversation

@gursimarsingh
Copy link
Copy Markdown
Contributor

@gursimarsingh gursimarsingh commented Apr 15, 2024 •
edited
Loading

#25006

The updated samples allows user to draw randome shapes by using hot keys

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@gursimarsingh gursimarsingh added category: samples cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) OpenCV5 labels Apr 15, 2024
asmorkalov
asmorkalov approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 68967cf into opencv:5.x Apr 16, 2024
@asmorkalov asmorkalov self-assigned this Apr 16, 2024
@asmorkalov asmorkalov added this to the 5.0 milestone Apr 16, 2024
@gursimarsingh gursimarsingh mentioned this pull request May 1, 2024
Merged
asmorkalov pushed a commit that referenced this pull request Sep 9, 2024
@gursimarsingh
Merge pull request #25520 from gursimarsingh:add-bigvision-copyright
99bc88c 
Add bigvision copyright #25520

This pull request adds Bigvision LLC to the copyright list to recognize our contributions to the project [#25433, #25415, #25304]. This update reflects our ongoing commitment to supporting and maintaining this project. Please let me know if there are any adjustments you would like me to make. Thank you for considering this addition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: samples cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) OpenCV5

Projects

OpenCV 5.0
Status: Done

Milestone

5.0-alpha

Development

Successfully merging this pull request may close these issues.

2 participants

@gursimarsingh @asmorkalov