Skip to content

geometry cpp sample combining other shape detection samples#25304

Merged
asmorkalov merged 5 commits intoopencv:5.xfrom
gursimarsingh:geometry_sample_cpp
Apr 16, 2024
Merged

geometry cpp sample combining other shape detection samples#25304
asmorkalov merged 5 commits intoopencv:5.xfrom
gursimarsingh:geometry_sample_cpp

Conversation

@gursimarsingh
Copy link
Copy Markdown
Contributor

@gursimarsingh gursimarsingh commented Apr 1, 2024

Clean Samples #25006
This PR removes adds a new cpp sample (geometry) which combines different methods of finding and drawing shapes in an image. It makes separate samples for convexHull, fitellipse, minAreaRect, minAreaCircle redudant. Shapes can be changed using hotkeys after running the program

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@gursimarsingh gursimarsingh added category: samples cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) OpenCV5 labels Apr 1, 2024
@gursimarsingh gursimarsingh self-assigned this Apr 1, 2024
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 3e561d8 into opencv:5.x Apr 16, 2024
@dkurt dkurt added this to the 5.0 milestone Apr 17, 2024
asmorkalov pushed a commit that referenced this pull request Sep 9, 2024
Add bigvision copyright #25520

This pull request adds Bigvision LLC to the copyright list to recognize our contributions to the project [#25433, #25415, #25304]. This update reflects our ongoing commitment to supporting and maintaining this project. Please let me know if there are any adjustments you would like me to make. Thank you for considering this addition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: samples cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) OpenCV5

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants