Skip to content

docs: clarify config default review risk policy#86295

Open
clawsweeper[bot] wants to merge 2 commits into
mainfrom
clawsweeper/issue-openclaw-openclaw-86288
Open

docs: clarify config default review risk policy#86295
clawsweeper[bot] wants to merge 2 commits into
mainfrom
clawsweeper/issue-openclaw-openclaw-86288

Conversation

@clawsweeper

@clawsweeper clawsweeper Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Clarifies the root AGENTS.md ClawSweeper Review Policy for new or changed config/default additions.
  • Routes those additions through reviewMetrics and existing merge-risk review fields when they can affect existing users, upgrades, provider/plugin behavior, persisted preferences, setup, startup, fallback behavior, workflow behavior, or operator action.

Closes #86288
Requested by @Takhoffman.

Verification

  • pnpm check:changed
  • git diff --check

Real behavior proof

  • Behavior addressed: root AGENTS.md now tells ClawSweeper review workers to treat relevant config/default additions as review-metric and merge-risk material.
  • Real environment tested: repository checkout on the repair branch.
  • Exact steps or command run after this patch: pnpm check:changed; git diff --check
  • Evidence after fix: command output from the executor or CI for the repair branch.
  • Observed result after fix: policy-only change passes changed checks and whitespace validation.
  • What was not tested: runtime OpenClaw behavior, because this changes repository review policy text only.

ClawSweeper 🐠 replacement reef notes:

fish notes: model gpt-5.5, reasoning high; reviewed against fa00c61.

@clawsweeper clawsweeper Bot added clawsweeper Tracked by ClawSweeper automation clawsweeper:autogenerated PR created automatically by ClawSweeper labels May 25, 2026
@clawsweeper clawsweeper Bot mentioned this pull request May 25, 2026
Closed
@clawsweeper

clawsweeper Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Codex review: needs maintainer review before merge. Reviewed May 24, 2026, 11:08 PM ET / 03:08 UTC.

Summary
The PR updates root AGENTS.md to clarify config/default additions as reviewMetrics and merge-risk material in compatibility-sensitive reviews, and adds a maintainer-facing CHANGELOG.md entry.

PR surface: Docs +2. Total +2 across 2 files.

Reproducibility: not applicable. this is a repository policy/docs PR, not a runtime bug with a failing reproduction path. The relevant check is whether the wording covers the linked request and prior review feedback.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • No ClawSweeper repair lane is needed because the current PR already contains the narrow text change and has no actionable review findings.

Security
Cleared: The diff changes repository policy text and a changelog entry only, with no code execution, dependency, workflow, secret, or supply-chain surface changed.

Review details

Best possible solution:

Land this narrow policy clarification after normal maintainer review and CI, keeping the guidance in root AGENTS.md and using generic ClawSweeper review fields rather than adding a repository-specific schema concept.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this is a repository policy/docs PR, not a runtime bug with a failing reproduction path. The relevant check is whether the wording covers the linked request and prior review feedback.

Is this the best way to solve the issue?

Yes: the current patch is the narrow maintainable solution because it extends the existing compatibility/upgrade-sensitive AGENTS.md bullet and keeps ClawSweeper using generic reviewMetrics plus existing merge-risk fields.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 3db1508f1ee7.

Label changes

Label changes:

  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This is a ClawSweeper bot policy-text PR, so the external contributor real-behavior proof gate does not apply; the PR body lists pnpm check:changed and git diff --check as validation.
  • remove status: needs maintainer proof decision: Current PR status label is status: 👀 ready for maintainer look.

Label justifications:

  • P3: This is a low-risk repository-policy documentation change with no runtime OpenClaw behavior change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: This is a ClawSweeper bot policy-text PR, so the external contributor real-behavior proof gate does not apply; the PR body lists pnpm check:changed and git diff --check as validation.
Evidence reviewed

PR surface:

Docs +2. Total +2 across 2 files.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 0 0 0 0
Docs 2 3 1 +2
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 2 3 1 +2

What I checked:

  • Root policy read: The root repository policy was read in full enough to apply the ClawSweeper Review Policy section that owns this PR's touched surface. (AGENTS.md:20, 3db1508f1ee7)
  • Current policy baseline: Current main already marks plugin APIs, provider routing, persisted preferences, config loading, migrations, setup, startup checks, and fallback behavior as compatibility/upgrade-sensitive; the PR extends this existing bullet rather than creating a new policy section. (AGENTS.md:26, 3db1508f1ee7)
  • PR diff matches requested repair: The provided PR patch adds that config/default additions are reviewMetrics and merge-risk material when they can affect users, upgrades, provider/plugin behavior, preferences, setup, startup, workflow, fallbacks, or operator action, and adds count/direction guidance for the metric. (AGENTS.md:26, d0cc9f2e3ebb)
  • Linked issue context: The linked request asks for AGENTS.md policy to cover config/default additions, reviewMetrics count/direction, existing merge-risk fields, and no OpenClaw-specific schema concept; the current PR is scoped to that request.
  • No matching maintainer notes: The only maintainer note present was for Telegram, so there was no matching internal maintainer note for root AGENTS.md or CHANGELOG.md policy text.
  • Feature history: The root ClawSweeper Review Policy section being refined was introduced by the merged AGENTS.md policy PR, which this PR builds on. (AGENTS.md:20, 242e8767e7a7)

Likely related people:

  • clawsweeper[bot]: Git blame and log show the bot-authored merged PR added the ClawSweeper Review Policy section that this PR refines, and the bot also authored this replacement branch. (role: recent area contributor; confidence: high; commits: 242e8767e7a7, 543c0d321ca8, d0cc9f2e3ebb; files: AGENTS.md, CHANGELOG.md)
  • Takhoffman: The linked issue and PR body identify Takhoffman as the requester for the config/default review-policy clarification. (role: requester and policy stakeholder; confidence: medium; files: AGENTS.md)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. labels May 25, 2026
@clawsweeper

clawsweeper Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

ClawSweeper PR egg

✨ Hatched: 💎 rare Tiny Branchling

Hatch command

Comment @clawsweeper hatch when this PR is hatchable.

Hatchability rules:

  • Merged PRs are hatchable.
  • Open PRs are hatchable when they are status: 👀 ready for maintainer look, status: 🚀 automerge armed, or labeled clawsweeper:automerge.
  • Closed unmerged PRs are hatchable only when one of those hatchable labels is still present in the durable record.

Rarity: 💎 rare.
Trait: sparkles near resolved comments.
Image traits: location merge queue dock; accessory rollback rope; palette plum, gold, and soft gray; mood determined; pose guarding a tiny green check; shell frosted glass shell; lighting golden review-room light; background gentle dashboard dots.
Share on X: post this hatch
Copy: My PR egg hatched a 💎 rare Tiny Branchling in ClawSweeper.

What is this egg doing here?
  • Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
  • The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
  • Hatchability usually comes from sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness. A merged PR is already final, so merge makes the egg hatchable independently.
  • The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
  • Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

@clawsweeper

clawsweeper Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

🦞🔧
ClawSweeper applied a repair to this PR branch.

Repair: kept the fix on this contributor branch instead of opening a replacement PR.
Validation: pnpm check:changed; pnpm lint; pnpm check:test-types
Updated head: d0cc9f2e3ebb
Run: https://github.com/openclaw/clawsweeper/actions/runs/26380684144

Current state: exact-head review queued immediately; GitHub checks and the review verdict gate final merge.

Automerge progress:

  • 2026-05-25 02:52:05 UTC review requested repair fa00c6183252 (structured ClawSweeper marker: fix-required (finding=review-feedback sha=fa00c6...)
  • 2026-05-25 02:59:15 UTC review queued d0cc9f2e3ebb (after repair)

clawsweeper Bot added 2 commits May 25, 2026 02:56
@clawsweeper
docs: clarify config default review risk policy
543c0d3 
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
@clawsweeper
docs: clarify config default review risk policy
d0cc9f2
@clawsweeper clawsweeper Bot force-pushed the clawsweeper/issue-openclaw-openclaw-86288 branch from fa00c61 to d0cc9f2 Compare May 25, 2026 02:59
@Takhoffman

Takhoffman commented May 25, 2026

Copy link
Copy Markdown
Contributor

@clawsweeper repair

@clawsweeper

clawsweeper Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

🦞👀
ClawSweeper assist is taking a look at your question.

I queued a lightweight read-only assist pass. It will post a separate answer comment and will not edit the durable ClawSweeper review comment or trigger close, merge, repair, label, or branch changes.

Request: repair

@clawsweeper

clawsweeper Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

ClawSweeper assist: This is a repair request, not a maintainer Q&A question. The existing repair workflow should handle branch edits or CI repair for #86295.

Evidence:

  • Source comment is @clawsweeper repair: docs: clarify config default review risk policy #86295 (comment)
  • PR head is clawsweeper/issue-openclaw-openclaw-86288 at d0cc9f2e3ebbe6c417c85a794da4a5f39ee47e65.
  • The prior review said a narrow automated repair could update AGENTS.md wording for missing reviewMetrics count/direction guidance.

Suggested next action: Use the existing repair command path for this PR; for a full correctness review, ask @clawsweeper review.

Source: #86295 (comment)
Assist model: gpt-5.5, reasoning low.

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels May 25, 2026
@clawsweeper clawsweeper Bot added status: needs maintainer proof decision A ClawSweeper-authored PR needs a maintainer proof capture or override decision. and removed status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Jun 6, 2026
@clawsweeper

clawsweeper Bot commented Jun 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

ClawSweeper status: this ClawSweeper-authored replacement PR is blocked on real behavior proof.

Reviewed head: d0cc9f2e3ebbe6c417c85a794da4a5f39ee47e65
Proof status: not_applicable
Updated: 2026-06-12T11:20:26.249Z

Maintainer decision needed:

  • capture real behavior proof for this head
  • apply proof: override if the proof requirement should be waived
  • pause or close the replacement if proof should not be pursued

@clawsweeper clawsweeper Bot added status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. status: needs maintainer proof decision A ClawSweeper-authored PR needs a maintainer proof capture or override decision. and removed status: needs maintainer proof decision A ClawSweeper-authored PR needs a maintainer proof capture or override decision. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

clawsweeper:autogenerated PR created automatically by ClawSweeper clawsweeper Tracked by ClawSweeper automation P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: XS status: needs maintainer proof decision A ClawSweeper-authored PR needs a maintainer proof capture or override decision.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify AGENTS.md review policy for config/default additions as review metrics and merge risk

1 participant

@Takhoffman