-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
Clarify AGENTS.md review policy for config/default additions as review metrics and merge risk #86288
Copy link
Copy link
Labels
P3Low-priority cleanup, docs, polish, ergonomics, or speculative work.Low-priority cleanup, docs, polish, ergonomics, or speculative work.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.issue-rating: 🌊 off-meta tidepoolIssue quality rating does not apply to this item.Issue quality rating does not apply to this item.maintainerMaintainer-authored PRMaintainer-authored PR
Metadata
Metadata
Assignees
Labels
P3Low-priority cleanup, docs, polish, ergonomics, or speculative work.Low-priority cleanup, docs, polish, ergonomics, or speculative work.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.issue-rating: 🌊 off-meta tidepoolIssue quality rating does not apply to this item.Issue quality rating does not apply to this item.maintainerMaintainer-authored PRMaintainer-authored PR
Type
Fields
Give feedbackNo fields configured for issues without a type.
Goal
Update
AGENTS.mdso OpenClaw-specific ClawSweeper review policy treats new or changed config/default surfaces as review metrics and merge-risk material when they can affect existing users, upgrade behavior, operator action, provider routing, plugin behavior, persisted preferences, setup, startup, or fallback behavior.This is an OpenClaw repository policy clarification. It should steer review behavior through ClawSweeper's generic
reviewMetricsshape and existing review fields such asmergeRiskLabels,risks,bestSolution,mergeRiskOptions, andlabelJustifications.Background
The current
AGENTS.mdalready says plugin APIs, provider routing, auth/session state, persisted preferences, config loading, migrations, setup, startup checks, and fallback behavior are compatibility/upgrade-sensitive. It also says config breaks, removed fallbacks, fail-closed changes, or new operator action should be treated as merge risk even with green CI.That policy should also cover new config/default additions. Adding a new option, default, required setting, strict mode, validation path, provider route, startup check, workflow behavior, or operator action can change the effective contract even when nothing is removed.
When practical, the review should make the count and direction visible through
reviewMetrics, such as “adds 2 config/default surfaces,” “changes 1 default,” or “removes 1 fallback/config surface.” When that metric indicates concrete merge risk, the concern should also appear inrisksand the appropriate merge-risk fields.Proposed AGENTS.md update
In
## ClawSweeper Review Policy, update the existing compatibility/upgrade-sensitive bullet to explicitly include additions.Suggested wording:
- Plugin APIs, provider routing, auth/session state, persisted preferences, config loading, config/default additions, migrations, setup, startup checks, and fallback behavior are compatibility/upgrade-sensitive. Treat config breaks, new config/default surfaces, removed fallbacks, fail-closed changes, stricter validation, or new operator action as merge risk even with green CI when they can affect existing users, upgrades, provider/plugin behavior, or maintainer operations.Add a follow-up sentence:
Acceptance criteria
AGENTS.mdexplicitly says config/default additions can be compatibility/upgrade-sensitive merge risk.reviewMetricsentries that name the count and direction of config/default surface changes when known, such as “adds 2 config/default surfaces,” “changes 1 default,” or “removes 1 fallback/config surface.”risksand existing merge-risk fields where appropriate.## ClawSweeper Review Policy.Non-goals