fix(ci): stabilize deadcode and catalog checks

vincentkoc · vincentkoc · commit 3db1508f1ee7 · 2026-05-25T04:54:24.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,7 +9,7 @@ Docs: https://docs.openclaw.ai
 ### Fixes
 
 - Scripts: build CLI startup artifacts before the gateway CPU startup bench so fresh Linux runners do not report false `n/a` readiness and process metrics.
-- Scripts: remove stale Knip unused-file allowlist entries so the dead-code gate fails only on current findings.
+- Scripts: keep intentional Knip unused-file findings optional so full CI and sparse proof workspaces stay aligned.
 - Tests: normalize bundled plugin lifecycle probe paths and state-root lookup so native Windows release sweeps accept valid packaged plugin installs.
 - Config: keep benign legacy metadata write anomalies out of default doctor and config command output while preserving explicit anomaly logging for diagnostics.
 - Codex: log when implicit app-server `never` approvals are promoted for OpenClaw tool policy, including whether the trigger was a `before_tool_call` hook or trusted tool policy.
diff --git a/scripts/deadcode-unused-files.allowlist.mjs b/scripts/deadcode-unused-files.allowlist.mjs
@@ -4,9 +4,41 @@
 export const KNIP_UNUSED_FILE_ALLOWLIST = [];
 
 // Knip can disagree across supported local/CI platforms for files that are
-// only reachable through test-only import graphs. Ignore these when reported,
-// but do not require them to be reported.
+// only reachable through test-only import graphs, sparse-checkout proof
+// workspaces, dynamic entrypoints, manifest-discovered plugin surfaces, or
+// package bridge files. Ignore these when reported, but do not require them
+// to be reported.
 export const KNIP_OPTIONAL_UNUSED_FILE_ALLOWLIST = [
+  "extensions/acpx/src/runtime-internals/error-format.mjs",
+  "extensions/acpx/src/runtime-internals/mcp-command-line.mjs",
+  "extensions/acpx/src/runtime-internals/mcp-proxy.mjs",
+  "extensions/canvas/src/host/a2ui-app/bootstrap.js",
+  "extensions/canvas/src/host/a2ui-app/rolldown.config.mjs",
+  "extensions/diffs/src/viewer-client.ts",
+  "extensions/diffs/src/viewer-payload.ts",
+  "extensions/matrix/src/plugin-entry.runtime.js",
+  "extensions/memory-core/src/memory-tool-manager-mock.ts",
+  "src/agents/subagent-registry.runtime.ts",
+  "src/auto-reply/inbound.group-require-mention-test-plugins.ts",
+  "src/auto-reply/reply/get-reply.test-loader.ts",
+  "src/cli/daemon-cli-compat.ts",
+  "src/commands/doctor/shared/deprecation-compat.ts",
+  "src/config/doc-baseline.runtime.ts",
+  "src/config/doc-baseline.ts",
+  "src/gateway/gateway-cli-backend.live-helpers.ts",
+  "src/gateway/gateway-cli-backend.live-probe-helpers.ts",
+  "src/gateway/gateway-codex-harness.live-helpers.ts",
+  "src/infra/changelog-unreleased.ts",
+  "src/mcp/openclaw-tools-serve.ts",
+  "src/mcp/plugin-tools-handlers.ts",
+  "src/mcp/plugin-tools-serve.ts",
+  "src/mcp/tools-stdio-server.ts",
+  "src/plugins/build-smoke-entry.ts",
+  "src/plugins/contracts/host-hook-fixture.ts",
+  "src/plugins/contracts/rootdir-boundary-canary.ts",
+  "src/plugins/contracts/tts-contract-suites.ts",
+  "src/plugins/runtime-sidecar-paths-baseline.ts",
+  "src/tasks/task-registry-control.runtime.ts",
   "extensions/qa-lab/src/auth-profile.fixture.ts",
   "extensions/qa-lab/src/codex-plugin.fixture.ts",
   "src/gateway/test/server-sessions-helpers.ts",
diff --git a/src/agents/model-catalog-visibility.ts b/src/agents/model-catalog-visibility.ts
@@ -7,6 +7,18 @@ import { createModelVisibilityPolicy } from "./model-visibility-policy.js";
 type ModelCatalogVisibilityView = "default" | "configured" | "all";
 type ProviderAuthChecker = (provider: string) => boolean | Promise<boolean>;
 
+function isPromiseLike(value: boolean | Promise<boolean>): value is Promise<boolean> {
+  return typeof value === "object" && value !== null && typeof value.then === "function";
+}
+
+async function providerHasAuth(
+  providerAuthChecker: ProviderAuthChecker,
+  provider: string,
+): Promise<boolean> {
+  const result = providerAuthChecker(provider);
+  return isPromiseLike(result) ? await result : result;
+}
+
 function sortModelCatalogEntries(entries: ModelCatalogEntry[]): ModelCatalogEntry[] {
   return entries.toSorted(
     (a, b) => a.provider.localeCompare(b.provider) || a.id.localeCompare(b.id),
@@ -56,10 +68,10 @@ export async function resolveVisibleModelCatalog(params: {
         env: params.env,
         allowPluginSyntheticAuth: params.runtimeAuthDiscovery,
         discoverExternalCliAuth: params.runtimeAuthDiscovery,
-      });
+    });
     const authBackedCatalog: ModelCatalogEntry[] = [];
     for (const entry of params.catalog) {
-      if (await hasAuth(entry.provider)) {
+      if (await providerHasAuth(hasAuth, entry.provider)) {
         authBackedCatalog.push(entry);
       }
     }
