Skip to content

Unify thinking and fast run controls#79385

Merged
steipete merged 8 commits intoopenclaw:mainfrom
VACInc:tmp-chat-run-controls
May 9, 2026
Merged

Unify thinking and fast run controls#79385
steipete merged 8 commits intoopenclaw:mainfrom
VACInc:tmp-chat-run-controls

Conversation

@VACInc
Copy link
Copy Markdown
Contributor

@VACInc VACInc commented May 8, 2026

Summary

Verification

  • pnpm exec oxfmt --check --threads=1 $(git diff --name-only origin/main...HEAD)
  • pnpm test src/agents/simple-completion-runtime.test.ts src/cli/capability-cli.test.ts src/auto-reply/commands-registry.test.ts src/auto-reply/reply.directive.parse.test.ts src/auto-reply/reply/commands-session-usage.test.ts src/auto-reply/reply/directive-handling.model.test.ts src/auto-reply/status.test.ts extensions/voice-call/src/config.test.ts extensions/voice-call/src/runtime.test.ts src/gateway/server-methods/talk.test.ts src/talk/agent-consult-runtime.test.ts ui/src/ui/realtime-talk-consult.test.ts src/config/talk.normalize.test.ts src/config/zod-schema.talk.test.ts src/config/schema.help.quality.test.ts
  • pnpm build

@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation channel: voice-call Channel integration: voice-call app: web-ui App: web-ui gateway Gateway runtime cli CLI command changes agents Agent runtime and tooling labels May 8, 2026
@openclaw-barnacle openclaw-barnacle Bot added triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup. size: L labels May 8, 2026
@VACInc VACInc force-pushed the tmp-chat-run-controls branch from c63f94c to d9e9cdc Compare May 8, 2026 12:16
@clawsweeper
Copy link
Copy Markdown
Contributor

clawsweeper Bot commented May 8, 2026

Codex review: needs real behavior proof before merge.

Summary
The PR adds unified thinking and fast-mode controls across chat directives, infer model run, Talk/voice consult config, Gateway protocol models, docs, and tests.

Reproducibility: yes. for the review finding by source inspection: PR head resolves the one-shot thinking override, but the explicit-thinking guard excludes that override. I did not run tests or live flows under the read-only review constraint.

Real behavior proof
Needs real behavior proof before merge: The PR body only reports formatter, tests, and build; it needs redacted terminal output, logs, screenshots, recordings, or linked artifacts showing the changed behavior after the fix. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, ask a maintainer to comment @clawsweeper re-review.

Next step before merge
Needs contributor or maintainer follow-up for the P2 correctness fix plus real behavior proof; this is not a ClawSweeper repair-lane candidate while external PR proof is missing.

Security
Cleared: The diff adds config/protocol/runtime controls and docs/tests, with no dependency, CI, release, secret-handling, or third-party code-execution change found.

Review findings

  • [P2] Treat one-shot thinking off as explicit — src/auto-reply/reply/get-reply-directives.ts:543
Review details

Best possible solution:

Keep the unified PR open, make one-shot thinking: "off" count as an explicit thinking setting, add focused regression coverage, and attach redacted real behavior proof before merge.

Do we have a high-confidence way to reproduce the issue?

Yes for the review finding by source inspection: PR head resolves the one-shot thinking override, but the explicit-thinking guard excludes that override. I did not run tests or live flows under the read-only review constraint.

Is this the best way to solve the issue?

No, not yet. The unified surface is plausible, but the runtime override path must preserve /think off semantics and the PR needs real behavior proof before merge.

Full review comments:

  • [P2] Treat one-shot thinking off as explicit — src/auto-reply/reply/get-reply-directives.ts:543
    thinkingLevelOverride now feeds resolvedThinkLevel, but this explicitness check still ignores it. When chat.send, gateway model run --thinking off, or Talk consult config sends a one-shot off override with no session/agent thinking default, resolvedThinkLevelWithDefault becomes off, then the block below sees thinking as not explicit and can restore the model default reasoning level. Include the normalized override in thinkingExplicitlySet so one-shot off behaves like inline /think off.
    Confidence: 0.87

Overall correctness: patch is incorrect
Overall confidence: 0.82

What I checked:

Likely related people:

  • Peter Steinberger: Current-main blame for the central reply-directive, chat.send, CLI model-run, and voice-call consult paths points to commit 0071f67 in this checkout; the PR timeline also shows Peter/steipete force-pushed the finishing commit on this branch. (role: recent maintainer and adjacent owner; confidence: medium; commits: 0071f67fe6ea, 009b338b70fe; files: src/auto-reply/reply/get-reply-directives.ts, src/gateway/server-methods/chat.ts, src/cli/capability-cli.ts)

Remaining risk / open question:

  • The PR has no real behavior proof for the new CLI, Talk, or voice consult paths.
  • The correctness finding is source-derived; tests and live scenarios were not run because this was a read-only review.

Codex review notes: model gpt-5.5, reasoning high; reviewed against a855414bc665.

@steipete steipete force-pushed the tmp-chat-run-controls branch from d9e9cdc to 009b338 Compare May 9, 2026 10:14
steipete added a commit to VACInc/openclaw that referenced this pull request May 9, 2026
steipete added a commit to VACInc/openclaw that referenced this pull request May 9, 2026
@steipete steipete force-pushed the tmp-chat-run-controls branch from 009b338 to 4a9f3b6 Compare May 9, 2026 10:39
@steipete steipete requested a review from a team as a code owner May 9, 2026 10:39
@openclaw-barnacle openclaw-barnacle Bot added channel: imessage Channel integration: imessage channel: matrix Channel integration: matrix channel: whatsapp-web Channel integration: whatsapp-web channel: zalouser Channel integration: zalouser channel: feishu Channel integration: feishu channel: qa-channel Channel integration: qa-channel extensions: qa-lab size: XL and removed size: L labels May 9, 2026
@steipete steipete force-pushed the tmp-chat-run-controls branch from 4a9f3b6 to 525acfe Compare May 9, 2026 10:42
@openclaw-barnacle openclaw-barnacle Bot added size: L and removed channel: imessage Channel integration: imessage channel: whatsapp-web Channel integration: whatsapp-web channel: zalouser Channel integration: zalouser channel: feishu Channel integration: feishu channel: qa-channel Channel integration: qa-channel extensions: qa-lab size: XL labels May 9, 2026
@steipete steipete added the proof: override Maintainer override for the external PR real behavior proof gate. label May 9, 2026
@openclaw-barnacle openclaw-barnacle Bot removed the triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup. label May 9, 2026
@steipete steipete merged commit 242a716 into openclaw:main May 9, 2026
115 of 116 checks passed
@steipete
Copy link
Copy Markdown
Contributor

steipete commented May 9, 2026

Thanks @VACInc. Landed after rebasing onto current main and adding maintainer fixups for the default-clearing command path, generated Swift protocol drift, and the lint suppression allowlist.

Verification:

  • pnpm lint
  • pnpm check:test-types
  • pnpm protocol:check
  • git diff --check
  • pnpm test ui/src/ui/chat/slash-command-executor.node.test.ts src/auto-reply/reply.directive.directive-behavior.shows-current-verbose-level-verbose-has-no.test.ts src/agents/simple-completion-runtime.test.ts src/auto-reply/commands-registry.test.ts src/talk/agent-consult-runtime.test.ts extensions/voice-call/src/config.test.ts extensions/voice-call/src/runtime.test.ts src/config/talk.normalize.test.ts src/config/zod-schema.talk.test.ts src/gateway/server-methods/talk.test.ts ui/src/ui/realtime-talk-consult.test.ts src/cli/capability-cli.test.ts
  • pnpm test test/scripts/lint-suppressions.test.ts
  • GitHub CI green on 6f88949b3b3ccdd9b38e08256021ff25d92f7b0c

Merged as 242a71663adde2a44d43a03bffb43f8171b28305.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling app: web-ui App: web-ui channel: matrix Channel integration: matrix channel: voice-call Channel integration: voice-call cli CLI command changes docs Improvements or additions to documentation gateway Gateway runtime proof: override Maintainer override for the external PR real behavior proof gate. size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants