Unify thinking and fast run controls#79385
Conversation
c63f94c to
d9e9cdc
Compare
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. for the review finding by source inspection: PR head resolves the one-shot thinking override, but the explicit-thinking guard excludes that override. I did not run tests or live flows under the read-only review constraint. Real behavior proof Next step before merge Security Review findings
Review detailsBest possible solution: Keep the unified PR open, make one-shot Do we have a high-confidence way to reproduce the issue? Yes for the review finding by source inspection: PR head resolves the one-shot thinking override, but the explicit-thinking guard excludes that override. I did not run tests or live flows under the read-only review constraint. Is this the best way to solve the issue? No, not yet. The unified surface is plausible, but the runtime override path must preserve Full review comments:
Overall correctness: patch is incorrect What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against a855414bc665. |
d9e9cdc to
009b338
Compare
009b338 to
4a9f3b6
Compare
4a9f3b6 to
525acfe
Compare
|
Thanks @VACInc. Landed after rebasing onto current Verification:
Merged as |
Summary
openclaw infer model run --thinking, and/think default//fast defaultsession override clearing together.resolveReplyDirectivesprecedence explicitly: one-shot runtime overrides win first, inline directives next, then the session layer unless a default-clearing directive removes it.Verification
pnpm exec oxfmt --check --threads=1 $(git diff --name-only origin/main...HEAD)pnpm test src/agents/simple-completion-runtime.test.ts src/cli/capability-cli.test.ts src/auto-reply/commands-registry.test.ts src/auto-reply/reply.directive.parse.test.ts src/auto-reply/reply/commands-session-usage.test.ts src/auto-reply/reply/directive-handling.model.test.ts src/auto-reply/status.test.ts extensions/voice-call/src/config.test.ts extensions/voice-call/src/runtime.test.ts src/gateway/server-methods/talk.test.ts src/talk/agent-consult-runtime.test.ts ui/src/ui/realtime-talk-consult.test.ts src/config/talk.normalize.test.ts src/config/zod-schema.talk.test.ts src/config/schema.help.quality.test.tspnpm build