Add realtime consult thinking and fast mode overrides by VACInc · Pull Request #72237 · openclaw/openclaw

VACInc · 2026-04-26T15:22:19Z

Summary

Adds realtime.consultThinkingLevel and realtime.consultFastMode to the Voice Call plugin config and manifest schema.
Adds talk.consultThinkingLevel and talk.consultFastMode for Control UI Talk realtime consults.
Uses those values for the full OpenClaw agent run behind realtime openclaw_agent_consult calls when set.
Documents the options and covers parsing/runtime/UI handoff with tests.

Behavior

Unset configs keep existing behavior. Voice Call keeps resolving the consult thinking level from the selected response model default and leaves fast mode unset. Control UI Talk realtime omits the one-shot chat.send overrides unless the new Talk consult config is set.

Validation

pnpm test extensions/voice-call/src/config.test.ts extensions/voice-call/src/runtime.test.ts src/realtime-voice/agent-consult-runtime.test.ts
pnpm test src/config/zod-schema.talk.test.ts src/config/talk.normalize.test.ts src/config/schema.help.quality.test.ts src/gateway/server-methods/talk.test.ts ui/src/ui/chat/realtime-talk.test.ts src/gateway/protocol/index.test.ts
pnpm check:base-config-schema
pnpm config:docs:check
pnpm tsgo:core
pnpm tsgo:core:test
git diff --check

Note: a broader pnpm check:changed rerun hit unrelated e2e failures after the focused lanes above passed; the earlier run also hit a Vitest worker heap limit.

greptile-apps · 2026-04-26T16:42:41Z

Greptile Summary

This PR adds optional consultThinkingLevel and consultFastMode overrides to both the Voice Call plugin and the Control UI Talk realtime path, threading them through config normalization, schema validation, the session handshake response, and the chat.send one-shot override mechanism. Unset configs preserve existing behavior in both paths.

Confidence Score: 5/5

Safe to merge — changes are additive, backward-compatible, and covered by targeted tests.

No logic errors, data loss, or security issues found. Both override paths (Voice Call plugin and Control UI Talk) are independently tested. Schema validation is consistent between Zod, Typebox, and the generated JSON schema. The fastModeOverride/thinkingLevelOverride priority insertion in get-reply-directives.ts is correct and one-shot (not persisted). All edge cases (unset values, false booleans, 'off' think level) are handled correctly.

No files require special attention.

_{Reviews (1): Last reviewed commit: "add talk realtime consult overrides" | Re-trigger Greptile}

VACInc · 2026-04-26T16:56:11Z

Tested and verified. Running live in my production env

clawsweeper · 2026-04-26T17:32:14Z

Codex review: needs real behavior proof before merge.

Summary
This PR adds optional Voice Call realtime and Control UI Talk consult thinking-level and fast-mode overrides across config schemas, runtime handoff, protocol/UI types, docs, and tests.

Reproducibility: yes. for the missing capability: current-main source shows Voice Call, Talk tool-call, chat.send, and protocol paths do not carry these consult override values. This is source-reproducible feature absence rather than a failing runtime bug.

Real behavior proof
Needs real behavior proof before merge: The PR has a production-live claim, but no inspectable terminal output, logs, screenshot, recording, or artifact showing the after-fix override path working. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, ask a maintainer to comment @clawsweeper re-review.

Next step before merge
Contributor action is needed for inspectable real behavior proof before a maintainer considers merge or automation repair.

Security
Cleared: Cleared: the diff adds no dependencies, workflows, scripts, package metadata, downloaded code, secret handling changes, or broader permissions.

Review findings

[P3] Move the Talk overrides out of the defaults example — docs/gateway/config-agents.md:1384-1385
[P3] Add the required changelog entry — docs/plugins/voice-call.md:319-320

Review details

Best possible solution:

Land the additive one-shot override path after moving optional Talk values out of the defaults example, adding a single-line changelog entry, and supplying inspectable live proof.

Do we have a high-confidence way to reproduce the issue?

Yes for the missing capability: current-main source shows Voice Call, Talk tool-call, chat.send, and protocol paths do not carry these consult override values. This is source-reproducible feature absence rather than a failing runtime bug.

Is this the best way to solve the issue?

Yes for the feature direction: optional config plus one-shot runtime handoff is narrower than changing persistent session defaults. It is not merge-ready until proof, docs-defaults, and changelog issues are handled.

Full review comments:

[P3] Move the Talk overrides out of the defaults example — docs/gateway/config-agents.md:1384-1385
These optional values are added inside the section labeled Defaults for Talk mode, but the implementation and PR body say unset config preserves existing behavior. Put them in an optional override example or relabel the snippet.
Confidence: 0.86
[P3] Add the required changelog entry — docs/plugins/voice-call.md:319-320
This adds user-facing Voice Call and Talk config behavior, so repo policy requires a single-line Unreleased CHANGELOG.md entry. The latest diff still has no CHANGELOG.md change.
Confidence: 0.9

Overall correctness: patch is correct
Overall confidence: 0.87

What I checked:

Current main lacks Voice Call config fields: VoiceCallRealtimeConfigSchema defines enabled/provider/streamPath/instructions/toolPolicy/consultPolicy/tools/fastContext/agentContext/providers, with no consultThinkingLevel or consultFastMode fields. (extensions/voice-call/src/config.ts:294, 2daf3d332ff0)
Current main lacks Voice Call runtime handoff: The realtime consult handler resolves thinkLevel from agentRuntime.resolveThinkingDefault and calls consultRealtimeVoiceAgent without a fastMode parameter. (extensions/voice-call/src/runtime.ts:381, 2daf3d332ff0)
Current main lacks Talk consult override handoff: talk.client.toolCall currently calls chat.send with sessionKey, message, and idempotencyKey only. (src/gateway/server-methods/talk-client.ts:49, 2daf3d332ff0)
Current main protocol lacks the new fields: ChatSendParamsSchema has thinking but no fastMode, and TalkConfigSchema has speechLocale/interruptOnSpeech/silenceTimeoutMs but no consult override fields. (src/gateway/protocol/schema/logs-chat.ts:35, 2daf3d332ff0)
Latest PR head adds the intended path: The latest diff adds Voice Call and Talk consult config fields, passes Voice Call consultThinkingLevel/consultFastMode into consultRealtimeVoiceAgent, and forwards Talk config overrides through chat.send one-shot reply options. (extensions/voice-call/src/runtime.ts:378, e33753fdf8f1)
Docs defaults finding remains: The latest diff inserts consultThinkingLevel and consultFastMode inside the section labeled Defaults for Talk mode, while the PR body and implementation say unset config preserves existing behavior. Public docs: docs/gateway/config-agents.md. (docs/gateway/config-agents.md:1384, e33753fdf8f1)

Likely related people:

steipete: Recent GitHub history shows work on fast Voice Call realtime context, unified Talk session runtime, browser realtime Talk transports, and unified Talk docs that this PR extends. (role: recent maintainer and feature-history owner; confidence: high; commits: ef186a06d9f1, f1636d5e2831, 93bbbe5e3732; files: extensions/voice-call/src/runtime.ts, extensions/voice-call/src/config.ts, src/gateway/server-methods/talk-client.ts)
scoootscooob: Recent commits touched Voice Call realtime/Meet voice agent behavior and docs in the same live voice-call latency area. (role: recent adjacent Voice Call realtime maintainer; confidence: medium; commits: 79dd65e20889, 7fc9a82dca2f; files: extensions/voice-call/src/runtime.ts, extensions/voice-call/src/config.ts, docs/plugins/voice-call.md)
VACInc: Although also the PR author, prior merged history includes Google Live consult response handling and Voice Call SecretRef input fixes in the affected plugin area. (role: recent adjacent contributor; confidence: medium; commits: 614a2846a257, be14820b5d64; files: extensions/voice-call/src/runtime.ts, extensions/voice-call/src/config.ts)

Remaining risk / open question:

No inspectable live proof yet shows the new overrides affecting a real realtime consult after the fix.
The PR body reports focused validation only and notes broader changed-gate/e2e failures, so merge should still depend on exact current-head CI or maintainer rerun proof.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 2daf3d332ff0.

VACInc · 2026-05-08T12:13:58Z

Closing as superseded by #79385, which combines #72237, #73642, and #79351 into one run-control PR so oc-update applies the surface as a single overlay without PR-to-PR conflicts.

Canonical replacement: #79385

steipete · 2026-05-09T10:52:29Z

Closing as superseded by #79385, which landed the combined realtime consult run-control surface and follow-up maintainer fixes on main.

openclaw-barnacle Bot added docs Improvements or additions to documentation channel: voice-call Channel integration: voice-call size: S labels Apr 26, 2026

VACInc changed the title ~~Add voice consult thinking override~~ Add voice consult thinking and fast mode overrides Apr 26, 2026

openclaw-barnacle Bot added app: web-ui App: web-ui gateway Gateway runtime size: M and removed size: S labels Apr 26, 2026

VACInc changed the title ~~Add voice consult thinking and fast mode overrides~~ Add realtime consult thinking and fast mode overrides Apr 26, 2026

VACInc marked this pull request as ready for review April 26, 2026 16:40

VACInc force-pushed the voice-call-consult-thinking branch 9 times, most recently from d7ccfc6 to 5842758 Compare April 28, 2026 09:42

clawsweeper Bot mentioned this pull request Apr 29, 2026

Realtime voice consult is too slow/fragile for live calls; add fast memory context path #71849

Closed

VACInc force-pushed the voice-call-consult-thinking branch 4 times, most recently from 008f33e to ebc77cd Compare May 6, 2026 10:46

openclaw-barnacle Bot added the triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup. label May 6, 2026

feat: add realtime consult overrides

e33753f

VACInc force-pushed the voice-call-consult-thinking branch from ebc77cd to e33753f Compare May 6, 2026 17:55

VACInc mentioned this pull request May 8, 2026

Unify thinking and fast run controls #79385

Merged

VACInc closed this May 8, 2026

This was referenced May 8, 2026

feat(cli): add thinking override to infer model run #73642

Closed

Allow chat commands to clear thinking and fast defaults #79351

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add realtime consult thinking and fast mode overrides#72237

Add realtime consult thinking and fast mode overrides#72237
VACInc wants to merge 1 commit intoopenclaw:mainfrom
VACInc:voice-call-consult-thinking

VACInc commented Apr 26, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Apr 26, 2026

Uh oh!

VACInc commented Apr 26, 2026

Uh oh!

clawsweeper Bot commented Apr 26, 2026 •

edited

Loading

Uh oh!

VACInc commented May 8, 2026

Uh oh!

steipete commented May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

VACInc commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Behavior

Validation

Uh oh!

greptile-apps Bot commented Apr 26, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

VACInc commented Apr 26, 2026

Uh oh!

clawsweeper Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VACInc commented May 8, 2026

Uh oh!

steipete commented May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

VACInc commented Apr 26, 2026 •

edited

Loading

clawsweeper Bot commented Apr 26, 2026 •

edited

Loading