Allow chat commands to clear thinking and fast defaults#79351
Allow chat commands to clear thinking and fast defaults#79351VACInc wants to merge 1 commit intoopenclaw:mainfrom
Conversation
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: not applicable. This PR adds a new chat-command capability rather than reporting a bug. The current merge blocker is independently reproducible from CI annotations for Real behavior proof Next step before merge Security Review findings
Review detailsBest possible solution: Keep the PR open, update the stale fast-status test expectations, add real chat-command behavior proof, and then let maintainers decide whether to accept the new Do we have a high-confidence way to reproduce the issue? Not applicable; this PR adds a new chat-command capability rather than reporting a bug. The current merge blocker is independently reproducible from CI annotations for Is this the best way to solve the issue? Unclear; the implementation follows the existing parser/session architecture, but the user-facing command semantics still need maintainer acceptance and the branch is not merge-ready until proof and stale tests are fixed. Full review comments:
Overall correctness: patch is incorrect What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against fecddcabd7a9. |
Summary:
default/inherit-style session clear support for/thinkand/fast, so chat users can remove pinned thinking and fast-mode overrides without setting explicit off.defaultin native command choices,/help, and docs./fastcommand handling, registry choices, and help text.Verification:
pnpm docs:listpnpm test src/auto-reply/reply.directive.parse.test.ts src/auto-reply/reply/directive-handling.model.test.ts src/auto-reply/reply/commands-session-usage.test.ts src/auto-reply/commands-registry.test.ts src/auto-reply/status.test.tsOPENCLAW_LOCAL_CHECK=1 pnpm check:changedgit diff --check