fix(telegram): skip empty text replies instead of crashing with GrammyError 400#56620
Merged
hydro13 merged 1 commit intoopenclaw:mainfrom Mar 28, 2026
Merged
Conversation
…yError 400 Filter whitespace-only text chunks at the bot delivery fan-in before they reach sendTelegramText(). Covers normal text replies, follow-up text, and voice fallback text paths. Media-only replies are unaffected. message_sent hook still fires with success: false for suppressed empty replies. Fixes openclaw#37278
Contributor
Greptile SummaryThis PR fixes a GrammyError 400 crash caused by whitespace-only text payloads reaching Confidence Score: 5/5Safe to merge — the fix is minimal, correctly targets all three text delivery paths, and is covered by regression tests. No P0 or P1 issues found. The helper function is well-typed and applied consistently. Empty-chunk handling in sendChunkedTelegramReplyText is already correct (the for-loop simply doesn't execute). Tests cover both the hook-blanking and the whitespace-only input scenarios. No files require special attention.
|
| Filename | Overview |
|---|---|
| extensions/telegram/src/bot/delivery.replies.ts | Adds filterEmptyTelegramTextChunks() and applies it to all three text delivery paths; implementation is correct and consistent. |
| extensions/telegram/src/bot/delivery.test.ts | Updates hook-blanking test to use whitespace content and converts previously-throwing empty-text test to a resolves assertion, accurately covering the new behavior. |
Reviews (1): Last reviewed commit: "fix(telegram): skip empty text replies i..." | Re-trigger Greptile
hydro13
added a commit
to hydro13/openclaw
that referenced
this pull request
Mar 28, 2026
Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.
alexcode-cc
pushed a commit
to alexcode-cc/clawdbot
that referenced
this pull request
Mar 30, 2026
…yError 400 (openclaw#56620) Filter whitespace-only text chunks at the bot delivery fan-in before they reach sendTelegramText(). Covers normal text replies, follow-up text, and voice fallback text paths. Media-only replies are unaffected. message_sent hook still fires with success: false for suppressed empty replies. Fixes openclaw#37278
alexcode-cc
pushed a commit
to alexcode-cc/clawdbot
that referenced
this pull request
Mar 30, 2026
Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.
alexjiang1
pushed a commit
to alexjiang1/openclaw
that referenced
this pull request
Mar 31, 2026
…yError 400 (openclaw#56620) Filter whitespace-only text chunks at the bot delivery fan-in before they reach sendTelegramText(). Covers normal text replies, follow-up text, and voice fallback text paths. Media-only replies are unaffected. message_sent hook still fires with success: false for suppressed empty replies. Fixes openclaw#37278
alexjiang1
pushed a commit
to alexjiang1/openclaw
that referenced
this pull request
Mar 31, 2026
Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.
pgondhi987
pushed a commit
to pgondhi987/openclaw
that referenced
this pull request
Mar 31, 2026
…yError 400 (openclaw#56620) Filter whitespace-only text chunks at the bot delivery fan-in before they reach sendTelegramText(). Covers normal text replies, follow-up text, and voice fallback text paths. Media-only replies are unaffected. message_sent hook still fires with success: false for suppressed empty replies. Fixes openclaw#37278
pgondhi987
pushed a commit
to pgondhi987/openclaw
that referenced
this pull request
Mar 31, 2026
Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
…yError 400 (openclaw#56620) Filter whitespace-only text chunks at the bot delivery fan-in before they reach sendTelegramText(). Covers normal text replies, follow-up text, and voice fallback text paths. Media-only replies are unaffected. message_sent hook still fires with success: false for suppressed empty replies. Fixes openclaw#37278
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.
Tardisyuan
pushed a commit
to Tardisyuan/openclaw
that referenced
this pull request
Apr 30, 2026
…yError 400 (openclaw#56620) Filter whitespace-only text chunks at the bot delivery fan-in before they reach sendTelegramText(). Covers normal text replies, follow-up text, and voice fallback text paths. Media-only replies are unaffected. message_sent hook still fires with success: false for suppressed empty replies. Fixes openclaw#37278
Tardisyuan
pushed a commit
to Tardisyuan/openclaw
that referenced
this pull request
Apr 30, 2026
Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
…yError 400 (openclaw#56620) Filter whitespace-only text chunks at the bot delivery fan-in before they reach sendTelegramText(). Covers normal text replies, follow-up text, and voice fallback text paths. Media-only replies are unaffected. message_sent hook still fires with success: false for suppressed empty replies. Fixes openclaw#37278
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
…yError 400 (openclaw#56620) Filter whitespace-only text chunks at the bot delivery fan-in before they reach sendTelegramText(). Covers normal text replies, follow-up text, and voice fallback text paths. Media-only replies are unaffected. message_sent hook still fires with success: false for suppressed empty replies. Fixes openclaw#37278
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendTelegramText()message_senthook still fires withsuccess: falsefor suppressed empty repliesRoot Cause
deliverReplies()inextensions/telegram/src/bot/delivery.replies.tschecked!reply?.text(falsy) but not semantic emptiness. Whitespace-only or hook-blanked replies passed the check and reachedsendTelegramText()→bot.api.sendMessage()→ GrammyError 400: message text is empty.The direct outbound path (
send.ts) and draft preview path already had empty guards. Only bot delivery was missing them.Change Type
Testing
1104 tests pass across 76 Telegram test files. Updated regression tests:
success: falseFixes #37278