fix(bluebubbles): guard debounce flush against null text by hydro13 · Pull Request #56573 · openclaw/openclaw

hydro13 · 2026-03-28T19:10:22Z

Summary

Sanitize message text at debounce enqueue boundary — coerce null/undefined to empty string
Add independent guard in combineDebounceEntries() for entries already queued
Prevents TypeError: Cannot read properties of null (reading 'trim') during debounce flush

Root Cause

combineDebounceEntries() in extensions/bluebubbles/src/monitor-debounce.ts:67 calls entry.message.text.trim() without null guard. When a webhook delivers a message with null text (e.g. tapback/reaction-only), the multi-entry flush path crashes.

Change Type

Bug fix

Testing

18 test suites, 363 tests pass. New regression test:

Enqueue null-text entry + valid entry with same messageId
Advance timers to force flush
Verify no error thrown
Verify valid message is delivered to processMessage

Fixes #35777

Sanitize message text at the debounce enqueue boundary and add an independent guard in combineDebounceEntries(). Prevents TypeError when a queued entry has null text that reaches .trim() during flush. Add regression test: enqueue null-text entry alongside valid message, verify flush completes without error and valid message is delivered. Fixes openclaw#35777

greptile-apps · 2026-03-28T19:12:15Z

Greptile Summary

This PR fixes a TypeError: Cannot read properties of null (reading 'trim') crash in monitor-debounce.ts that occurred when BlueBubbles delivered a webhook message with null text (e.g., a tapback/reaction-only message) and that null-text entry ended up in the multi-entry combineDebounceEntries() flush path.

Changes:

Adds normalizeDebounceMessageText(text: unknown): string — a small helper that coerces any non-string to "", used as a guard inside combineDebounceEntries() before calling .trim().
Adds sanitizeDebounceEntry() — normalizes message.text to "" at the enqueue boundary, so entries stored in the debounce bucket are always well-formed before they can be flushed.
Wraps the raw baseDebouncer in a thin debouncer shim that calls sanitizeDebounceEntry on every enqueue, providing defence-in-depth.
Extracts the inline timing-aware debouncer test double into a reusable installTimingAwareInboundDebouncer helper, cleaning up a large block of duplicated test setup.
Adds a focused regression test that enqueues a null-text entry followed by a valid entry sharing the same messageId, advances fake timers to force a multi-entry flush, and asserts the valid text is delivered without error.

Confidence Score: 5/5

This PR is safe to merge — the fix is targeted, the defence-in-depth layering is sound, and the new regression test directly covers the crash path.

Both the enqueue-time sanitization and the in-loop guard in combineDebounceEntries are correct and do not change behaviour for well-formed messages. The null-text entry is quietly dropped from the combined text (matching the existing empty-string filter), while valid co-batched entries are still delivered. The regression test exercises the exact multi-entry flush path that was crashing. No P0 or P1 findings were identified.

No files require special attention.

Important Files Changed

Filename	Overview
extensions/bluebubbles/src/monitor-debounce.ts	Adds null-text sanitization at enqueue boundary and a normalizer guard inside combineDebounceEntries; wraps baseDebouncer in a thin shim — all changes are correct and non-breaking.
extensions/bluebubbles/src/monitor.test.ts	Extracts reusable debouncer test-double helper and adds a targeted regression test covering the null-text multi-entry flush crash path.

_{Reviews (1): Last reviewed commit: "fix(bluebubbles): guard debounce flush a..." | Re-trigger Greptile}

Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.

Add missing changelog entries for PRs #56500, #56540, #56555, #56567, #56573, #56587, #56595, #56612, #56620.

) Sanitize message text at the debounce enqueue boundary and add an independent guard in combineDebounceEntries(). Prevents TypeError when a queued entry has null text that reaches .trim() during flush. Add regression test: enqueue null-text entry alongside valid message, verify flush completes without error and valid message is delivered. Fixes openclaw#35777

Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.

) Sanitize message text at the debounce enqueue boundary and add an independent guard in combineDebounceEntries(). Prevents TypeError when a queued entry has null text that reaches .trim() during flush. Add regression test: enqueue null-text entry alongside valid message, verify flush completes without error and valid message is delivered. Fixes openclaw#35777

Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.

) Sanitize message text at the debounce enqueue boundary and add an independent guard in combineDebounceEntries(). Prevents TypeError when a queued entry has null text that reaches .trim() during flush. Add regression test: enqueue null-text entry alongside valid message, verify flush completes without error and valid message is delivered. Fixes openclaw#35777

Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.

) Sanitize message text at the debounce enqueue boundary and add an independent guard in combineDebounceEntries(). Prevents TypeError when a queued entry has null text that reaches .trim() during flush. Add regression test: enqueue null-text entry alongside valid message, verify flush completes without error and valid message is delivered. Fixes openclaw#35777

Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.

) Sanitize message text at the debounce enqueue boundary and add an independent guard in combineDebounceEntries(). Prevents TypeError when a queued entry has null text that reaches .trim() during flush. Add regression test: enqueue null-text entry alongside valid message, verify flush completes without error and valid message is delivered. Fixes openclaw#35777

Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.

) Sanitize message text at the debounce enqueue boundary and add an independent guard in combineDebounceEntries(). Prevents TypeError when a queued entry has null text that reaches .trim() during flush. Add regression test: enqueue null-text entry alongside valid message, verify flush completes without error and valid message is delivered. Fixes openclaw#35777

Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.

) Sanitize message text at the debounce enqueue boundary and add an independent guard in combineDebounceEntries(). Prevents TypeError when a queued entry has null text that reaches .trim() during flush. Add regression test: enqueue null-text entry alongside valid message, verify flush completes without error and valid message is delivered. Fixes openclaw#35777

Add missing changelog entries for PRs openclaw#56500, openclaw#56540, openclaw#56555, openclaw#56567, openclaw#56573, openclaw#56587, openclaw#56595, openclaw#56612, openclaw#56620.

openclaw-barnacle Bot added channel: bluebubbles Channel integration: bluebubbles size: M maintainer Maintainer-authored PR labels Mar 28, 2026

hydro13 merged commit e69ea1a into openclaw:main Mar 28, 2026
36 of 38 checks passed

github-actions Bot mentioned this pull request Mar 28, 2026

📡 Upstream Digest — 2026-03-28 20:21 UTC curtismercier/openclaw-mods#394

Open

hydro13 mentioned this pull request Mar 28, 2026

chore: backfill changelog entries for recent fixes #56625

Merged

hydro13 added a commit that referenced this pull request Mar 28, 2026

chore: backfill changelog entries for recent fixes (#56625)

2022dfd

Add missing changelog entries for PRs #56500, #56540, #56555, #56567, #56573, #56587, #56595, #56612, #56620.

This was referenced Apr 19, 2026

fix(bluebubbles): handle null text in debounce flush (clean) #41915

Closed

fix(bluebubbles): handle null text in debounce flush #35840

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(bluebubbles): guard debounce flush against null text#56573

fix(bluebubbles): guard debounce flush against null text#56573
hydro13 merged 1 commit intoopenclaw:mainfrom
hydro13:fix/bluebubbles-null-text-crash

hydro13 commented Mar 28, 2026

Uh oh!

greptile-apps Bot commented Mar 28, 2026

Important Files Changed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

hydro13 commented Mar 28, 2026

Summary

Root Cause

Change Type

Testing

Uh oh!

greptile-apps Bot commented Mar 28, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant