fix(browser): resolve correct targetId in navigate response after renderer swap by stone-jin · Pull Request #25326 · openclaw/openclaw

stone-jin · 2026-02-24T11:13:46Z

Summary

The /navigate route returns a stale targetId after a Chrome renderer-process swap (e.g. navigating from chrome-extension:// to https://). This happens because tab.targetId is captured from ensureTabAvailable before navigateViaPlaywright, and the response returns it unchanged even though the underlying target has been replaced.

Changes

After navigateViaPlaywright completes, re-resolve the current tab by matching the final URL against profileCtx.listTabs():

If a tab with the navigated URL is found, use its targetId.
If the old targetId is no longer in the tab list (renderer swap occurred, extension re-attaching), wait 800ms and retry.
Fall back to the pre-navigation targetId if resolution fails.

This is a follow-up to #19744 (67bac62c2) which fixed the extension-side stale session cleanup by sending Target.detachedFromTarget before re-attaching.

Test plan

Verified: navigate from chrome-extension:// settings page to HTTPS returns correct new targetId
Verified: subsequent browser act executes on the navigated page, not the extension page
Regression check: normal HTTPS → HTTPS navigation unaffected

Greptile Summary

Fixes a stale targetId returned by the /navigate route after Chrome renderer-process swaps (e.g., navigating from chrome-extension:// to https://). After navigateViaPlaywright completes, the code now re-resolves the active tab by matching the final URL against the current tab list, with an 800ms retry if the old target has disappeared, and a graceful fallback to the pre-navigation targetId.

Best-effort tab re-resolution via URL matching handles the renderer-swap scenario described in [Bug]: /navigate route returns stale targetId after renderer-process swap (e.g. chrome-extension:// → https://) #25323
Fallback chain (URL match → retry after 800ms → original targetId) ensures the response always returns a usable targetId
When multiple tabs share the same URL, find() returns the first match which could be a different tab — consider narrowing the match in multi-tab scenarios

Confidence Score: 4/5

This PR is safe to merge with low risk — the new logic is best-effort with a clean fallback to the previous behavior.
The change is narrowly scoped to the /navigate route response, wrapped in a try/catch that falls back to the original behavior on any failure. The logic is straightforward and addresses a real bug. One minor concern is the URL-based matching when multiple tabs share the same URL, but this is unlikely to cause worse behavior than the current stale targetId bug.
No files require special attention beyond the single changed file src/browser/routes/agent.snapshot.ts.

_{Last reviewed commit: 22a233b}

_{(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!}

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

src/browser/routes/agent.snapshot.ts

…derer swap When `navigateViaPlaywright` triggers a Chrome renderer-process swap (e.g. navigating from chrome-extension:// to https://), the old `tab.targetId` captured before navigation becomes stale. The `/navigate` route previously returned this stale targetId in its response. After navigation, re-resolve the current tab by matching against the final URL via `profileCtx.listTabs()`. If the old target is already gone but the new one is not yet visible (extension re-attach in progress), retry after 800ms. Follow-up to openclaw#19744 (67bac62) which fixed the extension-side stale session cleanup.

…same URL When multiple tabs have the same URL after navigation, find() could pick a pre-existing tab instead of the newly created one. Now only re-resolve when the old target is gone (renderer swap detected), and prefer the tab whose targetId differs from the old one.

Introduced a new function `resolveTargetIdAfterNavigate` to handle the resolution of the correct targetId after a navigation event that may trigger a renderer swap. This refactor improves code clarity and reuses the logic for determining the current targetId, ensuring that the correct tab is identified even when multiple tabs share the same URL.

…ests Updated the initialization of listTabs in the agent snapshot tests for better readability by removing unnecessary line breaks. This change enhances code clarity without altering the test logic.

…tion

Co-authored-by: Cursor <cursoragent@cursor.com>

vincentkoc · 2026-02-28T17:19:35Z

Deep review + rebase pass complete on a maintained branch with two focused follow-up commits:

b33d8b8 fix(browser): avoid ambiguous target selection after renderer swap
aa66c9b test(browser): cover ambiguous same-url target resolution

What changed:

keeps /navigate from arbitrarily picking a target when multiple tabs share the same post-nav URL.
retries once and only updates targetId when resolution is unambiguous.
preserves existing single-tab fallback for relay re-attach delay.

Validation run:

pnpm exec vitest run src/browser/routes/agent.snapshot.test.ts
pnpm exec vitest run src/browser/server.agent-contract-snapshot-endpoints.test.ts
pnpm check

If helpful, these commits can be cherry-picked onto this PR branch for final merge.

@Lukavyi

* main: (31 commits) fix(browser): resolve correct targetId in navigate response after renderer swap (openclaw#25326) fix: sed escaping and UID mismatch in Podman Quadlet setup (openclaw#26414) fix(cron): pass heartbeat target=last for main-session cron jobs (openclaw#28508) (openclaw#28583) fix(cron): disable messaging tool when delivery.mode is none (openclaw#21808) (openclaw#21896) fix: clear delivery routing state when creating isolated cron sessions (openclaw#27778) fix(cron): avoid marking queued announce paths as delivered (openclaw#29716) fix(cron): enable completion direct send for text-only announce delivery (openclaw#29151) fix(cron): force main-target system events onto main session (openclaw#28898) fix(cron): condition requireExplicitMessageTarget on resolved delivery (openclaw#28017) feat(cron): add --account flag for multi-account delivery routing (openclaw#26284) fix: schedule nextWakeAtMs for isolated sessionTarget cron jobs (openclaw#19541) fix: sandbox browser docker no-sandbox rollout (openclaw#29879) (thanks @Lukavyi) GitHub: add regression bug issue template and routing (openclaw#29864) thanks @Takhoffman feat(feishu): add chat info/member tool (openclaw#14674) feat(feishu): add markdown tables, positional insert, color_text, and table ops (openclaw#29411) feat(feishu): add parent/root inbound context for quote support (openclaw#18529) fix: land android onboarding and voice reliability updates (openclaw#29796) fix(android-voice): rotate playback token per assistant reply fix(android-voice): retry talk config after transient failures fix(android-voice): cancel in-flight speech when speaker muted ...

…derer swap (openclaw#25326) * fix(browser): resolve correct targetId in navigate response after renderer swap When `navigateViaPlaywright` triggers a Chrome renderer-process swap (e.g. navigating from chrome-extension:// to https://), the old `tab.targetId` captured before navigation becomes stale. The `/navigate` route previously returned this stale targetId in its response. After navigation, re-resolve the current tab by matching against the final URL via `profileCtx.listTabs()`. If the old target is already gone but the new one is not yet visible (extension re-attach in progress), retry after 800ms. Follow-up to openclaw#19744 (67bac62) which fixed the extension-side stale session cleanup. * fix(browser): prefer non-stale targetId when multiple tabs share the same URL When multiple tabs have the same URL after navigation, find() could pick a pre-existing tab instead of the newly created one. Now only re-resolve when the old target is gone (renderer swap detected), and prefer the tab whose targetId differs from the old one. * fix(browser): encapsulate targetId resolution logic after navigation Introduced a new function `resolveTargetIdAfterNavigate` to handle the resolution of the correct targetId after a navigation event that may trigger a renderer swap. This refactor improves code clarity and reuses the logic for determining the current targetId, ensuring that the correct tab is identified even when multiple tabs share the same URL. * refactor(tests): simplify listTabs initialization in agent snapshot tests Updated the initialization of listTabs in the agent snapshot tests for better readability by removing unnecessary line breaks. This change enhances code clarity without altering the test logic. * fix(ui): widen Set type to accept string tokens in external-link helper * chore: retrigger CI (unrelated Windows flaky test) Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>

(cherry picked from commit db25b26)

…derer swap (openclaw#25326) * fix(browser): resolve correct targetId in navigate response after renderer swap When `navigateViaPlaywright` triggers a Chrome renderer-process swap (e.g. navigating from chrome-extension:// to https://), the old `tab.targetId` captured before navigation becomes stale. The `/navigate` route previously returned this stale targetId in its response. After navigation, re-resolve the current tab by matching against the final URL via `profileCtx.listTabs()`. If the old target is already gone but the new one is not yet visible (extension re-attach in progress), retry after 800ms. Follow-up to openclaw#19744 (67bac62) which fixed the extension-side stale session cleanup. * fix(browser): prefer non-stale targetId when multiple tabs share the same URL When multiple tabs have the same URL after navigation, find() could pick a pre-existing tab instead of the newly created one. Now only re-resolve when the old target is gone (renderer swap detected), and prefer the tab whose targetId differs from the old one. * fix(browser): encapsulate targetId resolution logic after navigation Introduced a new function `resolveTargetIdAfterNavigate` to handle the resolution of the correct targetId after a navigation event that may trigger a renderer swap. This refactor improves code clarity and reuses the logic for determining the current targetId, ensuring that the correct tab is identified even when multiple tabs share the same URL. * refactor(tests): simplify listTabs initialization in agent snapshot tests Updated the initialization of listTabs in the agent snapshot tests for better readability by removing unnecessary line breaks. This change enhances code clarity without altering the test logic. * fix(ui): widen Set type to accept string tokens in external-link helper * chore: retrigger CI (unrelated Windows flaky test) Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>

(cherry picked from commit db25b26)

…derer swap (openclaw#25326) * fix(browser): resolve correct targetId in navigate response after renderer swap When `navigateViaPlaywright` triggers a Chrome renderer-process swap (e.g. navigating from chrome-extension:// to https://), the old `tab.targetId` captured before navigation becomes stale. The `/navigate` route previously returned this stale targetId in its response. After navigation, re-resolve the current tab by matching against the final URL via `profileCtx.listTabs()`. If the old target is already gone but the new one is not yet visible (extension re-attach in progress), retry after 800ms. Follow-up to openclaw#19744 (67bac62) which fixed the extension-side stale session cleanup. * fix(browser): prefer non-stale targetId when multiple tabs share the same URL When multiple tabs have the same URL after navigation, find() could pick a pre-existing tab instead of the newly created one. Now only re-resolve when the old target is gone (renderer swap detected), and prefer the tab whose targetId differs from the old one. * fix(browser): encapsulate targetId resolution logic after navigation Introduced a new function `resolveTargetIdAfterNavigate` to handle the resolution of the correct targetId after a navigation event that may trigger a renderer swap. This refactor improves code clarity and reuses the logic for determining the current targetId, ensuring that the correct tab is identified even when multiple tabs share the same URL. * refactor(tests): simplify listTabs initialization in agent snapshot tests Updated the initialization of listTabs in the agent snapshot tests for better readability by removing unnecessary line breaks. This change enhances code clarity without altering the test logic. * fix(ui): widen Set type to accept string tokens in external-link helper * chore: retrigger CI (unrelated Windows flaky test) Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>

openclaw-barnacle bot added the size: XS label Feb 24, 2026

greptile-apps bot reviewed Feb 24, 2026

View reviewed changes

src/browser/routes/agent.snapshot.ts Outdated Show resolved Hide resolved

stone-jin force-pushed the fix/browser-relay-stale-session-after-navigation branch from 22a233b to 37c0186 Compare February 24, 2026 11:21

stone-jin added 2 commits February 24, 2026 19:28

openclaw-barnacle bot added size: S and removed size: XS labels Feb 24, 2026

stone-jin added 3 commits February 24, 2026 22:26

refactor(tests): simplify listTabs initialization in agent snapshot t…

07c4acd

…ests Updated the initialization of listTabs in the agent snapshot tests for better readability by removing unnecessary line breaks. This change enhances code clarity without altering the test logic.

Merge branch 'main' into fix/browser-relay-stale-session-after-naviga…

d45656b

…tion

fix(ui): widen Set type to accept string tokens in external-link helper

6ecb0f6

openclaw-barnacle bot added the app: web-ui App: web-ui label Feb 24, 2026

Merge branch 'main' into fix/browser-relay-stale-session-after-naviga…

9b43cd0

…tion

openclaw-barnacle bot removed the app: web-ui App: web-ui label Feb 24, 2026

chore: retrigger CI (unrelated Windows flaky test)

b8ca2c0

Co-authored-by: Cursor <cursoragent@cursor.com>

This was referenced Feb 28, 2026

fix(browser): refresh targetId after navigate when renderer swap changes tab target #25432

Closed

fix(browser): refresh /navigate targetId after renderer-process swap #25332

Closed

vincentkoc merged commit 28c8068 into openclaw:main Feb 28, 2026
25 checks passed

vincentkoc added a commit that referenced this pull request Feb 28, 2026

chore(changelog): add missing entry for #25326

84df22c

vincentkoc mentioned this pull request Feb 28, 2026

chore(changelog): add missing entries for #26414 #25326 #28827 #29963

Merged

18 tasks

vincentkoc added a commit that referenced this pull request Feb 28, 2026

chore(changelog): add missing entry for #25326

db25b26

github-actions bot mentioned this pull request Feb 28, 2026

📡 Upstream Digest — 2026-02-28 18:22 UTC curtismercier/openclaw-mods#147

Open

nsd97 pushed a commit to nsd97/openclaw that referenced this pull request Feb 28, 2026

chore(changelog): add missing entry for openclaw#25326

ec5c800

wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026

chore(changelog): add missing entry for openclaw#25326

983876a

wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026

chore(changelog): add missing entry for openclaw#25326

5e317a3

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream docs commits (2026-03-01-0443) hughdidit/DAISy-Agency#141

Closed

6 tasks

hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 1, 2026

chore(changelog): add missing entry for openclaw#25326

a868ff9

(cherry picked from commit db25b26)

gemini-code-assist bot mentioned this pull request Mar 1, 2026

chore(sync): replay rollup fixes on upstream/main MillionthOdin16/openclaw#111

Merged

ansh pushed a commit to vibecode/openclaw that referenced this pull request Mar 2, 2026

chore(changelog): add missing entry for openclaw#25326

a067426

steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026

chore(changelog): add missing entry for openclaw#25326

cf2b1ea

safzanpirani pushed a commit to safzanpirani/clawdbot that referenced this pull request Mar 2, 2026

chore(changelog): add missing entry for openclaw#25326

ee8ad6f

steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026

chore(changelog): add missing entry for openclaw#25326

94f75d5

robertchang-ga pushed a commit to robertchang-ga/openclaw that referenced this pull request Mar 2, 2026

chore(changelog): add missing entry for openclaw#25326

bbcd4c1

execute008 pushed a commit to execute008/openclaw that referenced this pull request Mar 2, 2026

chore(changelog): add missing entry for openclaw#25326

5fe2cf9

hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 3, 2026

chore(changelog): add missing entry for openclaw#25326

0dbd590

(cherry picked from commit db25b26)

dorgonman pushed a commit to kanohorizonia/openclaw that referenced this pull request Mar 3, 2026

chore(changelog): add missing entry for openclaw#25326

e117d7c

sachinkundu pushed a commit to sachinkundu/openclaw that referenced this pull request Mar 6, 2026

chore(changelog): add missing entry for openclaw#25326

b6d51f4

zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026

chore(changelog): add missing entry for openclaw#25326

626b14d

Mateljan1 pushed a commit to Mateljan1/openclaw that referenced this pull request Mar 7, 2026

chore(changelog): add missing entry for openclaw#25326

e73fa41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(browser): resolve correct targetId in navigate response after renderer swap#25326

fix(browser): resolve correct targetId in navigate response after renderer swap#25326
vincentkoc merged 8 commits intoopenclaw:mainfrom
stone-jin:fix/browser-relay-stale-session-after-navigation

stone-jin commented Feb 24, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

vincentkoc commented Feb 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

stone-jin commented Feb 24, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Greptile Summary

Confidence Score: 4/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vincentkoc commented Feb 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stone-jin commented Feb 24, 2026 •

edited by greptile-apps bot

Loading