fix: schedule nextWakeAtMs for isolated sessionTarget cron jobs by guirguispierre · Pull Request #19541 · openclaw/openclaw

guirguispierre · 2026-02-17T23:02:08Z

Summary

repair cron scheduling when jobs carry non-finite nextRunAtMs values so the timer can arm and nextWakeAtMs is populated
harden every schedule anchor fallback to use nowMs when external registrations omit createdAtMs
treat invalid nextRunAtMs as missing during maintenance recompute so isolated jobs self-heal instead of silently stalling
add a regression test covering isolated every jobs loaded without createdAtMs

Testing

pnpm vitest run src/cron/service.issue-regressions.test.ts src/cron/service.every-jobs-fire.test.ts src/cron/service.issue-16156-list-skips-cron.test.ts src/cron/service.rearm-timer-when-running.test.ts src/cron/service.prevents-duplicate-timers.test.ts --config vitest.unit.config.ts
pnpm vitest run src/cron/service/jobs.schedule-error-isolation.test.ts --config vitest.unit.config.ts
pnpm vitest run --config vitest.e2e.config.ts src/gateway/server.cron.e2e.test.ts

Fixes #19469

Greptile Summary

Fixed cron scheduling for isolated jobs with non-finite timestamp values

This PR addresses an issue where isolated sessionTarget cron jobs could have invalid (non-finite) nextRunAtMs values, preventing the timer from arming properly and causing jobs to stall silently.

Key Changes:

Added isFiniteTimestamp() type guard for consistent finite number validation across the cron service
Hardened resolveEveryAnchorMs() to fall back to 0 when both anchorMs and fallbackAnchorMs are non-finite, ensuring every schedules can always compute a valid anchor
Modified computeJobNextRunAtMs() to validate all return paths and only return finite timestamps or undefined
Added cleanup logic in normalizeJobTickState() to treat non-finite nextRunAtMs as missing during maintenance passes
Updated nextWakeAtMs() and armTimer() to filter out jobs with non-finite timestamps
Added regression test covering isolated jobs missing createdAtMs that validates self-healing behavior

The fix ensures legacy jobs with invalid timestamps self-heal on next service start and prevents future invalid values from propagating through the scheduling system.

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The changes are defensive additions that make the cron scheduler more robust. All modifications add validation guards without changing core scheduling logic. The fix includes comprehensive test coverage for the regression case and the implementation consistently applies Number.isFinite() checks across all relevant code paths.
No files require special attention

_{Last reviewed commit: 052b306}

_{(4/5) You can add custom instructions or style guidelines for the agent here!}

openclaw-barnacle · 2026-02-28T04:26:18Z

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

Takhoffman · 2026-02-28T16:48:52Z

Merged via squash after rebase + verification.

Merge commit: e1c8094
Local gates run on the prepared branch:

pnpm build
pnpm check