fix: correct rollup to bundle all but core#846
Merged
Conversation
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
Mar 5, 2024
toddbaert
commented
Mar 5, 2024
Member
Author
|
@lukas-reining I think this should work... please verify however you want. Thanks! |
beeme1mr
reviewed
Mar 5, 2024
beeme1mr
approved these changes
Mar 5, 2024
lukas-reining
approved these changes
Mar 5, 2024
Member
lukas-reining
left a comment
There was a problem hiding this comment.
Change looks good and works with a local angular test app for me.
This was referenced Mar 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
🤖 I have created a release *beep* *boop* --- ## [1.13.0](server-sdk-v1.12.0...server-sdk-v1.13.0) (2024-03-05) ### ✨ New Features * context propagation ([#837](#837)) ([b1abef1](b1abef1)) * maintain state in SDK, add RECONCILING ([#795](#795)) ([cfb0a69](cfb0a69)) ### 🐛 Bug Fixes * allow iteration over all event types ([#844](#844)) ([411c7b4](411c7b4)) * correct rollup to bundle all but core ([#846](#846)) ([f451e25](f451e25)) ### 🧹 Chore * **main:** release core 0.0.27 ([#839](#839)) ([ccbb1f9](ccbb1f9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.14](web-sdk-v0.4.13...web-sdk-v0.4.14) (2024-03-05) ### ✨ New Features * maintain state in SDK, add RECONCILING ([#795](#795)) ([cfb0a69](cfb0a69)) * suspend on RECONCILING, mem provider fixes ([#796](#796)) ([8101ff1](8101ff1)) ### 🐛 Bug Fixes * allow iteration over all event types ([#844](#844)) ([411c7b4](411c7b4)) * correct rollup to bundle all but core ([#846](#846)) ([f451e25](f451e25)) ### 🧹 Chore * **main:** release core 0.0.27 ([#839](#839)) ([ccbb1f9](ccbb1f9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My rollup config was invalid, but clumsily working until a recent change in how we defined the event emitter type. The impact was the the bundled types for the web imported
from 'events'instead of bundling it.This PR fixes the mis-configuration (see comments).
Here is a screenshot showing the bundled types in the dist now (notice the import is gone and the emitter is in-lined, no other changes are present):
In server, this type is available from node, so we DON'T need to bundle it, and in fact, SHOULD import it. This is easily done by importing it like
from 'node:events'. I don't think it would be a problem if we bundled it anyway, but this is more correct.Fixes: #845