Merged
Conversation
…o server SDK Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
beeme1mr
reviewed
Feb 28, 2024
Member
beeme1mr
left a comment
There was a problem hiding this comment.
Looks good so far. I'll rereview once it's marked as ready.
packages/server/src/transaction-context/async-local-storage-transaction-context-provider.ts
Show resolved
Hide resolved
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
beeme1mr
approved these changes
Mar 1, 2024
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
luizgribeiro
approved these changes
Mar 5, 2024
This was referenced Mar 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
🤖 I have created a release *beep* *boop* --- ## [1.13.0](server-sdk-v1.12.0...server-sdk-v1.13.0) (2024-03-05) ### ✨ New Features * context propagation ([#837](#837)) ([b1abef1](b1abef1)) * maintain state in SDK, add RECONCILING ([#795](#795)) ([cfb0a69](cfb0a69)) ### 🐛 Bug Fixes * allow iteration over all event types ([#844](#844)) ([411c7b4](411c7b4)) * correct rollup to bundle all but core ([#846](#846)) ([f451e25](f451e25)) ### 🧹 Chore * **main:** release core 0.0.27 ([#839](#839)) ([ccbb1f9](ccbb1f9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.1-experimental](nestjs-sdk-v0.1.0-experimental...nestjs-sdk-v0.1.1-experimental) (2024-03-05) ### ✨ New Features * context propagation ([#837](#837)) ([b1abef1](b1abef1)) * maintain state in SDK, add RECONCILING ([#795](#795)) ([cfb0a69](cfb0a69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
setTransactionContextAsyncLocalStorageTransactionContextProviderto server SDKTo me it makes much sense to add this to the server SDK as it uses the Node default way
async_hooks/async_local_storagewhich is part of Node since Node 16.x. I expect almost every project using the feature, to build exactly this so I wanted to include it in the SDK.As we are using Node types anyways I do not see a problem here, but still we could leave this out as it couples the implementation closer to Node.
Before merging I will have to change the README.