feat: maintain state in SDK, add RECONCILING by toddbaert · Pull Request #795 · open-feature/js-sdk

toddbaert · 2024-01-29T20:45:15Z

Implements the newest spec changes here.

Provider state is deprecated (state is now maintained in the SDK itself). This is non-breaking, we just ignore the provider's own state now
add RECONCILING events and state, fire related events with provider's on context change
add FATAL state

The new tests should help you understand the impact of the changes.

jest.config.ts

packages/shared/src/open-feature.ts

packages/client/src/open-feature.ts

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

toddbaert · 2024-02-27T17:58:31Z

@lukas-reining thanks for the great review. I've resolved some of your smaller comments, and left a few others open for your re-review.

beeme1mr

Please update the provider section in the client and server readmes.

lukas-reining

Looks good to me!
@toddbaert I will do the other spec change (context propagation) in another PR, which will basically just be refining the current implementation.

toddbaert · 2024-02-27T18:33:32Z

Please update the provider section in the client and server readmes.

Good point. I removed the provider status there.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

packages/client/src/open-feature.ts

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

🤖 I have created a release *beep* *boop* --- ## [0.0.27](core-v0.0.26...core-v0.0.27) (2024-03-05) ### ✨ New Features * maintain state in SDK, add RECONCILING ([#795](#795)) ([cfb0a69](cfb0a69)) ### 🐛 Bug Fixes * allow iteration over all event types ([#844](#844)) ([411c7b4](411c7b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: openfeature-peer-update-bot <openfeature-peer-update-bot@openfeature.dev> Co-authored-by: openfeature-peer-update-bot <openfeature-peer-update-bot@openfeature.dev> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>

🤖 I have created a release *beep* *boop* --- ## [1.13.0](server-sdk-v1.12.0...server-sdk-v1.13.0) (2024-03-05) ### ✨ New Features * context propagation ([#837](#837)) ([b1abef1](b1abef1)) * maintain state in SDK, add RECONCILING ([#795](#795)) ([cfb0a69](cfb0a69)) ### 🐛 Bug Fixes * allow iteration over all event types ([#844](#844)) ([411c7b4](411c7b4)) * correct rollup to bundle all but core ([#846](#846)) ([f451e25](f451e25)) ### 🧹 Chore * **main:** release core 0.0.27 ([#839](#839)) ([ccbb1f9](ccbb1f9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.4.14](web-sdk-v0.4.13...web-sdk-v0.4.14) (2024-03-05) ### ✨ New Features * maintain state in SDK, add RECONCILING ([#795](#795)) ([cfb0a69](cfb0a69)) * suspend on RECONCILING, mem provider fixes ([#796](#796)) ([8101ff1](8101ff1)) ### 🐛 Bug Fixes * allow iteration over all event types ([#844](#844)) ([411c7b4](411c7b4)) * correct rollup to bundle all but core ([#846](#846)) ([f451e25](f451e25)) ### 🧹 Chore * **main:** release core 0.0.27 ([#839](#839)) ([ccbb1f9](ccbb1f9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>

🤖 I have created a release *beep* *boop* --- ## [0.1.1-experimental](nestjs-sdk-v0.1.0-experimental...nestjs-sdk-v0.1.1-experimental) (2024-03-05) ### ✨ New Features * context propagation ([#837](#837)) ([b1abef1](b1abef1)) * maintain state in SDK, add RECONCILING ([#795](#795)) ([cfb0a69](cfb0a69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.2.1-experimental](react-sdk-v0.2.0-experimental...react-sdk-v0.2.1-experimental) (2024-03-05) ### ✨ New Features * maintain state in SDK, add RECONCILING ([#795](#795)) ([cfb0a69](cfb0a69)) * suspend on RECONCILING, mem provider fixes ([#796](#796)) ([8101ff1](8101ff1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>

toddbaert requested a review from a team as a code owner January 29, 2024 20:45

toddbaert marked this pull request as draft January 29, 2024 20:45

toddbaert force-pushed the deprecate-status branch 2 times, most recently from baafc3b to e8dcc3f Compare January 29, 2024 21:01

toddbaert changed the title ~~[PoC] feat!: deprecate status, run stale automatically~~ feat!: deprecate status, run stale automatically Jan 29, 2024

toddbaert mentioned this pull request Jan 29, 2024

Proposal to move Provider Status field from provider to SDK, refine semantics around ContextChange events open-feature/spec#238

Closed

toddbaert force-pushed the deprecate-status branch 5 times, most recently from c107127 to cf1176b Compare February 5, 2024 16:45

toddbaert changed the title ~~feat!: deprecate status, run stale automatically~~ feat!: rm status from provider, run stale in SDK Feb 5, 2024

toddbaert force-pushed the deprecate-status branch 2 times, most recently from 53fbff5 to f83aaaa Compare February 5, 2024 17:35

toddbaert force-pushed the deprecate-status branch from f83aaaa to 02cf869 Compare February 21, 2024 16:21

toddbaert changed the title ~~feat!: rm status from provider, run stale in SDK~~ feat!: implement latest spec Feb 22, 2024

toddbaert force-pushed the deprecate-status branch 2 times, most recently from 98bbf2c to 0407a30 Compare February 23, 2024 15:56

toddbaert changed the title ~~feat!: implement latest spec~~ feat: SDK maintains state, add reconciling Feb 23, 2024

toddbaert commented Feb 26, 2024

View reviewed changes

jest.config.ts Show resolved Hide resolved

toddbaert commented Feb 26, 2024

View reviewed changes

packages/shared/src/open-feature.ts Show resolved Hide resolved

toddbaert mentioned this pull request Feb 26, 2024

fix: improve event handler types #816

Merged

toddbaert marked this pull request as ready for review February 26, 2024 16:40

toddbaert force-pushed the deprecate-status branch from aa704b4 to 364fe2b Compare February 26, 2024 16:40

toddbaert requested review from beeme1mr, luizgribeiro, lukas-reining and thomaspoignant February 26, 2024 16:43

beeme1mr reviewed Feb 26, 2024

View reviewed changes

packages/client/src/open-feature.ts Outdated Show resolved Hide resolved

toddbaert requested a review from liran2000 February 27, 2024 13:53

fixup: lint

6197343

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

toddbaert requested review from beeme1mr and lukas-reining February 27, 2024 17:59

beeme1mr reviewed Feb 27, 2024

View reviewed changes

lukas-reining approved these changes Feb 27, 2024

View reviewed changes

fixup: readme

77d409c

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

toddbaert requested a review from beeme1mr February 27, 2024 19:12

toddbaert changed the title ~~feat: SDK maintains state, add reconciling~~ feat: maintain state in SDK, add RECONCILING Feb 28, 2024

beeme1mr reviewed Feb 29, 2024

View reviewed changes

packages/client/src/open-feature.ts Show resolved Hide resolved

packages/client/src/open-feature.ts Outdated Show resolved Hide resolved

fixup: naming, comment

8fe0aee

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

beeme1mr approved these changes Feb 29, 2024

View reviewed changes

toddbaert added this pull request to the merge queue Mar 1, 2024

Merged via the queue into main with commit cfb0a69 Mar 1, 2024

toddbaert deleted the deprecate-status branch March 1, 2024 14:10

This was referenced Mar 12, 2024

chore(main): release core 1.1.0 #864

Closed

chore(main): release core 1.1.0 #867

Closed

toddbaert mentioned this pull request May 17, 2024

[FEATURE] Make provider interface "stateless", SDK maintains provider state open-feature/java-sdk#844

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: maintain state in SDK, add RECONCILING#795

feat: maintain state in SDK, add RECONCILING#795
toddbaert merged 10 commits intomainfrom
deprecate-status

toddbaert commented Jan 29, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toddbaert commented Feb 27, 2024

Uh oh!

beeme1mr left a comment

Uh oh!

lukas-reining left a comment

Uh oh!

toddbaert commented Feb 27, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

toddbaert commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toddbaert commented Feb 27, 2024

Uh oh!

beeme1mr left a comment

Choose a reason for hiding this comment

Uh oh!

lukas-reining left a comment

Choose a reason for hiding this comment

Uh oh!

toddbaert commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

toddbaert commented Jan 29, 2024 •

edited

Loading

toddbaert commented Feb 27, 2024 •

edited

Loading