chore: make traversal state a string type to allow for easy printing#565
Merged
fabianburth merged 1 commit intoAug 14, 2025
Conversation
Skarlso
approved these changes
Aug 14, 2025
Skarlso
requested changes
Aug 14, 2025
Skarlso
left a comment
Contributor
There was a problem hiding this comment.
Should implement a Stringer on the iota <3
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
9a85811 to
9227475
Compare
Contributor
Author
|
okidoki - makes sense! 👍 |
Skarlso
approved these changes
Aug 14, 2025
matthiasbruns
added a commit
that referenced
this pull request
Aug 15, 2025
Based on the comment #557 (comment) #### What this PR does / why we need it Resolve file/dir inputs relative to the constructor file by wiring a filesystem working directory through input methods; default-deny path escapes with an explicit opt-out. Changes (high level): - Added WorkingDirectory handling to the input bindings #### Which issue(s) this PR fixes Fixes [#565](open-component-model/ocm-project#565) --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com>
jakobmoellerdev
added a commit
that referenced
this pull request
Aug 18, 2025
Cherry picking constructor changes from #540 #### What this PR does / why we need it Resolve file/dir inputs relative to the constructor file by wiring a filesystem working directory through input methods; default-deny path escapes with an explicit opt-out. Changes (high level): - Added WorkingDirectory handling to the input bindings #### Which issue(s) this PR fixes Fixes [#565](open-component-model/ocm-project#565) --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com>
jakobmoellerdev
pushed a commit
to jakobmoellerdev/open-component-model
that referenced
this pull request
Aug 21, 2025
…odel#548) Cherry picking filesystem changes from open-component-model#540 #### What this PR does / why we need it Resolve file/dir inputs relative to the constructor file by wiring a filesystem working directory through input methods; default-deny path escapes with an explicit opt-out. Changes (high level): - Added WorkingDirectory to FS config #### Which issue(s) this PR fixes Fixes [open-component-model#565](open-component-model/ocm-project#565) Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
jakobmoellerdev
added a commit
that referenced
this pull request
Aug 22, 2025
#### What this PR does / why we need it Resolve file/dir inputs relative to the constructor file by wiring a filesystem working directory through input methods; default-deny path escapes with an explicit opt-out. Changes (high level): - Added WorkingDirectory to FS config and flag plumbing in CLI. - Updated file/dir input methods to use the working dir + path utils; tests updated for path handling. #### Which issue(s) this PR fixes Fixes [#565](open-component-model/ocm-project#565) --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com>
jakobmoellerdev
pushed a commit
that referenced
this pull request
Aug 22, 2025
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it - Add missing tests for [#565](open-component-model/ocm-project#565) #### Which issue(s) this PR fixes Fixes [#565](open-component-model/ocm-project#565) --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
iota cannot easily be printed, which is quite annoying for rendering the graph. lets change it while we still can.
Which issue(s) this PR fixes
Contributes to open-component-model/ocm-project#563