feat(565): relative file pointers dir input e2e#613
Merged
jakobmoellerdev merged 3 commits intoAug 22, 2025
Merged
Conversation
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing end-to-end tests for issue #565, which appears to be related to relative file pointers and directory input functionality. The changes focus on testing working directory behavior when adding component versions to OCM repositories.
- Adds test cases for working directory validation when constructing component versions
- Updates dependencies to use specific version tags instead of commit hashes
- Verifies both failure and success scenarios for file path resolution with working directories
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cli/cmd/download/plugin/integration/go.mod | Updates dependency versions from commit hashes to semantic version tags |
| cli/cmd/cmd_test.go | Adds comprehensive test cases for working directory behavior in component version construction |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> feat: update cmd tests to cover working-directory flag On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
51a2e82 to
47b33c2
Compare
jakobmoellerdev
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #565