Skip to content

feat(565): update filesystem to support working dir#548

Merged
jakobmoellerdev merged 1 commit into
open-component-model:mainfrom
matthiasbruns:feat/565_relative_file_pointers_filesystem
Aug 13, 2025
Merged

feat(565): update filesystem to support working dir#548
jakobmoellerdev merged 1 commit into
open-component-model:mainfrom
matthiasbruns:feat/565_relative_file_pointers_filesystem

Conversation

@matthiasbruns

Copy link
Copy Markdown
Contributor

Cherry picking filesystem changes from #540

What this PR does / why we need it

Resolve file/dir inputs relative to the constructor file by wiring a filesystem working directory through input methods; default-deny path escapes with an explicit opt-out.

Changes (high level):

  • Added WorkingDirectory to FS config

Which issue(s) this PR fixes

Fixes #565

Copilot AI review requested due to automatic review settings August 13, 2025 09:50
@matthiasbruns matthiasbruns requested a review from a team as a code owner August 13, 2025 09:50
@github-actions github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/xs Extra small labels Aug 13, 2025
@matthiasbruns matthiasbruns changed the title feat(565): update filesystem to support working dir feat: update filesystem to support working dir Aug 13, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a working directory configuration in the filesystem configuration to resolve file/directory inputs relative to the constructor file location, with default-deny path escapes and explicit opt-out capability.

  • Added WorkingDirectory field to the filesystem configuration struct
  • Updated the Merge function to handle the new WorkingDirectory field during configuration merging

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread bindings/go/configuration/filesystem/v1alpha1/spec/config.go
@matthiasbruns matthiasbruns force-pushed the feat/565_relative_file_pointers_filesystem branch from cf10539 to a89e4ba Compare August 13, 2025 09:51
@matthiasbruns matthiasbruns changed the title feat: update filesystem to support working dir feat(565): update filesystem to support working dir Aug 13, 2025
@matthiasbruns matthiasbruns force-pushed the feat/565_relative_file_pointers_filesystem branch from a89e4ba to f7ce7fe Compare August 13, 2025 09:53
Comment thread bindings/go/configuration/filesystem/v1alpha1/spec/config.go
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns matthiasbruns force-pushed the feat/565_relative_file_pointers_filesystem branch from f7ce7fe to 2ea0276 Compare August 13, 2025 09:56
@github-actions github-actions Bot added the size/s Small label Aug 13, 2025
@jakobmoellerdev jakobmoellerdev merged commit cd292de into open-component-model:main Aug 13, 2025
17 checks passed
@matthiasbruns matthiasbruns deleted the feat/565_relative_file_pointers_filesystem branch August 13, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature new feature, enhancement, improvement, extension size/s Small size/xs Extra small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make file and dir inputs support relative paths

3 participants