feat: make the base logger settable#368
Closed
Skarlso wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Skarlso
commented
Jul 8, 2025
jakobmoellerdev
left a comment
Member
There was a problem hiding this comment.
IMO instead of doing this you should kill all occurences of base and just pass instance loggers everywhere.
Contributor
Author
|
I didn't want to break the Base contract that's why I thought I do it like this. Also I can just call. repo := &Repository{
scheme: options.Scheme,
localArtifactManifestCache: options.LocalManifestCache,
localArtifactLayerCache: options.LocalLayerCache,
resolver: options.Resolver,
creatorAnnotation: options.Creator,
resourceCopyOptions: *options.ResourceCopyOptions,
referrerTrackingPolicy: options.ReferrerTrackingPolicy,
logger: options.Logger,
}
repo.setBaseLogger()And it would work fine from there. :D But your suggestion is cleaner. |
Member
|
Yah you have a point but I think it was a mistake that I added it as a package level variable. its always an anti pattern long term... |
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
9eb4e4f to
8542ecd
Compare
| return nil, err | ||
| } | ||
| log.Base().Log(ctx, slog.LevelDebug, "listed version candidates", slog.Int("count", len(candidates))) | ||
| log.Base(ctx).Log(ctx, slog.LevelDebug, "listed version candidates", slog.Int("count", len(candidates))) |
Member
There was a problem hiding this comment.
that looks completely off. youre passing the context twice even though the log interface already has a context with it. whats the purpose of the context then?
Contributor
Author
There was a problem hiding this comment.
huh, where am I passing it twice?
Contributor
Author
There was a problem hiding this comment.
Oh. I see. The Log(ctx, is the context for the slog Logger. While the Base(ctx) is our context for the OCI logger package.
Member
There was a problem hiding this comment.
log.Base(ctx).Log(ctx) the slog interface already has context awareness
Member
There was a problem hiding this comment.
See for example https://github.com/veqryn/slog-context to see how this can be used
Contributor
Author
There was a problem hiding this comment.
That's the slogger. That's not what we want to configure here. This context contains our instance of a slog logger. Log(ctx) is useless for the oci/logger package.
Contributor
Author
There was a problem hiding this comment.
Ah interesting. I take a look at that package.
Contributor
Author
|
Superseeded by #374 |
matthiasbruns
pushed a commit
that referenced
this pull request
Jun 1, 2026
This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [softprops/action-gh-release](https://redirect.github.com/softprops/action-gh-release) | action | major | `v2` → `v3` | [](https://securityscorecards.dev/viewer/?uri=github.com/softprops/action-gh-release) | --- > [!WARNING] > Some dependencies could not be looked up. Check the [Dependency Dashboard](../issues/331) for more information. --- ### Release Notes <details> <summary>softprops/action-gh-release (softprops/action-gh-release)</summary> ### [`v3.0.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v3.0.0) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v3.0.0...v3.0.0) `3.0.0` is a major release that moves the action runtime from Node 20 to Node 24. Use `v3` on GitHub-hosted runners and self-hosted fleets that already support the Node 24 Actions runtime. If you still need the last Node 20-compatible line, stay on `v2.6.2`. #### What's Changed ##### Other Changes 🔄 - Move the action runtime and bundle target to Node 24 - Update `@types/node` to the Node 24 line and allow future Dependabot updates - Keep the floating major tag on `v3`; `v2` remains pinned to the latest `2.x` release ### [`v3`](https://redirect.github.com/softprops/action-gh-release/compare/v2.6.2...v3.0.0) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.6.2...v3.0.0) ### [`v2.6.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.6.2) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.6.1...v2.6.2) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Other Changes 🔄 - chore(deps): bump picomatch from 4.0.3 to 4.0.4 by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​775](https://redirect.github.com/softprops/action-gh-release/pull/775) - chore(deps): bump brace-expansion from 5.0.4 to 5.0.5 by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​777](https://redirect.github.com/softprops/action-gh-release/pull/777) - chore(deps): bump vite from 8.0.0 to 8.0.5 by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​781](https://redirect.github.com/softprops/action-gh-release/pull/781) **Full Changelog**: <softprops/action-gh-release@v2...v2.6.2> ### [`v2.6.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.6.1) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.6.0...v2.6.1) `2.6.1` is a patch release focused on restoring linked discussion thread creation when `discussion_category_name` is set. It fixes `#764`, where the draft-first publish flow stopped carrying the discussion category through the final publish step. If you still hit an issue after upgrading, please open a report with the bug template and include a minimal repro or sanitized workflow snippet where possible. #### What's Changed ##### Bug fixes 🐛 - fix: preserve discussion category on publish by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​765](https://redirect.github.com/softprops/action-gh-release/pull/765) ### [`v2.6.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.6.0) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.5.3...v2.6.0) `2.6.0` is a minor release centered on `previous_tag` support for `generate_release_notes`, which lets workflows pin GitHub's comparison base explicitly instead of relying on the default range. It also includes the recent concurrent asset upload recovery fix, a `working_directory` docs sync, a checked-bundle freshness guard for maintainers, and clearer immutable-prerelease guidance where GitHub platform behavior imposes constraints on how prerelease asset uploads can be published. If you still hit an issue after upgrading, please open a report with the bug template and include a minimal repro or sanitized workflow snippet where possible. #### What's Changed ##### Exciting New Features 🎉 - feat: support previous\_tag for generate\_release\_notes by [@​pocesar](https://redirect.github.com/pocesar) in [#​372](https://redirect.github.com/softprops/action-gh-release/pull/372) ##### Bug fixes 🐛 - fix: recover concurrent asset metadata 404s by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​760](https://redirect.github.com/softprops/action-gh-release/pull/760) ##### Other Changes 🔄 - docs: clarify reused draft release behavior by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​759](https://redirect.github.com/softprops/action-gh-release/pull/759) - docs: clarify working\_directory input by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​761](https://redirect.github.com/softprops/action-gh-release/pull/761) - ci: verify dist bundle freshness by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​762](https://redirect.github.com/softprops/action-gh-release/pull/762) - fix: clarify immutable prerelease uploads by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​763](https://redirect.github.com/softprops/action-gh-release/pull/763) ### [`v2.5.3`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.5.3) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.5.2...v2.5.3) <!-- Release notes generated using configuration in .github/release.yml at master --> `2.5.3` is a patch release focused on the remaining path-handling and release-selection bugs uncovered after `2.5.2`. It fixes `#639`, `#571`, `#280`, `#614`, `#311`, `#403`, and `#368`. It also adds documentation clarifications for `#541`, `#645`, `#542`, `#393`, and `#411`, where the current behavior is either usage-sensitive or constrained by GitHub platform limits rather than an action-side runtime bug. If you still hit an issue after upgrading, please open a report with the bug template and include a minimal repro or sanitized workflow snippet where possible. #### What's Changed ##### Bug fixes 🐛 - fix: prefer token input over GITHUB\_TOKEN by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​751](https://redirect.github.com/softprops/action-gh-release/pull/751) - fix: clean up duplicate drafts after canonicalization by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​753](https://redirect.github.com/softprops/action-gh-release/pull/753) - fix: support Windows-style file globs by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​754](https://redirect.github.com/softprops/action-gh-release/pull/754) - fix: normalize refs-tag inputs by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​755](https://redirect.github.com/softprops/action-gh-release/pull/755) - fix: expand tilde file paths by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​756](https://redirect.github.com/softprops/action-gh-release/pull/756) ##### Other Changes 🔄 - docs: clarify token precedence by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​752](https://redirect.github.com/softprops/action-gh-release/pull/752) - docs: clarify GitHub release limits by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​758](https://redirect.github.com/softprops/action-gh-release/pull/758) - documentation clarifications for empty-token handling, `preserve_order`, and special-character asset filename behavior **Full Changelog**: <softprops/action-gh-release@v2...v2.5.3> ### [`v2.5.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.5.2) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.5.1...v2.5.2) <!-- Release notes generated using configuration in .github/release.yml at master --> `2.5.2` is a patch release focused on the remaining release-creation and prerelease regressions in the `2.5.x` bug-fix cycle. It fixes `#705`, fixes `#708`, fixes `#740`, fixes `#741`, and fixes `#722`. Regression testing covers the shared-tag race, prerelease event behavior, dotfile asset labels, same-filename concurrent uploads, and blocked-tag cleanup behavior. If you still hit an issue after upgrading, please open a report with the bug template and include a minimal repro or sanitized workflow snippet where possible. #### What's Changed ##### Bug fixes 🐛 - fix: canonicalize releases after concurrent create by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​746](https://redirect.github.com/softprops/action-gh-release/pull/746) - fix: preserve prereleased events for prereleases by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​748](https://redirect.github.com/softprops/action-gh-release/pull/748) - fix: restore dotfile asset labels by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​749](https://redirect.github.com/softprops/action-gh-release/pull/749) - fix: handle upload already\_exists races across workflows by [@​api2062](https://redirect.github.com/api2062) in [#​745](https://redirect.github.com/softprops/action-gh-release/pull/745) - fix: clean up orphan drafts when tag creation is blocked by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​750](https://redirect.github.com/softprops/action-gh-release/pull/750) #### New Contributors - [@​api2062](https://redirect.github.com/api2062) made their first contribution in [#​745](https://redirect.github.com/softprops/action-gh-release/pull/745) **Full Changelog**: <softprops/action-gh-release@v2...v2.5.2> ### [`v2.5.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.5.1) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.5.0...v2.5.1) <!-- Release notes generated using configuration in .github/release.yml at master --> `2.5.1` is a patch release focused on regressions introduced in `2.5.0` and on release lookup reliability. It fixes `#713`, addresses `#703`, and fixes `#724`. Regression testing shows that current `master` no longer reproduces the finalize-race behavior reported in `#704` and `#709`. #### What's Changed ##### Bug fixes 🐛 - fix: fetch correct asset URL after finalization; test; some refactoring by [@​pzhlkj6612](https://redirect.github.com/pzhlkj6612) in [#​738](https://redirect.github.com/softprops/action-gh-release/pull/738) - fix: release marked as 'latest' despite make\_latest: false by [@​Boshen](https://redirect.github.com/Boshen) in [#​715](https://redirect.github.com/softprops/action-gh-release/pull/715) - fix: use getReleaseByTag API instead of iterating all releases by [@​kim-em](https://redirect.github.com/kim-em) in [#​725](https://redirect.github.com/softprops/action-gh-release/pull/725) ##### Other Changes 🔄 - dependency updates, including the ESM/runtime compatibility refresh in [#​731](https://redirect.github.com/softprops/action-gh-release/pull/731) #### New Contributors - [@​autarch](https://redirect.github.com/autarch) made their first contribution in [#​716](https://redirect.github.com/softprops/action-gh-release/pull/716) - [@​pzhlkj6612](https://redirect.github.com/pzhlkj6612) made their first contribution in [#​738](https://redirect.github.com/softprops/action-gh-release/pull/738) - [@​Boshen](https://redirect.github.com/Boshen) made their first contribution in [#​715](https://redirect.github.com/softprops/action-gh-release/pull/715) - [@​kim-em](https://redirect.github.com/kim-em) made their first contribution in [#​725](https://redirect.github.com/softprops/action-gh-release/pull/725) **Full Changelog**: <softprops/action-gh-release@v2...v2.5.1> ### [`v2.5.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.5.0) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.4.2...v2.5.0) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Exciting New Features 🎉 - feat: mark release as draft until all artifacts are uploaded by [@​dumbmoron](https://redirect.github.com/dumbmoron) in [#​692](https://redirect.github.com/softprops/action-gh-release/pull/692) ##### Other Changes 🔄 - chore(deps): bump the npm group across 1 directory with 5 updates by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​697](https://redirect.github.com/softprops/action-gh-release/pull/697) - chore(deps): bump actions/checkout from 5.0.0 to 5.0.1 in the github-actions group by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​689](https://redirect.github.com/softprops/action-gh-release/pull/689) #### New Contributors - [@​dumbmoron](https://redirect.github.com/dumbmoron) made their first contribution in [#​692](https://redirect.github.com/softprops/action-gh-release/pull/692) **Full Changelog**: <softprops/action-gh-release@v2.4.2...v2.5.0> ### [`v2.4.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.4.2) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.4.1...v2.4.2) #### What's Changed ##### Exciting New Features 🎉 - feat: Ensure generated release notes cannot be over 125000 characters by [@​BeryJu](https://redirect.github.com/BeryJu) in [#​684](https://redirect.github.com/softprops/action-gh-release/pull/684) ##### Other Changes 🔄 - dependency updates #### New Contributors - [@​BeryJu](https://redirect.github.com/BeryJu) made their first contribution in [#​684](https://redirect.github.com/softprops/action-gh-release/pull/684) **Full Changelog**: <softprops/action-gh-release@v2.4.1...v2.4.2> ### [`v2.4.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.4.1) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.4.0...v2.4.1) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Other Changes 🔄 - fix(util): support brace expansion globs containing commas in parseInputFiles by [@​Copilot](https://redirect.github.com/Copilot) in [#​672](https://redirect.github.com/softprops/action-gh-release/pull/672) - fix: gracefully fallback to body when body\_path cannot be read by [@​Copilot](https://redirect.github.com/Copilot) in [#​671](https://redirect.github.com/softprops/action-gh-release/pull/671) **Full Changelog**: <softprops/action-gh-release@v2...v2.4.1> ### [`v2.4.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.4.0) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.3.4...v2.4.0) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Exciting New Features 🎉 - feat(action): respect working\_directory for files globs by [@​stephenway](https://redirect.github.com/stephenway) in [#​667](https://redirect.github.com/softprops/action-gh-release/pull/667) ##### Other Changes 🔄 - chore(deps): bump the npm group with 2 updates by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​668](https://redirect.github.com/softprops/action-gh-release/pull/668) **Full Changelog**: <softprops/action-gh-release@v2.3.4...v2.4.0> ### [`v2.3.4`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.3.4) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.3.3...v2.3.4) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Bug fixes 🐛 - fix(action): handle 422 already\_exists race condition by [@​stephenway](https://redirect.github.com/stephenway) in [#​665](https://redirect.github.com/softprops/action-gh-release/pull/665) ##### Other Changes 🔄 - chore(deps): bump actions/setup-node from 4.4.0 to 5.0.0 in the github-actions group by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​656](https://redirect.github.com/softprops/action-gh-release/pull/656) - chore(deps): bump [@​types/node](https://redirect.github.com/types/node) from 20.19.11 to 20.19.13 in the npm group by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​655](https://redirect.github.com/softprops/action-gh-release/pull/655) - chore(deps): bump vite from 7.0.0 to 7.1.5 by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​657](https://redirect.github.com/softprops/action-gh-release/pull/657) - chore(deps): bump the npm group across 1 directory with 2 updates by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​662](https://redirect.github.com/softprops/action-gh-release/pull/662) - chore(deps): bump the npm group with 3 updates by [@​dependabot](https://redirect.github.com/dependabot)\[bot] in [#​666](https://redirect.github.com/softprops/action-gh-release/pull/666) **Full Changelog**: <softprops/action-gh-release@v2...v2.3.4> ### [`v2.3.3`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.3.3) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.3.2...v2.3.3) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Exciting New Features 🎉 - feat: add input option `overwrite_files` by [@​asfernandes](https://redirect.github.com/asfernandes) in [#​343](https://redirect.github.com/softprops/action-gh-release/pull/343) ##### Other Changes 🔄 - dependency updates #### New Contributors - [@​asfernandes](https://redirect.github.com/asfernandes) made their first contribution in [#​343](https://redirect.github.com/softprops/action-gh-release/pull/343) **Full Changelog**: <softprops/action-gh-release@v2...v2.3.3> ### [`v2.3.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.3.2) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.3.1...v2.3.2) - fix: revert fs `readableWebStream` change ### [`v2.3.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.3.1) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.3.0...v2.3.1) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Bug fixes 🐛 - fix: fix file closing issue by [@​WailGree](https://redirect.github.com/WailGree) in [#​629](https://redirect.github.com/softprops/action-gh-release/pull/629) #### New Contributors - [@​WailGree](https://redirect.github.com/WailGree) made their first contribution in [#​629](https://redirect.github.com/softprops/action-gh-release/pull/629) **Full Changelog**: <softprops/action-gh-release@v2.3.0...v2.3.1> ### [`v2.3.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.3.0) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.2.2...v2.3.0) <!-- Release notes generated using configuration in .github/release.yml at master --> - Migrate from jest to vitest - Replace `mime` with `mime-types` - Bump to use node 24 - Dependency updates **Full Changelog**: <softprops/action-gh-release@v2.2.2...v2.3.0> ### [`v2.2.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.2.2) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.2.1...v2.2.2) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Bug fixes 🐛 - fix: updating release draft status from true to false by [@​galargh](https://redirect.github.com/galargh) in [#​316](https://redirect.github.com/softprops/action-gh-release/pull/316) ##### Other Changes 🔄 - chore: simplify ref\_type test by [@​steinybot](https://redirect.github.com/steinybot) in [#​598](https://redirect.github.com/softprops/action-gh-release/pull/598) - fix(docs): clarify the default for tag\_name by [@​muzimuzhi](https://redirect.github.com/muzimuzhi) in [#​599](https://redirect.github.com/softprops/action-gh-release/pull/599) - test(release): add unit tests when searching for a release by [@​rwaskiewicz](https://redirect.github.com/rwaskiewicz) in [#​603](https://redirect.github.com/softprops/action-gh-release/pull/603) - dependency updates #### New Contributors - [@​steinybot](https://redirect.github.com/steinybot) made their first contribution in [#​598](https://redirect.github.com/softprops/action-gh-release/pull/598) - [@​muzimuzhi](https://redirect.github.com/muzimuzhi) made their first contribution in [#​599](https://redirect.github.com/softprops/action-gh-release/pull/599) - [@​galargh](https://redirect.github.com/galargh) made their first contribution in [#​316](https://redirect.github.com/softprops/action-gh-release/pull/316) - [@​rwaskiewicz](https://redirect.github.com/rwaskiewicz) made their first contribution in [#​603](https://redirect.github.com/softprops/action-gh-release/pull/603) **Full Changelog**: <softprops/action-gh-release@v2.2.1...v2.2.2> ### [`v2.2.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.2.1) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.2.0...v2.2.1) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Bug fixes 🐛 - fix: big file uploads by [@​xen0n](https://redirect.github.com/xen0n) in [#​562](https://redirect.github.com/softprops/action-gh-release/pull/562) ##### Other Changes 🔄 - chore(deps): bump [@​types/node](https://redirect.github.com/types/node) from 22.10.1 to 22.10.2 by [@​dependabot](https://redirect.github.com/dependabot) in [#​559](https://redirect.github.com/softprops/action-gh-release/pull/559) - chore(deps): bump [@​types/node](https://redirect.github.com/types/node) from 22.10.2 to 22.10.5 by [@​dependabot](https://redirect.github.com/dependabot) in [#​569](https://redirect.github.com/softprops/action-gh-release/pull/569) - chore: update error and warning messages for not matching files in files field by [@​ytimocin](https://redirect.github.com/ytimocin) in [#​568](https://redirect.github.com/softprops/action-gh-release/pull/568) #### New Contributors - [@​ytimocin](https://redirect.github.com/ytimocin) made their first contribution in [#​568](https://redirect.github.com/softprops/action-gh-release/pull/568) **Full Changelog**: <softprops/action-gh-release@v2.2.0...v2.2.1> ### [`v2.2.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.2.0) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.1.0...v2.2.0) #### What's Changed ##### Exciting New Features 🎉 - feat: read the release assets asynchronously by [@​xen0n](https://redirect.github.com/xen0n) in [#​552](https://redirect.github.com/softprops/action-gh-release/pull/552) ##### Bug fixes 🐛 - fix(docs): clarify the default for tag\_name by [@​alexeagle](https://redirect.github.com/alexeagle) in [#​544](https://redirect.github.com/softprops/action-gh-release/pull/544) ##### Other Changes 🔄 - chore(deps): bump typescript from 5.6.3 to 5.7.2 by [@​dependabot](https://redirect.github.com/dependabot) in [#​548](https://redirect.github.com/softprops/action-gh-release/pull/548) - chore(deps): bump [@​types/node](https://redirect.github.com/types/node) from 22.9.0 to 22.9.4 by [@​dependabot](https://redirect.github.com/dependabot) in [#​547](https://redirect.github.com/softprops/action-gh-release/pull/547) - chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 by [@​dependabot](https://redirect.github.com/dependabot) in [#​545](https://redirect.github.com/softprops/action-gh-release/pull/545) - chore(deps): bump [@​vercel/ncc](https://redirect.github.com/vercel/ncc) from 0.38.2 to 0.38.3 by [@​dependabot](https://redirect.github.com/dependabot) in [#​543](https://redirect.github.com/softprops/action-gh-release/pull/543) - chore(deps): bump prettier from 3.3.3 to 3.4.1 by [@​dependabot](https://redirect.github.com/dependabot) in [#​550](https://redirect.github.com/softprops/action-gh-release/pull/550) - chore(deps): bump [@​types/node](https://redirect.github.com/types/node) from 22.9.4 to 22.10.1 by [@​dependabot](https://redirect.github.com/dependabot) in [#​551](https://redirect.github.com/softprops/action-gh-release/pull/551) - chore(deps): bump prettier from 3.4.1 to 3.4.2 by [@​dependabot](https://redirect.github.com/dependabot) in [#​554](https://redirect.github.com/softprops/action-gh-release/pull/554) #### New Contributors - [@​alexeagle](https://redirect.github.com/alexeagle) made their first contribution in [#​544](https://redirect.github.com/softprops/action-gh-release/pull/544) - [@​xen0n](https://redirect.github.com/xen0n) made their first contribution in [#​552](https://redirect.github.com/softprops/action-gh-release/pull/552) **Full Changelog**: <softprops/action-gh-release@v2.1.0...v2.2.0> ### [`v2.1.0`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.1.0) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.9...v2.1.0) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Exciting New Features 🎉 - feat: add support for release assets with multiple spaces within the name by [@​dukhine](https://redirect.github.com/dukhine) in [#​518](https://redirect.github.com/softprops/action-gh-release/pull/518) - feat: preserve upload order by [@​richarddd](https://redirect.github.com/richarddd) in [#​500](https://redirect.github.com/softprops/action-gh-release/pull/500) ##### Other Changes 🔄 - chore(deps): bump [@​types/node](https://redirect.github.com/types/node) from 22.8.2 to 22.8.7 by [@​dependabot](https://redirect.github.com/dependabot) in [#​539](https://redirect.github.com/softprops/action-gh-release/pull/539) #### New Contributors - [@​dukhine](https://redirect.github.com/dukhine) made their first contribution in [#​518](https://redirect.github.com/softprops/action-gh-release/pull/518) - [@​richarddd](https://redirect.github.com/richarddd) made their first contribution in [#​500](https://redirect.github.com/softprops/action-gh-release/pull/500) **Full Changelog**: <softprops/action-gh-release@v2...v2.1.0> ### [`v2.0.9`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.9) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.8...v2.0.9) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed - maintenance release with updated dependencies #### New Contributors - [@​kbakdev](https://redirect.github.com/kbakdev) made their first contribution in [#​521](https://redirect.github.com/softprops/action-gh-release/pull/521) **Full Changelog**: <softprops/action-gh-release@v2...v2.0.9> ### [`v2.0.8`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.8) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.7...v2.0.8) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Other Changes 🔄 - chore(deps): bump prettier from 2.8.0 to 3.3.3 by [@​dependabot](https://redirect.github.com/dependabot) in [#​480](https://redirect.github.com/softprops/action-gh-release/pull/480) - chore(deps): bump [@​types/node](https://redirect.github.com/types/node) from 20.14.9 to 20.14.11 by [@​dependabot](https://redirect.github.com/dependabot) in [#​483](https://redirect.github.com/softprops/action-gh-release/pull/483) - chore(deps): bump [@​octokit/plugin-throttling](https://redirect.github.com/octokit/plugin-throttling) from 9.3.0 to 9.3.1 by [@​dependabot](https://redirect.github.com/dependabot) in [#​484](https://redirect.github.com/softprops/action-gh-release/pull/484) - chore(deps): bump glob from 10.4.2 to 11.0.0 by [@​dependabot](https://redirect.github.com/dependabot) in [#​477](https://redirect.github.com/softprops/action-gh-release/pull/477) - refactor: write jest config in ts by [@​chenrui333](https://redirect.github.com/chenrui333) in [#​485](https://redirect.github.com/softprops/action-gh-release/pull/485) - chore(deps): bump [@​actions/github](https://redirect.github.com/actions/github) from 5.1.1 to 6.0.0 by [@​dependabot](https://redirect.github.com/dependabot) in [#​470](https://redirect.github.com/softprops/action-gh-release/pull/470) **Full Changelog**: <softprops/action-gh-release@v2...v2.0.8> ### [`v2.0.7`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.7) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.6...v2.0.7) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Bug fixes 🐛 - Fix missing update release body by [@​FirelightFlagboy](https://redirect.github.com/FirelightFlagboy) in [#​365](https://redirect.github.com/softprops/action-gh-release/pull/365) ##### Other Changes 🔄 - Bump [@​octokit/plugin-retry](https://redirect.github.com/octokit/plugin-retry) from 4.0.3 to 7.1.1 by [@​dependabot](https://redirect.github.com/dependabot) in [#​443](https://redirect.github.com/softprops/action-gh-release/pull/443) - Bump typescript from 4.9.5 to 5.5.2 by [@​dependabot](https://redirect.github.com/dependabot) in [#​467](https://redirect.github.com/softprops/action-gh-release/pull/467) - Bump [@​types/node](https://redirect.github.com/types/node) from 20.14.6 to 20.14.8 by [@​dependabot](https://redirect.github.com/dependabot) in [#​469](https://redirect.github.com/softprops/action-gh-release/pull/469) - Bump [@​types/node](https://redirect.github.com/types/node) from 20.14.8 to 20.14.9 by [@​dependabot](https://redirect.github.com/dependabot) in [#​473](https://redirect.github.com/softprops/action-gh-release/pull/473) - Bump typescript from 5.5.2 to 5.5.3 by [@​dependabot](https://redirect.github.com/dependabot) in [#​472](https://redirect.github.com/softprops/action-gh-release/pull/472) - Bump ts-jest from 29.1.5 to 29.2.2 by [@​dependabot](https://redirect.github.com/dependabot) in [#​479](https://redirect.github.com/softprops/action-gh-release/pull/479) - docs: document that existing releases are updated by [@​jvanbruegge](https://redirect.github.com/jvanbruegge) in [#​474](https://redirect.github.com/softprops/action-gh-release/pull/474) #### New Contributors - [@​jvanbruegge](https://redirect.github.com/jvanbruegge) made their first contribution in [#​474](https://redirect.github.com/softprops/action-gh-release/pull/474) - [@​FirelightFlagboy](https://redirect.github.com/FirelightFlagboy) made their first contribution in [#​365](https://redirect.github.com/softprops/action-gh-release/pull/365) **Full Changelog**: <softprops/action-gh-release@v2.0.6...v2.0.7> ### [`v2.0.6`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.6) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.5...v2.0.6) maintenance release with updated dependencies ### [`v2.0.5`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.5) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.4...v2.0.5) - Factor in file names with spaces when upserting files [#​446](https://redirect.github.com/softprops/action-gh-release/pull/446) via [@​MystiPanda](https://redirect.github.com/MystiPanda) - Improvements to error handling [#​449](https://redirect.github.com/softprops/action-gh-release/pull/449) via [@​till](https://redirect.github.com/till) ### [`v2.0.4`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.4) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.3...v2.0.4) - Minor follow up to [#​417](https://redirect.github.com/softprops/action-gh-release/pull/417). [#​425](https://redirect.github.com/softprops/action-gh-release/pull/425) ### [`v2.0.3`](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.2...v2.0.3) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.2...v2.0.3) ### [`v2.0.2`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.2) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2.0.1...v2.0.2) - Revisit approach to [#​384](https://redirect.github.com/softprops/action-gh-release/pull/384) making unresolved pattern failures opt-in [#​417](https://redirect.github.com/softprops/action-gh-release/pull/417) ### [`v2.0.1`](https://redirect.github.com/softprops/action-gh-release/releases/tag/v2.0.1) [Compare Source](https://redirect.github.com/softprops/action-gh-release/compare/v2...v2.0.1) - Add support for make\_latest property [#​304](https://redirect.github.com/softprops/action-gh-release/pull/304) via [@​samueljseay](https://redirect.github.com/samueljseay) - Fail run if files setting contains invalid patterns [#​384](https://redirect.github.com/softprops/action-gh-release/pull/384) via [@​rpdelaney](https://redirect.github.com/rpdelaney) - Add support for proxy env variables (don't use node-fetch) [#​386/](https://redirect.github.com/softprops/action-gh-release/pull/386/) via [@​timor-raiman](https://redirect.github.com/timor-raiman) - Suppress confusing warning when input\_files is empty [#​389](https://redirect.github.com/softprops/action-gh-release/pull/389) via [@​Drowze](https://redirect.github.com/Drowze) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xOTYuMSIsInVwZGF0ZWRJblZlciI6IjQzLjE5Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: ocmbot[bot] <125909804+ocmbot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes