Skip to content

feat: make the base logger configurable through context#374

Merged
jakobmoellerdev merged 2 commits into
open-component-model:mainfrom
Skarlso:make-base-configurable-2
Jul 9, 2025
Merged

feat: make the base logger configurable through context#374
jakobmoellerdev merged 2 commits into
open-component-model:mainfrom
Skarlso:make-base-configurable-2

Conversation

@Skarlso

@Skarlso Skarlso commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Which issue(s) this PR fixes

@Skarlso Skarlso requested a review from a team as a code owner July 9, 2025 08:48
@github-actions github-actions Bot added the kind/feature new feature, enhancement, improvement, extension label Jul 9, 2025
@github-actions github-actions Bot added the size/m Medium label Jul 9, 2025
@Skarlso Skarlso force-pushed the make-base-configurable-2 branch from 4b63699 to 8d45618 Compare July 9, 2025 08:49
@Skarlso

Skarlso commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

@jakobmoellerdev This is the new approach. Indeed, it looks much slicker.

@jakobmoellerdev jakobmoellerdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, this looks a lot better!

Comment thread bindings/go/oci/ctf/store_test.go Outdated
Comment thread bindings/go/oci/repository.go Outdated
Comment thread bindings/go/oci/resolver/url/resolver_test.go Outdated
@Skarlso Skarlso force-pushed the make-base-configurable-2 branch from e8a0677 to a4f56e8 Compare July 9, 2025 10:12
@Skarlso

Skarlso commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

Bah, the DCO didn't like my commit suggestion merge via the UI. :/ Bummer.

@Skarlso Skarlso force-pushed the make-base-configurable-2 branch from a4f56e8 to 7f7ef16 Compare July 9, 2025 10:58
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the make-base-configurable-2 branch from 7f7ef16 to ba4124e Compare July 9, 2025 10:59
@Skarlso Skarlso requested a review from jakobmoellerdev July 9, 2025 10:59
@jakobmoellerdev jakobmoellerdev enabled auto-merge (squash) July 9, 2025 12:08
@jakobmoellerdev jakobmoellerdev merged commit e8327a5 into open-component-model:main Jul 9, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature new feature, enhancement, improvement, extension size/m Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants