Skip to content

fix: prefer token input over GITHUB_TOKEN#751

Merged
chenrui333 merged 1 commit intosoftprops:masterfrom
chenrui333:token-selection-fix
Mar 15, 2026
Merged

fix: prefer token input over GITHUB_TOKEN#751
chenrui333 merged 1 commit intosoftprops:masterfrom
chenrui333:token-selection-fix

Conversation

@chenrui333
Copy link
Copy Markdown
Collaborator

@chenrui333 chenrui333 commented Mar 15, 2026

Summary

  • prefer a non-empty token input over GITHUB_TOKEN
  • ignore empty-string token inputs so callers with an explicit GITHUB_TOKEN env can still fall back cleanly
  • cover the precedence and fallback cases in parseConfig tests

fixes #639

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 marked this pull request as ready for review March 15, 2026 02:27
@chenrui333 chenrui333 added the bug Something isn't working label Mar 15, 2026
@chenrui333 chenrui333 merged commit b36466e into softprops:master Mar 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a release (with file upload) on another repo just broke

1 participant