Handle language tag on code blocks#848
Merged
jonludlam merged 1 commit intoocaml:masterfrom Jun 8, 2022
Merged
Conversation
Contributor
|
Nice, I've been wanting to do something like that for a while. It should be used for the latex backend as well (but @Octachron knows better if that's complicated or not, it depend on the underlying macros). |
Pass the language tag through the model and to highlightjs in the html generator. The value is ignored in other backends.
Contributor
I think they should rather default to Also would fix #759. |
Member
|
I think we should address changing of currently existing defaults in a separate issue/PR. |
Contributor
|
That's not really changing a default, that's actually getting on par with |
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Dec 13, 2022
CHANGES: Additions - New unstable option `--as-json` for the HTML renderer that emits HTML fragments (preamble, content) together with metadata (table of contents, breadcrumbs, whether katex is used) in JSON format. (@sabine, ocaml/odoc#908) - New maths support via `{m ... }` and `{math ... }` tags. (@giltho, @gpetiot, ocaml/odoc#886) - Various optimisations (@jonludlam, ocaml/odoc#870, ocaml/odoc#883) - Better handling of alerts and deprecation notices. (@panglesd, ocaml/odoc#828) - Handle language tags on code blocks (@Julow, ocaml/odoc#848) Bugfixes - Shadowing issues (@jonludlam, ocaml/odoc#853) - Layout fixes and improvements (@panglesd, ocaml/odoc#832, ocaml/odoc#839, ocaml/odoc#847) - Handle comments on class constraints and inherit (@Julow, ocaml/odoc#844) - Disable the missing root warning (@jonludlam, ocaml/odoc#881)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the language tag through the model and to highlightjs in the html generator. The value is ignored in other backends.
Code blocks with no language specified are rendered as before (highlighted).
Highlightjs should recognize
plain,plaintextandtextto disable highlighting but perhaps we should have a string specific to Odoc that we can document and handle specifically ?The version of highlightjs vendored only support one language (OCaml) and is not updated in this PR.