Handle comments attached to class constraint and inherit#844
Merged
jonludlam merged 4 commits intoocaml:masterfrom Jun 29, 2022
Merged
Handle comments attached to class constraint and inherit#844jonludlam merged 4 commits intoocaml:masterfrom
jonludlam merged 4 commits intoocaml:masterfrom
Conversation
jonludlam
approved these changes
Jun 29, 2022
Member
jonludlam
left a comment
There was a problem hiding this comment.
This all looks good, and surprisingly doesn't require any rebasing!
Comment were not added into the model.
Constraints are handled separately and are not associated with their comment. As a quick workaround, turn these into standalone comments.
Floating comments in classes are 4.08 and beyond
44a8b0e to
e5e6c3d
Compare
Member
|
Actually in order to get the tests run it did require rebasing :-) I've split the classes test in two as well as it was failing on OCaml < 4.08 |
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Dec 13, 2022
CHANGES: Additions - New unstable option `--as-json` for the HTML renderer that emits HTML fragments (preamble, content) together with metadata (table of contents, breadcrumbs, whether katex is used) in JSON format. (@sabine, ocaml/odoc#908) - New maths support via `{m ... }` and `{math ... }` tags. (@giltho, @gpetiot, ocaml/odoc#886) - Various optimisations (@jonludlam, ocaml/odoc#870, ocaml/odoc#883) - Better handling of alerts and deprecation notices. (@panglesd, ocaml/odoc#828) - Handle language tags on code blocks (@Julow, ocaml/odoc#848) Bugfixes - Shadowing issues (@jonludlam, ocaml/odoc#853) - Layout fixes and improvements (@panglesd, ocaml/odoc#832, ocaml/odoc#839, ocaml/odoc#847) - Handle comments on class constraints and inherit (@Julow, ocaml/odoc#844) - Disable the missing root warning (@jonludlam, ocaml/odoc#881)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #574
The changes in the
cmtiloader is straightforward however it's not fully implemented for other inputs:cmts, the constraints are not read from the typedtree and I haven't made the effort to associate the comments correctly. Comments attached to constraints will appear as standalone comments anywhere in the class.cmis, it seems that these comments are lost ?Most of the diffs is because of boilerplate due to changing some types in the model.